ahmido
7ac53f4cc4
Implements spec 111 (Findings workflow + SLA) and fixes Workspace findings SLA settings UX/validation. Key changes: - Findings workflow service + SLA policy and alerting. - Workspace settings: allow partial SLA overrides without auto-filling unset severities in the UI; effective values still resolve via defaults. - New migrations, jobs, command, UI/resource updates, and comprehensive test coverage. Tests: - `vendor/bin/sail artisan test --compact` (1779 passed, 8 skipped). Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #135
82 lines
3.9 KiB
PHP
82 lines
3.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Pages\Settings\WorkspaceSettings;
|
|
use App\Models\AuditLog;
|
|
use App\Models\User;
|
|
use App\Models\Workspace;
|
|
use App\Models\WorkspaceMembership;
|
|
use App\Models\WorkspaceSetting;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Actions\Testing\TestAction;
|
|
use Livewire\Livewire;
|
|
|
|
it('allows view-only members to view workspace settings but forbids save and per-setting reset mutations', function (): void {
|
|
$workspace = Workspace::factory()->create();
|
|
$user = User::factory()->create();
|
|
|
|
WorkspaceMembership::factory()->create([
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
'user_id' => (int) $user->getKey(),
|
|
'role' => 'readonly',
|
|
]);
|
|
|
|
WorkspaceSetting::factory()->create([
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
'domain' => 'backup',
|
|
'key' => 'retention_keep_last_default',
|
|
'value' => 27,
|
|
'updated_by_user_id' => null,
|
|
]);
|
|
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $workspace->getKey());
|
|
|
|
$this->actingAs($user)
|
|
->get(WorkspaceSettings::getUrl(panel: 'admin'))
|
|
->assertSuccessful();
|
|
|
|
Livewire::actingAs($user)
|
|
->test(WorkspaceSettings::class)
|
|
->assertSet('data.backup_retention_keep_last_default', 27)
|
|
->assertSet('data.backup_retention_min_floor', null)
|
|
->assertSet('data.drift_severity_mapping', [])
|
|
->assertSet('data.findings_sla_critical', null)
|
|
->assertSet('data.findings_sla_high', null)
|
|
->assertSet('data.findings_sla_medium', null)
|
|
->assertSet('data.findings_sla_low', null)
|
|
->assertSet('data.operations_operation_run_retention_days', null)
|
|
->assertSet('data.operations_stuck_run_threshold_minutes', null)
|
|
->assertActionVisible('save')
|
|
->assertActionDisabled('save')
|
|
->assertFormComponentActionVisible('backup_retention_keep_last_default', 'reset_backup_retention_keep_last_default', [], 'content')
|
|
->assertFormComponentActionDisabled('backup_retention_keep_last_default', 'reset_backup_retention_keep_last_default', [], 'content')
|
|
->assertFormComponentActionVisible('backup_retention_min_floor', 'reset_backup_retention_min_floor', [], 'content')
|
|
->assertFormComponentActionDisabled('backup_retention_min_floor', 'reset_backup_retention_min_floor', [], 'content')
|
|
->assertFormComponentActionVisible('drift_severity_mapping', 'reset_drift_severity_mapping', [], 'content')
|
|
->assertFormComponentActionDisabled('drift_severity_mapping', 'reset_drift_severity_mapping', [], 'content')
|
|
->assertActionVisible(TestAction::make('reset_findings_sla_days')->schemaComponent('findings_section'))
|
|
->assertActionDisabled(TestAction::make('reset_findings_sla_days')->schemaComponent('findings_section'))
|
|
->assertFormComponentActionVisible('operations_operation_run_retention_days', 'reset_operations_operation_run_retention_days', [], 'content')
|
|
->assertFormComponentActionDisabled('operations_operation_run_retention_days', 'reset_operations_operation_run_retention_days', [], 'content')
|
|
->assertFormComponentActionVisible('operations_stuck_run_threshold_minutes', 'reset_operations_stuck_run_threshold_minutes', [], 'content')
|
|
->assertFormComponentActionDisabled('operations_stuck_run_threshold_minutes', 'reset_operations_stuck_run_threshold_minutes', [], 'content')
|
|
->call('save')
|
|
->assertStatus(403);
|
|
|
|
Livewire::actingAs($user)
|
|
->test(WorkspaceSettings::class)
|
|
->call('resetSetting', 'backup_retention_keep_last_default')
|
|
->assertStatus(403);
|
|
|
|
expect(AuditLog::query()->count())->toBe(0);
|
|
|
|
$setting = WorkspaceSetting::query()
|
|
->where('workspace_id', (int) $workspace->getKey())
|
|
->where('domain', 'backup')
|
|
->where('key', 'retention_keep_last_default')
|
|
->first();
|
|
|
|
expect($setting)->not->toBeNull();
|
|
});
|