ahmido
bda1d90fc4
Implements spec 094 (assignment fetch/restore observability hardening): - Adds OperationRun tracking for assignment fetch (during backup) and assignment restore (during restore execution) - Normalizes failure codes/reason_code and sanitizes failure messages - Ensures exactly one audit log entry per assignment restore execution - Enforces correct guard/membership vs capability semantics on affected admin surfaces - Switches assignment Graph services to depend on GraphClientInterface Also includes Postgres-only FK defense-in-depth check and a discoverable `composer test:pgsql` runner (scoped to the FK constraint test). Tests: - `vendor/bin/sail artisan test --compact` (passed) - `vendor/bin/sail composer test:pgsql` (passed) Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #113
105 lines
3.2 KiB
PHP
105 lines
3.2 KiB
PHP
<?php
|
|
|
|
use App\Models\Tenant;
|
|
use App\Support\Auth\Capabilities;
|
|
use App\Support\Auth\UiTooltips;
|
|
use App\Support\Rbac\UiEnforcement;
|
|
use Filament\Actions\Action;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('hides actions for non-members on record-scoped surfaces', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user] = createUserWithTenant();
|
|
|
|
$action = Action::make('test')->action(fn () => null);
|
|
|
|
UiEnforcement::forAction($action)
|
|
->requireCapability(Capabilities::TENANT_VIEW)
|
|
->apply();
|
|
|
|
$this->actingAs($user);
|
|
$action->record($tenant);
|
|
|
|
expect($action->isHidden())->toBeTrue();
|
|
});
|
|
|
|
it('disables actions with the standard tooltip for members without the capability', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user] = createUserWithTenant($tenant, role: 'readonly');
|
|
|
|
$action = Action::make('test')->action(fn () => null);
|
|
|
|
UiEnforcement::forAction($action)
|
|
->requireCapability(Capabilities::TENANT_SYNC)
|
|
->apply();
|
|
|
|
$this->actingAs($user);
|
|
$action->record($tenant);
|
|
|
|
expect($action->isHidden())->toBeFalse();
|
|
expect($action->isDisabled())->toBeTrue();
|
|
expect($action->getTooltip())->toBe(UiTooltips::insufficientPermission());
|
|
});
|
|
|
|
it('enables actions for members with the capability', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user] = createUserWithTenant($tenant, role: 'owner');
|
|
|
|
$action = Action::make('test')->action(fn () => null);
|
|
|
|
UiEnforcement::forAction($action)
|
|
->requireCapability(Capabilities::TENANT_SYNC)
|
|
->apply();
|
|
|
|
$this->actingAs($user);
|
|
$action->record($tenant);
|
|
|
|
expect($action->isHidden())->toBeFalse();
|
|
expect($action->isDisabled())->toBeFalse();
|
|
expect($action->getTooltip())->toBeNull();
|
|
});
|
|
|
|
it('preserveVisibility combines existing visibility with membership checks', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user] = createUserWithTenant($tenant, role: 'owner');
|
|
|
|
$action = Action::make('test')
|
|
->action(fn () => null)
|
|
->visible(fn (): bool => false);
|
|
|
|
UiEnforcement::forAction($action)
|
|
->preserveVisibility()
|
|
->requireCapability(Capabilities::TENANT_VIEW)
|
|
->apply();
|
|
|
|
$this->actingAs($user);
|
|
$action->record($tenant);
|
|
|
|
expect($action->isHidden())->toBeTrue();
|
|
});
|
|
|
|
it('disables bulk actions for mixed-authorization selections (capability preflight)', function () {
|
|
$tenantA = Tenant::factory()->create();
|
|
$tenantB = Tenant::factory()->create();
|
|
|
|
[$user] = createUserWithTenant($tenantA, role: 'owner');
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$tenantB->getKey() => ['role' => 'readonly'],
|
|
]);
|
|
|
|
$action = Action::make('test')->action(fn () => null);
|
|
|
|
$enforcement = UiEnforcement::forAction($action)
|
|
->requireCapability(Capabilities::TENANT_SYNC);
|
|
|
|
expect($enforcement->bulkSelectionIsAuthorized($user, collect([$tenantA, $tenantB])))->toBeFalse();
|
|
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$tenantB->getKey() => ['role' => 'owner'],
|
|
]);
|
|
|
|
expect($enforcement->bulkSelectionIsAuthorized($user, collect([$tenantA, $tenantB])))->toBeTrue();
|
|
});
|