## Summary - amend the operator UI constitution and related SpecKit templates for the new UI/UX governance rules - add Spec 168 artifacts plus the tenant governance aggregate implementation used by the tenant dashboard, banner, and baseline compare landing surfaces - normalize Filament action surfaces around clickable-row inspection, grouped secondary actions, and explicit action-surface declarations across enrolled resources and pages - fix post-suite regressions in membership cache priming, finding workflow state refresh, tenant review derived-state invalidation, and tenant-bound backup-set related navigation ## Commit Series - `docs: amend operator UI constitution` - `spec: add tenant governance aggregate contract` - `feat: add tenant governance aggregate contract` - `refactor: normalize filament action surfaces` - `fix: resolve post-suite state regressions` ## Testing - `vendor/bin/sail artisan test --compact` - Result: `3176 passed, 8 skipped (17384 assertions)` ## Notes - Livewire v4 / Filament v5 stack remains unchanged - no provider registration changes; `bootstrap/providers.php` remains the relevant location - no new global-search resources or asset-registration changes in this branch Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #199
123 lines
4.6 KiB
PHP
123 lines
4.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Widgets\Dashboard\BaselineCompareNow;
|
|
use App\Filament\Widgets\Dashboard\NeedsAttention;
|
|
use App\Models\BaselineProfile;
|
|
use App\Models\BaselineSnapshot;
|
|
use App\Models\BaselineTenantAssignment;
|
|
use App\Models\Tenant;
|
|
use App\Support\Baselines\BaselineCompareReasonCode;
|
|
use App\Support\Baselines\TenantGovernanceAggregateResolver;
|
|
use App\Support\OperationRunOutcome;
|
|
use App\Support\OperationRunStatus;
|
|
use App\Support\OperationRunType;
|
|
use App\Support\Ui\DerivedState\DerivedStateFamily;
|
|
use App\Support\Ui\DerivedState\RequestScopedDerivedStateStore;
|
|
use Filament\Facades\Filament;
|
|
use Livewire\Livewire;
|
|
|
|
function createTenantGovernanceMemoizationTenant(): array
|
|
{
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$profile = BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
]);
|
|
|
|
$snapshot = BaselineSnapshot::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'baseline_profile_id' => (int) $profile->getKey(),
|
|
]);
|
|
|
|
$profile->update(['active_snapshot_id' => (int) $snapshot->getKey()]);
|
|
|
|
BaselineTenantAssignment::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'baseline_profile_id' => (int) $profile->getKey(),
|
|
]);
|
|
|
|
\App\Models\OperationRun::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'type' => OperationRunType::BaselineCompare->value,
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Succeeded->value,
|
|
'completed_at' => now(),
|
|
'context' => [
|
|
'baseline_profile_id' => (int) $profile->getKey(),
|
|
'baseline_snapshot_id' => (int) $snapshot->getKey(),
|
|
'baseline_compare' => [
|
|
'reason_code' => BaselineCompareReasonCode::NoDriftDetected->value,
|
|
'coverage' => [
|
|
'effective_types' => ['deviceConfiguration'],
|
|
'covered_types' => ['deviceConfiguration'],
|
|
'uncovered_types' => [],
|
|
'proof' => true,
|
|
],
|
|
],
|
|
],
|
|
]);
|
|
|
|
return [$user, $tenant];
|
|
}
|
|
|
|
it('reuses one tenant-governance aggregate across the tenant dashboard summary widgets', function (): void {
|
|
[$user, $tenant] = createTenantGovernanceMemoizationTenant();
|
|
|
|
$this->actingAs($user);
|
|
Filament::setCurrentPanel(Filament::getPanel('tenant'));
|
|
Filament::setTenant($tenant, true);
|
|
|
|
Livewire::actingAs($user)->test(NeedsAttention::class);
|
|
Livewire::actingAs($user)->test(BaselineCompareNow::class);
|
|
|
|
expect(app(RequestScopedDerivedStateStore::class)->countStored(
|
|
DerivedStateFamily::TenantGovernanceAggregate,
|
|
Tenant::class,
|
|
(string) $tenant->getKey(),
|
|
TenantGovernanceAggregateResolver::VARIANT_TENANT_GOVERNANCE_SUMMARY,
|
|
))->toBe(1);
|
|
});
|
|
|
|
it('keeps tenant switches from reusing another tenant aggregate in the same request scope', function (): void {
|
|
[, $tenantA] = createTenantGovernanceMemoizationTenant();
|
|
[, $tenantB] = createTenantGovernanceMemoizationTenant();
|
|
|
|
$resolver = app(TenantGovernanceAggregateResolver::class);
|
|
|
|
$aggregateA = $resolver->forTenant($tenantA);
|
|
$aggregateB = $resolver->forTenant($tenantB);
|
|
|
|
$store = app(RequestScopedDerivedStateStore::class);
|
|
|
|
expect($aggregateA)->not->toBeNull()
|
|
->and($aggregateB)->not->toBeNull()
|
|
->and($aggregateA?->tenantId)->toBe((int) $tenantA->getKey())
|
|
->and($aggregateB?->tenantId)->toBe((int) $tenantB->getKey())
|
|
->and($aggregateA?->tenantId)->not->toBe($aggregateB?->tenantId)
|
|
->and($store->countStored(
|
|
DerivedStateFamily::TenantGovernanceAggregate,
|
|
Tenant::class,
|
|
(string) $tenantA->getKey(),
|
|
TenantGovernanceAggregateResolver::VARIANT_TENANT_GOVERNANCE_SUMMARY,
|
|
))->toBe(1)
|
|
->and($store->countStored(
|
|
DerivedStateFamily::TenantGovernanceAggregate,
|
|
Tenant::class,
|
|
(string) $tenantB->getKey(),
|
|
TenantGovernanceAggregateResolver::VARIANT_TENANT_GOVERNANCE_SUMMARY,
|
|
))->toBe(1);
|
|
});
|
|
|
|
it('returns no aggregate and stores nothing when no tenant context exists', function (): void {
|
|
$aggregate = app(TenantGovernanceAggregateResolver::class)->forTenant(null);
|
|
|
|
expect($aggregate)->toBeNull()
|
|
->and(app(RequestScopedDerivedStateStore::class)->countStored(
|
|
DerivedStateFamily::TenantGovernanceAggregate,
|
|
))->toBe(0);
|
|
});
|