ahmido
d6e7de597a
Implements Spec 087: Legacy Runs Removal (rigorous). ### What changed - Canonicalized run history: **`operation_runs` is the only run system** for inventory sync, Entra group sync, backup schedule execution/retention/purge. - Removed legacy UI surfaces (Filament Resources / relation managers) for legacy run models. - Legacy run URLs now return **404** (no redirects), with RBAC semantics preserved (404 vs 403 as specified). - Canonicalized affected `operation_runs.type` values (dotted → underscore) via migration. - Drift + inventory references now point to canonical operation runs; includes backfills and then drops legacy FK columns. - Drops legacy run tables after cutover. - Added regression guards to prevent reintroducing legacy run tokens or “backfilling” canonical runs from legacy tables. ### Migrations - `2026_02_12_000001..000006_*` canonicalize types, add/backfill operation_run_id references, drop legacy columns, and drop legacy run tables. ### Tests Focused pack for this spec passed: - `tests/Feature/Guards/NoLegacyRunsTest.php` - `tests/Feature/Guards/NoLegacyRunBackfillTest.php` - `tests/Feature/Operations/LegacyRunRoutesNotFoundTest.php` - `tests/Feature/Monitoring/MonitoringOperationsTest.php` - `tests/Feature/Jobs/RunInventorySyncJobTest.php` ### Notes / impact - Destructive cleanup is handled via migrations (drops legacy tables) after code cutover; deploy should run migrations in the same release. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #106
121 lines
3.6 KiB
PHP
121 lines
3.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\OperationRun;
|
|
use App\Services\OperationRunService;
|
|
use Filament\Facades\Filament;
|
|
|
|
it('renders only whitelisted numeric summary counts in terminal notifications', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'initiator_name' => $user->name,
|
|
'type' => 'inventory_sync',
|
|
'status' => 'queued',
|
|
'outcome' => 'pending',
|
|
'context' => ['scope' => 'all'],
|
|
]);
|
|
|
|
/** @var OperationRunService $service */
|
|
$service = app(OperationRunService::class);
|
|
|
|
$service->updateRun(
|
|
$run,
|
|
status: 'completed',
|
|
outcome: 'succeeded',
|
|
summaryCounts: [
|
|
'total' => '10',
|
|
'processed' => 5.2,
|
|
'failed' => 'nope',
|
|
'secrets' => 123,
|
|
],
|
|
failures: [],
|
|
);
|
|
|
|
$notification = $user->notifications()->latest('id')->first();
|
|
expect($notification)->not->toBeNull();
|
|
|
|
$body = (string) ($notification->data['body'] ?? '');
|
|
|
|
expect($body)->toContain('Summary:');
|
|
expect($body)->toContain('total: 10');
|
|
expect($body)->toContain('processed: 5');
|
|
expect($body)->not->toContain('secrets');
|
|
expect($body)->not->toContain('failed:');
|
|
})->group('ops-ux');
|
|
|
|
it('sanitizes summary_counts values and drops non-whitelisted keys', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'initiator_name' => $user->name,
|
|
'type' => 'policy.delete',
|
|
'status' => 'queued',
|
|
'outcome' => 'pending',
|
|
'context' => ['operation' => ['type' => 'policy.delete']],
|
|
'summary_counts' => [],
|
|
]);
|
|
|
|
/** @var OperationRunService $service */
|
|
$service = app(OperationRunService::class);
|
|
|
|
$service->updateRun(
|
|
$run,
|
|
status: 'running',
|
|
outcome: null,
|
|
summaryCounts: [
|
|
'processed' => '2',
|
|
'failed' => 1.2,
|
|
'secrets' => 999,
|
|
'' => 5,
|
|
'total' => 'not-a-number',
|
|
],
|
|
);
|
|
|
|
$run->refresh();
|
|
|
|
expect($run->summary_counts['processed'] ?? null)->toBe(2);
|
|
expect($run->summary_counts['failed'] ?? null)->toBe(1);
|
|
expect($run->summary_counts)->not->toHaveKey('secrets');
|
|
expect($run->summary_counts)->not->toHaveKey('');
|
|
expect($run->summary_counts)->not->toHaveKey('total');
|
|
})->group('ops-ux');
|
|
|
|
it('ignores non-whitelisted keys when incrementing summary_counts', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'initiator_name' => $user->name,
|
|
'type' => 'policy.delete',
|
|
'status' => 'queued',
|
|
'outcome' => 'pending',
|
|
'context' => ['operation' => ['type' => 'policy.delete']],
|
|
'summary_counts' => ['processed' => 1, 'secrets' => 5],
|
|
]);
|
|
|
|
/** @var OperationRunService $service */
|
|
$service = app(OperationRunService::class);
|
|
|
|
$service->incrementSummaryCounts($run, [
|
|
'processed' => 1,
|
|
'secrets' => 10,
|
|
]);
|
|
|
|
$run->refresh();
|
|
|
|
expect($run->summary_counts['processed'] ?? null)->toBe(2);
|
|
expect($run->summary_counts)->not->toHaveKey('secrets');
|
|
})->group('ops-ux');
|