ahmido
8426741068
## Summary - add explicit BaselineSnapshot lifecycle truth with conservative backfill and a shared truth resolver - block baseline compare from building, incomplete, or superseded snapshots and align workspace/tenant UI truth surfaces with effective snapshot state - surface artifact truth separately from operation outcome across baseline profile, snapshot, compare, and operation run pages ## Testing - integrated browser smoke test on the active feature surfaces - `vendor/bin/sail artisan test --compact tests/Feature/Filament/BaselineSnapshotTruthSurfaceTest.php tests/Feature/Filament/BaselineProfileCompareStartSurfaceTest.php` - targeted baseline lifecycle and compare guard coverage added in Pest - `vendor/bin/sail bin pint --dirty --format agent` ## Notes - Livewire v4 compliance preserved - no panel provider registration changes were needed; Laravel 12 providers remain in `bootstrap/providers.php` - global search remains disabled for the affected baseline resources by design - destructive actions remain confirmation-gated; capture and compare actions keep their existing authorization and confirmation behavior - no new panel assets were added; existing deploy flow for `filament:assets` is unchanged Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #189
68 lines
2.8 KiB
PHP
68 lines
2.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\BaselineProfile;
|
|
use App\Models\BaselineSnapshot;
|
|
use App\Models\Workspace;
|
|
use App\Support\Baselines\BaselineReasonCodes;
|
|
use App\Support\Baselines\BaselineSnapshotLifecycleState;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('defaults factory snapshots to complete and consumable', function (): void {
|
|
$snapshot = BaselineSnapshot::factory()->make();
|
|
|
|
expect($snapshot->lifecycleState())->toBe(BaselineSnapshotLifecycleState::Complete)
|
|
->and($snapshot->isConsumable())->toBeTrue()
|
|
->and($snapshot->isComplete())->toBeTrue();
|
|
});
|
|
|
|
it('tracks lifecycle transitions and completion proof metadata', function (): void {
|
|
$workspace = Workspace::factory()->create();
|
|
$profile = BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
]);
|
|
|
|
$snapshot = BaselineSnapshot::factory()->complete()->create([
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
'baseline_profile_id' => (int) $profile->getKey(),
|
|
]);
|
|
|
|
$snapshot->markBuilding(['expected_items' => 3]);
|
|
$snapshot->refresh();
|
|
|
|
expect($snapshot->lifecycleState())->toBe(BaselineSnapshotLifecycleState::Building)
|
|
->and($snapshot->completed_at)->toBeNull()
|
|
->and(data_get($snapshot->completion_meta_jsonb, 'expected_items'))->toBe(3);
|
|
|
|
$snapshot->markComplete('truth-hash', ['persisted_items' => 3]);
|
|
$snapshot->refresh();
|
|
|
|
expect($snapshot->lifecycleState())->toBe(BaselineSnapshotLifecycleState::Complete)
|
|
->and($snapshot->snapshot_identity_hash)->toBe('truth-hash')
|
|
->and($snapshot->completed_at)->not->toBeNull()
|
|
->and($snapshot->failed_at)->toBeNull()
|
|
->and(data_get($snapshot->completion_meta_jsonb, 'persisted_items'))->toBe(3);
|
|
});
|
|
|
|
it('marks snapshots incomplete with a persisted reason code', function (): void {
|
|
$snapshot = BaselineSnapshot::factory()->building()->create();
|
|
|
|
$snapshot->markIncomplete(BaselineReasonCodes::SNAPSHOT_COMPLETION_PROOF_FAILED, ['persisted_items' => 1]);
|
|
$snapshot->refresh();
|
|
|
|
expect($snapshot->lifecycleState())->toBe(BaselineSnapshotLifecycleState::Incomplete)
|
|
->and($snapshot->failed_at)->not->toBeNull()
|
|
->and($snapshot->completed_at)->toBeNull()
|
|
->and(data_get($snapshot->completion_meta_jsonb, 'finalization_reason_code'))->toBe(BaselineReasonCodes::SNAPSHOT_COMPLETION_PROOF_FAILED)
|
|
->and(data_get($snapshot->completion_meta_jsonb, 'persisted_items'))->toBe(1);
|
|
});
|
|
|
|
it('refuses to transition incomplete snapshots back to complete', function (): void {
|
|
$snapshot = BaselineSnapshot::factory()->incomplete()->create();
|
|
|
|
expect(fn () => $snapshot->markComplete('retry-hash'))->toThrow(RuntimeException::class);
|
|
});
|