ahmido
45a804970e
## Summary - complete Spec 136 canonical admin tenant rollout across admin-visible and shared Filament surfaces - add the shared panel-aware tenant resolver helper, persisted filter-state synchronization, and admin navigation segregation for tenant-sensitive resources - expand regression, guard, and parity coverage for admin-path tenant resolution, stale filters, workspace-wide tenant-default surfaces, and panel split behavior ## Validation - `vendor/bin/sail artisan test --compact tests/Feature/Guards/AdminTenantResolverGuardTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/Filament/TableStatePersistenceTest.php` - `vendor/bin/sail artisan test --compact --filter='CanonicalAdminTenantFilterState|PolicyResource|BackupSchedule|BackupSet|FindingResource|BaselineCompareLanding|RestoreRunResource|InventoryItemResource|PolicyVersionResource|ProviderConnectionResource|TenantDiagnostics|InventoryCoverage|InventoryKpiHeader|AuditLog|EntraGroup'` - `vendor/bin/sail bin pint --dirty --format agent` ## Notes - Livewire v4.0+ compliance is preserved with Filament v5. - Provider registration remains unchanged in `bootstrap/providers.php`. - `PolicyResource` and `PolicyVersionResource` have admin global search disabled explicitly; `EntraGroupResource` keeps admin-aware scoped search with a View page. - Destructive and governance-sensitive actions retain existing confirmation and authorization behavior while using canonical tenant parity. - No new assets were introduced, so deployment asset strategy is unchanged and does not add new `filament:assets` work. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #165
108 lines
3.3 KiB
PHP
108 lines
3.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\AlertRuleResource;
|
|
use App\Filament\Resources\BaselineProfileResource;
|
|
use App\Filament\Resources\TenantResource;
|
|
use App\Models\AlertRule;
|
|
use App\Models\BaselineProfile;
|
|
use App\Models\Tenant;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('keeps workspace-only admin surfaces accessible without canonical tenant context', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
AlertRule::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'name' => 'Workspace alert rule',
|
|
]);
|
|
|
|
BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'name' => 'Workspace baseline',
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
Filament::setTenant(null, true);
|
|
|
|
$session = [
|
|
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
|
|
];
|
|
|
|
$this->withSession($session)
|
|
->get(AlertRuleResource::getUrl(panel: 'admin'))
|
|
->assertOk()
|
|
->assertSee('Workspace alert rule');
|
|
|
|
$this->withSession($session)
|
|
->get(BaselineProfileResource::getUrl(panel: 'admin'))
|
|
->assertOk()
|
|
->assertSee('Workspace baseline');
|
|
|
|
$this->withSession($session)
|
|
->get(TenantResource::getUrl(panel: 'admin'))
|
|
->assertOk()
|
|
->assertSee($tenant->name);
|
|
});
|
|
|
|
it('keeps workspace-only admin surfaces independent from remembered tenant changes', function (): void {
|
|
$tenantA = Tenant::factory()->create([
|
|
'name' => 'Phoenicon',
|
|
'environment' => 'dev',
|
|
]);
|
|
[$user, $tenantA] = createUserWithTenant(tenant: $tenantA, role: 'owner');
|
|
|
|
$tenantB = Tenant::factory()->create([
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
'name' => 'YPTW2',
|
|
'environment' => 'dev',
|
|
]);
|
|
|
|
createUserWithTenant(tenant: $tenantB, user: $user, role: 'owner');
|
|
|
|
AlertRule::factory()->create([
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
'name' => 'Workspace-wide alert rule',
|
|
]);
|
|
|
|
BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
'name' => 'Workspace-wide baseline',
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
Filament::setTenant(null, true);
|
|
|
|
$workspaceId = (int) $tenantA->workspace_id;
|
|
|
|
foreach ([$tenantA, $tenantB] as $rememberedTenant) {
|
|
$session = [
|
|
WorkspaceContext::SESSION_KEY => $workspaceId,
|
|
WorkspaceContext::LAST_TENANT_IDS_SESSION_KEY => [
|
|
(string) $workspaceId => (int) $rememberedTenant->getKey(),
|
|
],
|
|
];
|
|
|
|
$this->withSession($session)
|
|
->get(AlertRuleResource::getUrl(panel: 'admin'))
|
|
->assertOk()
|
|
->assertSee('Workspace-wide alert rule');
|
|
|
|
$this->withSession($session)
|
|
->get(BaselineProfileResource::getUrl(panel: 'admin'))
|
|
->assertOk()
|
|
->assertSee('Workspace-wide baseline');
|
|
|
|
$this->withSession($session)
|
|
->get(TenantResource::getUrl(panel: 'admin'))
|
|
->assertOk()
|
|
->assertSee('Phoenicon')
|
|
->assertSee('YPTW2');
|
|
}
|
|
});
|