## Summary - replace broad substring-based masking with a shared exact/path-based secret classifier and workspace-scoped fingerprint hashing - persist protected snapshot metadata on `policy_versions` and keep secret-only changes visible in compare, drift, restore, review, verification, and ops surfaces - add Spec 120 artifacts, audit documentation, and focused Pest regression coverage for snapshot, audit, verification, review-pack, and notification behavior ## Validation - `vendor/bin/sail artisan test --compact tests/Feature/Intune/PolicySnapshotRedactionTest.php tests/Feature/Intune/PolicySnapshotFingerprintIsolationTest.php tests/Feature/ReviewPack/ReviewPackRedactionIntegrityTest.php tests/Feature/OpsUx/OperationRunNotificationRedactionTest.php tests/Feature/Verification/VerificationReportViewerDbOnlyTest.php` - `vendor/bin/sail bin pint --dirty --format agent` ## Spec / checklist status | Checklist | Total | Completed | Incomplete | Status | |-----------|-------|-----------|------------|--------| | requirements.md | 16 | 16 | 0 | ✓ PASS | - `tasks.md`: T001-T032 complete - `tasks.md`: T033 manual quickstart validation is still open and noted for follow-up ## Filament / platform notes - Livewire v4 compliance is unchanged - no panel provider changes; `bootstrap/providers.php` remains the registration location - no new globally searchable resources were introduced, so global search requirements are unchanged - no new destructive Filament actions were added - no new Filament assets were added; no `filament:assets` deployment change is required ## Testing coverage touched - snapshot persistence and fingerprint isolation - compare/drift protected-change evidence - audit, verification, review-pack, ops-failure, and notification sanitization - viewer/read-only Filament presentation updates Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #146
55 lines
1.6 KiB
PHP
55 lines
1.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\Policy;
|
|
use App\Services\Intune\VersionService;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Tests\Support\ProtectedSnapshotAssertions;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('derives different secret fingerprints per workspace for the same protected value', function (): void {
|
|
[$userA, $tenantA] = createUserWithTenant(role: 'owner');
|
|
[$userB, $tenantB] = createUserWithTenant(role: 'owner');
|
|
|
|
$policyA = Policy::factory()->create([
|
|
'tenant_id' => (int) $tenantA->getKey(),
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
]);
|
|
|
|
$policyB = Policy::factory()->create([
|
|
'tenant_id' => (int) $tenantB->getKey(),
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
]);
|
|
|
|
/** @var VersionService $service */
|
|
$service = app(VersionService::class);
|
|
|
|
$versionA = $service->captureVersion(
|
|
policy: $policyA,
|
|
payload: [
|
|
'wifi' => [
|
|
'password' => 'same-secret',
|
|
],
|
|
],
|
|
createdBy: $userA->email,
|
|
);
|
|
|
|
$versionB = $service->captureVersion(
|
|
policy: $policyB,
|
|
payload: [
|
|
'wifi' => [
|
|
'password' => 'same-secret',
|
|
],
|
|
],
|
|
createdBy: $userB->email,
|
|
);
|
|
|
|
ProtectedSnapshotAssertions::assertFingerprint($versionA->secret_fingerprints, 'snapshot', '/wifi/password');
|
|
ProtectedSnapshotAssertions::assertFingerprint($versionB->secret_fingerprints, 'snapshot', '/wifi/password');
|
|
|
|
expect($versionA->secret_fingerprints['snapshot']['/wifi/password'])
|
|
->not->toBe($versionB->secret_fingerprints['snapshot']['/wifi/password']);
|
|
});
|