ahmido
fb4de17c63
Implements Spec 089: moves Provider Connections to canonical tenantless route under `/admin/provider-connections`, enforces 404/403 semantics (workspace/tenant membership vs capability), adds tenant transparency (tenant column + filter + deep links), adds legacy redirects for old tenant-scoped URLs without leaking Location for 404 cases, and adds regression test coverage (RBAC semantics, filters, UI enforcement tooltips, Microsoft-only MVP scope, navigation placement). Notes: - Filament v5 / Livewire v4 compatible. - Global search remains disabled for Provider Connections. - Destructive/manage actions require confirmation and are policy-gated. Tests: - `vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #107
66 lines
2.4 KiB
PHP
66 lines
2.4 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\ProviderConnection;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
|
|
it('redirects legacy tenant-scoped provider connection routes for entitled members', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$connection = ProviderConnection::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'provider' => 'microsoft',
|
|
]);
|
|
|
|
$this->actingAs($user)
|
|
->get('/admin/tenants/'.$tenant->external_id.'/provider-connections')
|
|
->assertStatus(302)
|
|
->assertRedirect('/admin/provider-connections?tenant_id='.$tenant->external_id);
|
|
|
|
$this->actingAs($user)
|
|
->get('/admin/tenants/'.$tenant->external_id.'/provider-connections/create')
|
|
->assertStatus(302)
|
|
->assertRedirect('/admin/provider-connections/create?tenant_id='.$tenant->external_id);
|
|
|
|
$this->actingAs($user)
|
|
->get('/admin/tenants/'.$tenant->external_id.'/provider-connections/'.$connection->getKey().'/edit')
|
|
->assertStatus(302)
|
|
->assertRedirect('/admin/provider-connections/'.$connection->getKey().'/edit?tenant_id='.$tenant->external_id);
|
|
});
|
|
|
|
it('returns 404 without location header for non-workspace members on legacy routes', function (): void {
|
|
$user = User::factory()->create();
|
|
$tenant = Tenant::factory()->create();
|
|
|
|
$this->actingAs($user)
|
|
->get('/admin/tenants/'.$tenant->external_id.'/provider-connections')
|
|
->assertNotFound()
|
|
->assertHeaderMissing('Location');
|
|
});
|
|
|
|
it('returns 404 without location header for non-tenant members on legacy routes', function (): void {
|
|
$tenantA = Tenant::factory()->create();
|
|
$tenantB = Tenant::factory()->create([
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
]);
|
|
|
|
[$user] = createUserWithTenant(tenant: $tenantA, role: 'owner');
|
|
|
|
$this->actingAs($user)
|
|
->get('/admin/tenants/'.$tenantB->external_id.'/provider-connections')
|
|
->assertNotFound()
|
|
->assertHeaderMissing('Location');
|
|
});
|
|
|
|
it('keeps /admin/t/{tenant}/provider-connections as not found and not redirected', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$this->actingAs($user)
|
|
->get('/admin/t/'.$tenant->external_id.'/provider-connections')
|
|
->assertNotFound()
|
|
->assertHeaderMissing('Location');
|
|
});
|