ahmido
92a36ab89e
Implements Spec 093 (SCOPE-001) workspace isolation at the data layer. What changed - Adds `workspace_id` to 12 tenant-owned tables and enforces correct binding. - Model write-path enforcement derives workspace from tenant + rejects mismatches. - Prevents `tenant_id` changes (immutability) on tenant-owned records. - Adds queued backfill command + job (`tenantpilot:backfill-workspace-ids`) with OperationRun + AuditLog observability. - Enforces DB constraints (NOT NULL + FK `workspace_id` → `workspaces.id` + composite FK `(tenant_id, workspace_id)` → `tenants(id, workspace_id)`), plus audit_logs invariant. UI / operator visibility - Monitor backfill runs in **Monitoring → Operations** (OperationRun). Tests - `vendor/bin/sail artisan test --compact tests/Feature/WorkspaceIsolation` Notes - Backfill is queued: ensure a queue worker is running (`vendor/bin/sail artisan queue:work`). Spec package - `specs/093-scope-001-workspace-id-isolation/` (plan, tasks, contracts, quickstart, research) Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #112
73 lines
2.4 KiB
PHP
73 lines
2.4 KiB
PHP
<?php
|
|
|
|
use App\Models\Policy;
|
|
use App\Models\Tenant;
|
|
use App\Models\Workspace;
|
|
use App\Support\WorkspaceIsolation\WorkspaceIsolationViolation;
|
|
|
|
it('derives workspace_id from tenant when missing on create', function (): void {
|
|
$workspace = Workspace::factory()->create();
|
|
|
|
$tenant = Tenant::factory()->create([
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
]);
|
|
|
|
$policy = Policy::query()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'external_id' => 'policy-derived-workspace',
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
'display_name' => 'Derived Workspace Policy',
|
|
'platform' => 'windows',
|
|
]);
|
|
|
|
expect((int) $policy->workspace_id)->toBe((int) $tenant->workspace_id);
|
|
});
|
|
|
|
it('rejects create when workspace_id mismatches tenant workspace', function (): void {
|
|
$workspaceA = Workspace::factory()->create();
|
|
$workspaceB = Workspace::factory()->create();
|
|
|
|
$tenant = Tenant::factory()->create([
|
|
'workspace_id' => (int) $workspaceA->getKey(),
|
|
]);
|
|
|
|
expect(fn () => Policy::query()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $workspaceB->getKey(),
|
|
'external_id' => 'policy-workspace-mismatch',
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
'display_name' => 'Workspace Mismatch Policy',
|
|
'platform' => 'windows',
|
|
]))->toThrow(WorkspaceIsolationViolation::class);
|
|
});
|
|
|
|
it('rejects tenant_id changes after create', function (): void {
|
|
$workspaceA = Workspace::factory()->create();
|
|
$workspaceB = Workspace::factory()->create();
|
|
|
|
$tenantA = Tenant::factory()->create([
|
|
'workspace_id' => (int) $workspaceA->getKey(),
|
|
]);
|
|
|
|
$tenantB = Tenant::factory()->create([
|
|
'workspace_id' => (int) $workspaceB->getKey(),
|
|
]);
|
|
|
|
$policy = Policy::query()->create([
|
|
'tenant_id' => (int) $tenantA->getKey(),
|
|
'external_id' => 'policy-tenant-immutable',
|
|
'policy_type' => 'settingsCatalogPolicy',
|
|
'display_name' => 'Tenant Immutable Policy',
|
|
'platform' => 'windows',
|
|
]);
|
|
|
|
expect(fn () => $policy->update([
|
|
'tenant_id' => (int) $tenantB->getKey(),
|
|
]))->toThrow(WorkspaceIsolationViolation::class);
|
|
|
|
$policy->refresh();
|
|
|
|
expect((int) $policy->tenant_id)->toBe((int) $tenantA->getKey());
|
|
expect((int) $policy->workspace_id)->toBe((int) $tenantA->workspace_id);
|
|
});
|