ahmido
92f39d9749
## Summary - introduce a shared reason-translation contract with envelopes, presenter helpers, fallback handling, and provider translation support - adopt translated operator-facing reason presentation across operation runs, notifications, provider guidance, tenant operability, and RBAC-related surfaces - add Spec 157 design artifacts and targeted regression coverage for translation quality, diagnostics retention, and authorization-safe guidance ## Validation - `vendor/bin/sail bin pint --dirty --format agent` - `vendor/bin/sail artisan test --compact tests/Architecture/ReasonTranslationPrimarySurfaceGuardTest.php tests/Unit/Support/ReasonTranslation/ReasonResolutionEnvelopeTest.php tests/Unit/Support/ReasonTranslation/ExecutionDenialReasonTranslationTest.php tests/Unit/Support/ReasonTranslation/TenantOperabilityReasonTranslationTest.php tests/Unit/Support/ReasonTranslation/RbacReasonTranslationTest.php tests/Unit/Support/ReasonTranslation/ProviderReasonTranslationTest.php tests/Feature/Notifications/OperationRunNotificationTest.php tests/Feature/Operations/OperationRunBlockedExecutionPresentationTest.php tests/Feature/Operations/TenantlessOperationRunViewerTest.php tests/Feature/ReasonTranslation/GovernanceReasonPresentationTest.php tests/Feature/Authorization/ReasonTranslationScopeSafetyTest.php tests/Feature/Monitoring/OperationRunBlockedSpec081Test.php tests/Feature/ProviderConnections/ProviderOperationBlockedGuidanceSpec081Test.php tests/Feature/ProviderConnections/ProviderGatewayRuntimeSmokeSpec081Test.php` ## Notes - Livewire v4.0+ compliance remains unchanged within the existing Filament v5 stack. - No new panel was added; provider registration remains in `bootstrap/providers.php`. - No new globally searchable resource was introduced. - No new destructive action family was introduced. - No new assets were added; the existing `filament:assets` deployment behavior remains unchanged. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #187
41 lines
1.7 KiB
PHP
41 lines
1.7 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Support\ReasonTranslation\FallbackReasonTranslator;
|
|
use App\Support\ReasonTranslation\NextStepOption;
|
|
use App\Support\ReasonTranslation\ReasonResolutionEnvelope;
|
|
|
|
it('renders body lines and legacy next steps from the shared envelope', function (): void {
|
|
$envelope = new ReasonResolutionEnvelope(
|
|
internalCode: 'provider_consent_missing',
|
|
operatorLabel: 'Admin consent required',
|
|
shortExplanation: 'The provider connection cannot continue until admin consent is granted.',
|
|
actionability: 'prerequisite_missing',
|
|
nextSteps: [
|
|
NextStepOption::link('Grant admin consent', 'https://example.test/admin-consent'),
|
|
],
|
|
);
|
|
|
|
expect($envelope->toBodyLines())->toBe([
|
|
'Admin consent required',
|
|
'The provider connection cannot continue until admin consent is granted.',
|
|
'Next step: Grant admin consent.',
|
|
])->and($envelope->toLegacyNextSteps())->toBe([
|
|
[
|
|
'label' => 'Grant admin consent',
|
|
'url' => 'https://example.test/admin-consent',
|
|
],
|
|
]);
|
|
});
|
|
|
|
it('builds understandable fallback translations without exposing raw codes as operator labels', function (): void {
|
|
$envelope = app(FallbackReasonTranslator::class)->translate('custom_retry_timeout');
|
|
|
|
expect($envelope)->not->toBeNull()
|
|
->and($envelope?->operatorLabel)->toBe('Custom Retry Timeout')
|
|
->and($envelope?->operatorLabel)->not->toBe('custom_retry_timeout')
|
|
->and($envelope?->shortExplanation)->toContain('transient dependency issue')
|
|
->and($envelope?->guidanceText())->toBe('Next step: Retry after the dependency recovers.');
|
|
});
|