TenantAtlas/tests/Unit/BulkPolicyExportJobTest.php
ahmido a97beefda3 056-remove-legacy-bulkops (#65)
Kurzbeschreibung

Versteckt die Rerun-Row-Action für archivierte (soft-deleted) RestoreRuns und verhindert damit fehlerhafte Neu-Starts aus dem Archiv; ergänzt einen Regressionstest.
Änderungen

Code: RestoreRunResource.php — Sichtbarkeit der rerun-Action geprüft auf ! $record->trashed() und defensive Abbruchprüfung im Action-Handler.
Tests: RestoreRunRerunTest.php — neuer Test rerun action is hidden for archived restore runs.
Warum

Archivierte RestoreRuns durften nicht neu gestartet werden; UI zeigte trotzdem die Option. Das führte zu verwirrendem Verhalten und möglichen Fehlern beim Enqueueing.
Verifikation / QA

Unit/Feature:
./vendor/bin/sail artisan test tests/Feature/RestoreRunRerunTest.php
Stil/format:
./vendor/bin/pint --dirty
Manuell (UI):
Als Tenant-Admin Filament → Restore Runs öffnen.
Filter Archived aktivieren (oder Trashed filter auswählen).
Sicherstellen, dass für archivierte Einträge die Rerun-Action nicht sichtbar ist.
Auf einem aktiven (nicht-archivierten) Run prüfen, dass Rerun sichtbar bleibt und wie erwartet eine neue RestoreRun erzeugt.
Wichtige Hinweise

Kein DB-Migration required.
Diese PR enthält nur den UI-/Filament-Fix; die zuvor gemachten operative Fixes für Queue/adapter-Reconciliation bleiben ebenfalls auf dem Branch (z. B. frühere commits während der Debugging-Session).
T055 (Schema squash) wurde bewusst zurückgestellt und ist nicht Teil dieses PRs.
Merge-Checklist

 Tests lokal laufen (RestoreRunRerunTest grünt)
 Pint läuft ohne ungepatchte Fehler
 Branch gepusht: 056-remove-legacy-bulkops (PR-URL: https://git.cloudarix.de/ahmido/TenantAtlas/compare/dev...056-remove-legacy-bulkops)

Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local>
Reviewed-on: #65
2026-01-19 23:27:52 +00:00

120 lines
4.1 KiB
PHP

<?php
use App\Jobs\BulkPolicyExportJob;
use App\Models\BackupItem;
use App\Models\BackupSet;
use App\Models\OperationRun;
use App\Models\Policy;
use App\Models\PolicyVersion;
use App\Models\Tenant;
use App\Models\User;
use App\Services\OperationRunService;
use Illuminate\Foundation\Testing\RefreshDatabase;
uses(RefreshDatabase::class);
test('job processes bulk export successfully', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create();
$policies = Policy::factory()->count(3)->create(['tenant_id' => $tenant->id]);
// Create versions for policies so they can be backed up
$policies->each(function ($policy) use ($tenant) {
PolicyVersion::create([
'tenant_id' => $tenant->id,
'policy_id' => $policy->id,
'policy_type' => $policy->policy_type,
'version_number' => 1,
'snapshot' => ['name' => $policy->display_name],
'captured_at' => now(),
]);
});
$policyIds = $policies->pluck('id')->toArray();
$run = OperationRun::factory()->create([
'tenant_id' => $tenant->getKey(),
'user_id' => $user->getKey(),
'initiator_name' => $user->name,
'type' => 'policy.export',
'status' => 'queued',
'outcome' => 'pending',
'context' => ['scope' => 'subset', 'policy_ids' => $policyIds],
'summary_counts' => [],
'failure_summary' => [],
]);
$job = new BulkPolicyExportJob(
tenantId: (int) $tenant->getKey(),
userId: (int) $user->getKey(),
policyIds: $policyIds,
backupName: 'My Bulk Backup',
operationRun: $run,
);
$job->handle(app(OperationRunService::class));
$run->refresh();
expect($run->status)->toBe('completed')
->and($run->outcome)->toBe('succeeded')
->and((int) ($run->summary_counts['processed'] ?? 0))->toBe(3)
->and((int) ($run->summary_counts['succeeded'] ?? 0))->toBe(3);
// Verify BackupSet created
$backupSet = BackupSet::where('name', 'My Bulk Backup')->first();
expect($backupSet)->not->toBeNull()
->and($backupSet->tenant_id)->toBe($tenant->id);
// Verify BackupItems created
expect(BackupItem::where('backup_set_id', $backupSet->id)->count())->toBe(3);
});
test('job handles policies without versions gracefully', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create();
$policyWithVersion = Policy::factory()->create(['tenant_id' => $tenant->id]);
PolicyVersion::create([
'tenant_id' => $tenant->id,
'policy_id' => $policyWithVersion->id,
'policy_type' => $policyWithVersion->policy_type,
'version_number' => 1,
'snapshot' => ['name' => 'ok'],
'captured_at' => now(),
]);
$policyNoVersion = Policy::factory()->create(['tenant_id' => $tenant->id]);
$policyIds = [$policyWithVersion->id, $policyNoVersion->id];
$run = OperationRun::factory()->create([
'tenant_id' => $tenant->getKey(),
'user_id' => $user->getKey(),
'initiator_name' => $user->name,
'type' => 'policy.export',
'status' => 'queued',
'outcome' => 'pending',
'context' => ['scope' => 'subset', 'policy_ids' => $policyIds],
'summary_counts' => [],
'failure_summary' => [],
]);
$job = new BulkPolicyExportJob(
tenantId: (int) $tenant->getKey(),
userId: (int) $user->getKey(),
policyIds: $policyIds,
backupName: 'Partial Backup',
operationRun: $run,
);
$job->handle(app(OperationRunService::class));
$run->refresh();
expect($run->status)->toBe('completed');
expect($run->outcome)->toBe('partially_succeeded');
expect((int) ($run->summary_counts['processed'] ?? 0))->toBe(2);
expect((int) ($run->summary_counts['succeeded'] ?? 0))->toBe(1);
expect((int) ($run->summary_counts['failed'] ?? 0))->toBe(1);
$failure = collect($run->failure_summary ?? [])->first(fn ($entry) => is_array($entry) && ($entry['code'] ?? null) === 'policy.no_versions');
expect($failure)->not->toBeNull();
});