ahmido
e0c2cdb1f4
## Summary - enforce the canonical workspace/environment scope contract for workspace hubs and environment-owned surfaces - replace first-party Operations deep links that leaked Filament `tableFilters[...]` internals with stable product-level query behavior - add the sidebar scope indicator and split environment-page navigation into explicit `Workspace-wide` and `Workspace admin` groups - remove redundant tenantless `All environments` scope badges from workspace-wide pages while preserving explicit environment filter affordances - include the Spec 338 artifacts, guard tests, and browser smoke coverage for the new contract ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Navigation/Spec338EnvironmentSidebarSeparationTest.php tests/Feature/Navigation/Spec338OperationRunLinksQueryContractTest.php tests/Feature/Navigation/Spec338SidebarScopeIndicatorTest.php tests/Feature/Filament/PanelNavigationSegregationTest.php` - `cd apps/platform && ./vendor/bin/sail php vendor/bin/pest tests/Browser/Spec338ScopeContractSmokeTest.php --compact` ## Notes - Livewire v4 compliance unchanged - Filament provider registration remains in `bootstrap/providers.php` - no destructive action behavior changed - no migrations, env var changes, or new Filament asset registration Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #409
64 lines
2.4 KiB
PHP
64 lines
2.4 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Models\User;
|
|
use App\Models\Workspace;
|
|
use App\Models\WorkspaceMembership;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
|
|
it('renders environment-first chooser terminology in english', function (): void {
|
|
$environment = ManagedEnvironment::factory()->active()->create(['name' => 'Chooser Environment']);
|
|
[$user, $environment] = createUserWithTenant(tenant: $environment, role: 'owner');
|
|
|
|
app()->setLocale('en');
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $environment->workspace_id])
|
|
->get('/admin/choose-environment')
|
|
->assertSuccessful()
|
|
->assertSee('Choose environment')
|
|
->assertSee('Select the environment for your normal active operating context.')
|
|
->assertSee('No environment selected is still a valid workspace state')
|
|
->assertDontSee('Choose tenant')
|
|
->assertDontSee('Select the tenant for your normal active operating context.')
|
|
->assertDontSee('No tenant selected is still a valid workspace state');
|
|
});
|
|
|
|
it('renders environment-first managed-environments landing terminology in english', function (): void {
|
|
$workspace = Workspace::factory()->create(['slug' => 'landing-environment-copy']);
|
|
$user = User::factory()->create();
|
|
|
|
WorkspaceMembership::factory()->create([
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
'user_id' => (int) $user->getKey(),
|
|
'role' => 'owner',
|
|
]);
|
|
|
|
$environment = ManagedEnvironment::factory()->active()->create([
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
'name' => 'Landing Environment',
|
|
]);
|
|
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$environment->getKey() => ['role' => 'owner'],
|
|
]);
|
|
|
|
app()->setLocale('en');
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $workspace->getKey()])
|
|
->get(route('admin.workspace.managed-environments.index', ['workspace' => $workspace]))
|
|
->assertSuccessful()
|
|
->assertSee('Managed environments')
|
|
->assertDontSee('Choose environment')
|
|
->assertSee('Add environment')
|
|
->assertDontSee('Managed tenants')
|
|
->assertDontSee('Choose tenant')
|
|
->assertDontSee('Add tenant');
|
|
});
|