ahmido
e0c2cdb1f4
## Summary - enforce the canonical workspace/environment scope contract for workspace hubs and environment-owned surfaces - replace first-party Operations deep links that leaked Filament `tableFilters[...]` internals with stable product-level query behavior - add the sidebar scope indicator and split environment-page navigation into explicit `Workspace-wide` and `Workspace admin` groups - remove redundant tenantless `All environments` scope badges from workspace-wide pages while preserving explicit environment filter affordances - include the Spec 338 artifacts, guard tests, and browser smoke coverage for the new contract ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Navigation/Spec338EnvironmentSidebarSeparationTest.php tests/Feature/Navigation/Spec338OperationRunLinksQueryContractTest.php tests/Feature/Navigation/Spec338SidebarScopeIndicatorTest.php tests/Feature/Filament/PanelNavigationSegregationTest.php` - `cd apps/platform && ./vendor/bin/sail php vendor/bin/pest tests/Browser/Spec338ScopeContractSmokeTest.php --compact` ## Notes - Livewire v4 compliance unchanged - Filament provider registration remains in `bootstrap/providers.php` - no destructive action behavior changed - no migrations, env var changes, or new Filament asset registration Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #409
51 lines
2.3 KiB
PHP
51 lines
2.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Pages\EnvironmentDashboard;
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('shows an explicit workspace scope indicator in the sidebar on workspace-owned pages', function (): void {
|
|
$environment = ManagedEnvironment::factory()->active()->create(['name' => 'Spec338 Sidebar Workspace Environment']);
|
|
[$user, $environment] = createUserWithTenant(tenant: $environment, role: 'owner', workspaceRole: 'owner');
|
|
|
|
$workspace = $environment->workspace()->firstOrFail();
|
|
|
|
ManagedEnvironment::factory()->active()->create([
|
|
'name' => 'Spec338 Sidebar Inaccessible Environment',
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
]);
|
|
|
|
$accessibleEnvironmentCount = 1;
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $workspace->getKey()])
|
|
->get(route('admin.workspace.home', ['workspace' => $workspace]))
|
|
->assertOk()
|
|
->assertSee('data-testid="admin-sidebar-scope-indicator"', false)
|
|
->assertSee(__('localization.shell.workspace_scope_short'))
|
|
->assertSee($workspace->name)
|
|
->assertSee(trans_choice('localization.shell.environment_count', $accessibleEnvironmentCount, ['count' => $accessibleEnvironmentCount]))
|
|
->assertDontSee(trans_choice('localization.shell.environment_count', 2, ['count' => 2]));
|
|
});
|
|
|
|
it('shows an explicit environment scope indicator in the sidebar on environment-owned pages', function (): void {
|
|
$environment = ManagedEnvironment::factory()->active()->create(['name' => 'Spec338 Sidebar Environment']);
|
|
[$user, $environment] = createUserWithTenant(tenant: $environment, role: 'owner', workspaceRole: 'owner');
|
|
|
|
$workspace = $environment->workspace()->firstOrFail();
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $workspace->getKey()])
|
|
->get(EnvironmentDashboard::getUrl(panel: 'admin', tenant: $environment))
|
|
->assertOk()
|
|
->assertSee('data-testid="admin-sidebar-scope-indicator"', false)
|
|
->assertSee(__('localization.shell.environment_scope_short'))
|
|
->assertSee($environment->name)
|
|
->assertSee(__('localization.shell.workspace_context_label', ['workspace' => $workspace->name]));
|
|
});
|