ahmido
bab01f07a9
## Summary - standardize Microsoft provider connections around explicit platform vs dedicated identity modes - centralize admin-consent URL and runtime identity resolution so platform flows no longer fall back to tenant-local credentials - add migration classification, richer consent and verification state handling, dedicated override management, and focused regression coverage ## Validation - focused repo test coverage was added across provider identity, onboarding, audit, policy, guard, and migration flows - latest explicit passing run in the workspace: `vendor/bin/sail artisan test --compact tests/Feature/AdminConsentCallbackTest.php tests/Feature/Audit/ProviderConnectionConsentAuditTest.php` ## Notes - branch includes the full Spec 137 artifact set under `specs/137-platform-provider-identity/` - target base branch: `dev` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #166
92 lines
2.8 KiB
PHP
92 lines
2.8 KiB
PHP
<?php
|
|
|
|
use App\Models\ProviderConnection;
|
|
use App\Models\ProviderCredential;
|
|
use App\Services\Providers\CredentialManager;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('returns client credentials from encrypted payload', function (): void {
|
|
$connection = ProviderConnection::factory()->dedicated()->create([
|
|
'entra_tenant_id' => fake()->uuid(),
|
|
]);
|
|
|
|
ProviderCredential::factory()->create([
|
|
'provider_connection_id' => $connection->getKey(),
|
|
'payload' => [
|
|
'client_id' => 'client-id',
|
|
'client_secret' => 'client-secret',
|
|
],
|
|
]);
|
|
|
|
$manager = app(CredentialManager::class);
|
|
|
|
expect($manager->getClientCredentials($connection))
|
|
->toBe([
|
|
'client_id' => 'client-id',
|
|
'client_secret' => 'client-secret',
|
|
]);
|
|
});
|
|
|
|
it('rejects credential payload that does not match the connection scope', function (): void {
|
|
$connection = ProviderConnection::factory()->dedicated()->create([
|
|
'entra_tenant_id' => 'tenant-a',
|
|
]);
|
|
|
|
ProviderCredential::factory()->create([
|
|
'provider_connection_id' => $connection->getKey(),
|
|
'payload' => [
|
|
'tenant_id' => 'tenant-b',
|
|
'client_id' => 'client-id',
|
|
'client_secret' => 'client-secret',
|
|
],
|
|
]);
|
|
|
|
$manager = app(CredentialManager::class);
|
|
|
|
$manager->getClientCredentials($connection);
|
|
})->throws(InvalidArgumentException::class);
|
|
|
|
it('rejects resolving dedicated credentials for platform connections', function (): void {
|
|
$connection = ProviderConnection::factory()->platform()->create([
|
|
'entra_tenant_id' => 'tenant-a',
|
|
]);
|
|
|
|
ProviderCredential::factory()->create([
|
|
'provider_connection_id' => $connection->getKey(),
|
|
'payload' => [
|
|
'client_id' => 'client-id',
|
|
'client_secret' => 'client-secret',
|
|
],
|
|
]);
|
|
|
|
$manager = app(CredentialManager::class);
|
|
|
|
$manager->getClientCredentials($connection);
|
|
})->throws(InvalidArgumentException::class);
|
|
|
|
it('upserts client secret credentials and never serializes the payload', function (): void {
|
|
$connection = ProviderConnection::factory()->dedicated()->create();
|
|
|
|
$manager = app(CredentialManager::class);
|
|
|
|
$credential = $manager->upsertClientSecretCredential(
|
|
connection: $connection,
|
|
clientId: 'client-id',
|
|
clientSecret: 'client-secret',
|
|
);
|
|
|
|
expect($credential->type)->toBe('client_secret');
|
|
expect($credential->payload)->toBe([
|
|
'client_id' => 'client-id',
|
|
'client_secret' => 'client-secret',
|
|
]);
|
|
|
|
expect($credential->toArray())->not->toHaveKey('payload');
|
|
|
|
expect((string) $credential->getRawOriginal('payload'))
|
|
->not->toContain('client-secret')
|
|
->not->toContain('client_id');
|
|
});
|