ahmido
6a15fe978a
## Summary Automated scanning of Entra ID directory roles to surface high-privilege role assignments as trackable findings with alerting support. ## What's included ### Core Services - **EntraAdminRolesReportService** — Fetches role definitions + assignments via Graph API, builds payload with fingerprint deduplication - **EntraAdminRolesFindingGenerator** — Creates/resolves/reopens findings based on high-privilege role catalog - **HighPrivilegeRoleCatalog** — Curated list of high-privilege Entra roles (Global Admin, Privileged Auth Admin, etc.) - **ScanEntraAdminRolesJob** — Queued job orchestrating scan → report → findings → alerts pipeline ### UI - **AdminRolesSummaryWidget** — Tenant dashboard card showing last scan time, high-privilege assignment count, scan trigger button - RBAC-gated: `ENTRA_ROLES_VIEW` for viewing, `ENTRA_ROLES_MANAGE` for scan trigger ### Infrastructure - Graph contracts for `entraRoleDefinitions` + `entraRoleAssignments` - `config/entra_permissions.php` — Entra permission registry - `StoredReport.fingerprint` migration (deduplication support) - `OperationCatalog` label + duration for `entra.admin_roles.scan` - Artisan command `entra:scan-admin-roles` for CLI/scheduled use ### Global UX improvement - **SummaryCountsNormalizer**: Zero values filtered, snake_case keys humanized (e.g. `report_deduped: 1` → `Report deduped: 1`). Affects all operation notifications. ## Test Coverage - **12 test files**, **79+ tests**, **307+ assertions** - Report service, finding generator, job orchestration, widget rendering, alert integration, RBAC enforcement, badge mapping ## Spec artifacts - `specs/105-entra-admin-roles-evidence-findings/tasks.md` — Full task breakdown (38 tasks, all complete) - `specs/105-entra-admin-roles-evidence-findings/checklists/requirements.md` — All items checked ## Files changed 46 files changed, 3641 insertions(+), 15 deletions(-) Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #128
65 lines
1.6 KiB
PHP
65 lines
1.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Support\OpsUx\SummaryCountsNormalizer;
|
|
|
|
it('normalizes allowed keys and casts to int', function () {
|
|
$result = SummaryCountsNormalizer::normalize([
|
|
'total' => 5,
|
|
'processed' => '3',
|
|
'failed' => 0,
|
|
'bogus_key' => 99,
|
|
]);
|
|
|
|
expect($result)->toBe([
|
|
'total' => 5,
|
|
'processed' => 3,
|
|
'failed' => 0,
|
|
]);
|
|
});
|
|
|
|
it('strips empty string keys and non-numeric values', function () {
|
|
$result = SummaryCountsNormalizer::normalize([
|
|
'' => 1,
|
|
'total' => 'not-a-number',
|
|
'succeeded' => 10,
|
|
]);
|
|
|
|
expect($result)->toBe(['succeeded' => 10]);
|
|
});
|
|
|
|
it('renders summary line with only non-zero values', function () {
|
|
$line = SummaryCountsNormalizer::renderSummaryLine([
|
|
'report_created' => 0,
|
|
'report_deduped' => 1,
|
|
'findings_created' => 0,
|
|
'findings_unchanged' => 10,
|
|
'alert_events_produced' => 0,
|
|
]);
|
|
|
|
expect($line)->toBe('Report deduped: 1 · Findings unchanged: 10');
|
|
});
|
|
|
|
it('returns null when all values are zero', function () {
|
|
$line = SummaryCountsNormalizer::renderSummaryLine([
|
|
'report_created' => 0,
|
|
'findings_created' => 0,
|
|
]);
|
|
|
|
expect($line)->toBeNull();
|
|
});
|
|
|
|
it('returns null for empty array', function () {
|
|
expect(SummaryCountsNormalizer::renderSummaryLine([]))->toBeNull();
|
|
});
|
|
|
|
it('humanizes snake_case keys to Title case', function () {
|
|
$line = SummaryCountsNormalizer::renderSummaryLine([
|
|
'high' => 3,
|
|
'alert_events_produced' => 2,
|
|
]);
|
|
|
|
expect($line)->toBe('High: 3 · Alert events produced: 2');
|
|
});
|