ahmido
a4f5c4f122
## Summary - standardize Filament table defaults across resources, relation managers, widgets, custom pages, and picker tables - add shared pagination profiles, calm default column visibility, explicit empty states, and session persistence on designated critical resource lists - complete Spec 125 artifacts, regression tests, and dashboard widget follow-up for lazy loading, sortable columns, and toggleable detail columns ## Verification - `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=BaselineCompareNow` - `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=TableStandardsBaseline` - `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=TableDetailVisibility` - `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=FilamentTableRiskExceptions` - full suite run completed: `2017 passed, 10 failed, 8 skipped` - manual browser QA completed on the tenant dashboard for lazy loading, sortable widget columns, toggleable hidden status columns, badges, and pagination ## Known Failures The full suite still has 10 pre-existing failures unrelated to this branch: - `Tests\\Unit\\OpsUx\\SummaryCountsNormalizerTest` - `Tests\\Feature\\BackupWithAssignmentsConsistencyTest` (2 tests) - `Tests\\Feature\\BaselineDriftEngine\\CaptureBaselineContentTest` - `Tests\\Feature\\BaselineDriftEngine\\CompareContentEvidenceTest` - `Tests\\Feature\\BaselineDriftEngine\\ResolverTest` - `Tests\\Feature\\Filament\\TenantDashboardDbOnlyTest` - `Tests\\Feature\\Operations\\ReconcileAdapterRunsJobTrackingTest` - `Tests\\Feature\\ReviewPack\\ReviewPackRbacTest` - `Tests\\Feature\\Verification\\VerificationReportRedactionTest` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #152
108 lines
3.9 KiB
PHP
108 lines
3.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\Tenant;
|
|
use App\Models\TenantMembership;
|
|
use App\Models\User;
|
|
use App\Models\Workspace;
|
|
use App\Models\WorkspaceMembership;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Livewire\Livewire;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('does not show tenants from other workspaces on the tenants index', function (): void {
|
|
$user = User::factory()->create();
|
|
|
|
$workspaceA = Workspace::factory()->create(['name' => 'Workspace A']);
|
|
$workspaceB = Workspace::factory()->create(['name' => 'Workspace B']);
|
|
|
|
WorkspaceMembership::factory()->create([
|
|
'workspace_id' => $workspaceA->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'role' => 'owner',
|
|
]);
|
|
|
|
WorkspaceMembership::factory()->create([
|
|
'workspace_id' => $workspaceB->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'role' => 'owner',
|
|
]);
|
|
|
|
$tenantA = Tenant::factory()->create([
|
|
'workspace_id' => $workspaceA->getKey(),
|
|
'external_id' => '11111111-1111-1111-1111-111111111111',
|
|
'tenant_id' => '11111111-1111-1111-1111-111111111111',
|
|
'name' => 'Tenant A',
|
|
'status' => 'active',
|
|
]);
|
|
|
|
$tenantB = Tenant::factory()->create([
|
|
'workspace_id' => $workspaceB->getKey(),
|
|
'external_id' => '22222222-2222-2222-2222-222222222222',
|
|
'tenant_id' => '22222222-2222-2222-2222-222222222222',
|
|
'name' => 'Tenant B',
|
|
'status' => 'active',
|
|
]);
|
|
|
|
TenantMembership::query()->create([
|
|
'tenant_id' => $tenantA->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'role' => 'owner',
|
|
'source' => 'manual',
|
|
'source_ref' => null,
|
|
'created_by_user_id' => null,
|
|
]);
|
|
|
|
TenantMembership::query()->create([
|
|
'tenant_id' => $tenantB->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'role' => 'owner',
|
|
'source' => 'manual',
|
|
'source_ref' => null,
|
|
'created_by_user_id' => null,
|
|
]);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $workspaceA->getKey()])
|
|
->get(route('filament.admin.resources.tenants.index', filamentTenantRouteParams($tenantA)))
|
|
->assertOk()
|
|
->assertSee('Tenant A')
|
|
->assertDontSee('Tenant B');
|
|
});
|
|
|
|
it('keeps tenant list defaults calm and persists list state in-session', function (): void {
|
|
[$user] = createUserWithTenant(role: 'owner');
|
|
|
|
$this->actingAs($user);
|
|
Filament::setTenant(null, true);
|
|
|
|
$component = Livewire::actingAs($user)
|
|
->test(\App\Filament\Resources\TenantResource\Pages\ListTenants::class)
|
|
->assertTableEmptyStateActionsExistInOrder(['add_tenant'])
|
|
->searchTable('Tenant')
|
|
->call('sortTable', 'name', 'desc')
|
|
->set('tableFilters.environment.value', 'prod');
|
|
|
|
$table = $component->instance()->getTable();
|
|
|
|
expect($table->getPaginationPageOptions())->toBe(\App\Support\Filament\TablePaginationProfiles::resource());
|
|
expect($table->getEmptyStateHeading())->toBe('No tenants connected');
|
|
expect($table->getColumn('name')?->isSearchable())->toBeTrue();
|
|
expect($table->getColumn('name')?->isSortable())->toBeTrue();
|
|
expect($table->getColumn('tenant_id')?->isToggledHiddenByDefault())->toBeTrue();
|
|
expect($table->getColumn('domain')?->isToggledHiddenByDefault())->toBeTrue();
|
|
expect(count($table->getVisibleColumns()))->toBeLessThanOrEqual(7);
|
|
expect(session()->get($component->instance()->getTableSearchSessionKey()))->toBe('Tenant');
|
|
expect(session()->get($component->instance()->getTableSortSessionKey()))->toBe('name:desc');
|
|
|
|
Livewire::actingAs($user)
|
|
->test(\App\Filament\Resources\TenantResource\Pages\ListTenants::class)
|
|
->assertSet('tableSearch', 'Tenant')
|
|
->assertSet('tableSort', 'name:desc')
|
|
->assertSet('tableFilters.environment.value', 'prod');
|
|
});
|