## Summary - implement Spec 209 heavy-governance cost recovery end to end - add the heavy-governance contract, hotspot inventory, decomposition, snapshots, budget outcome, and author-guidance surfaces in the shared lane support seams - slim the baseline and findings hotspot families, harden wrapper behavior, and refresh the spec, quickstart, and contract artifacts ## Validation - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Guards/TestLaneCommandContractTest.php tests/Feature/Guards/ActionSurfaceContractTest.php tests/Feature/Guards/OperationLifecycleOpsUxGuardTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Filament/BaselineProfileCaptureStartSurfaceTest.php tests/Feature/Filament/BaselineProfileCompareStartSurfaceTest.php tests/Feature/Filament/BaselineActionAuthorizationTest.php tests/Feature/Findings/FindingsListFiltersTest.php tests/Feature/Findings/FindingExceptionRenewalTest.php tests/Feature/Findings/FindingWorkflowRowActionsTest.php tests/Feature/Findings/FindingWorkflowViewActionsTest.php tests/Feature/Guards/ActionSurfaceContractTest.php tests/Feature/Guards/OperationLifecycleOpsUxGuardTest.php` - `./scripts/platform-sail artisan test --compact` ## Outcome - heavy-governance latest artifacts now agree on an authoritative `330s` threshold with `recalibrated` outcome after the honest rerun - full suite result: `3760 passed`, `8 skipped`, `23535 assertions` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #242
96 lines
6.3 KiB
PHP
96 lines
6.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use Illuminate\Support\Collection;
|
|
use Tests\Support\TestLaneManifest;
|
|
|
|
it('routes escalated workflow, discovery-heavy, and broad surface-guard families into heavy-governance', function (): void {
|
|
$lane = TestLaneManifest::lane('heavy-governance');
|
|
$files = new Collection(TestLaneManifest::discoverFiles('heavy-governance'));
|
|
|
|
expect($lane['includedFamilies'])->toContain('ui-workflow', 'surface-guard', 'discovery-heavy')
|
|
->and($files)->toContain(
|
|
'tests/Architecture/PlatformVocabularyBoundaryGuardTest.php',
|
|
'tests/Architecture/ReasonTranslationPrimarySurfaceGuardTest.php',
|
|
'tests/Deprecation/IsPlatformSuperadminDeprecationTest.php',
|
|
'tests/Feature/Drift/DriftBulkAcknowledgeAllMatchingConfirmationTest.php',
|
|
'tests/Feature/Filament/BaselineActionAuthorizationTest.php',
|
|
'tests/Feature/Filament/BaselineProfileCaptureStartSurfaceTest.php',
|
|
'tests/Feature/Filament/BaselineProfileCompareStartSurfaceTest.php',
|
|
'tests/Feature/Findings/FindingBulkActionsTest.php',
|
|
'tests/Feature/Findings/FindingExceptionRenewalTest.php',
|
|
'tests/Feature/Findings/FindingsListFiltersTest.php',
|
|
'tests/Feature/Findings/FindingWorkflowRowActionsTest.php',
|
|
'tests/Feature/Findings/FindingWorkflowViewActionsTest.php',
|
|
'tests/Feature/Filament/WorkspaceOnlySurfaceTenantIndependenceTest.php',
|
|
'tests/Feature/Guards/ActionSurfaceContractTest.php',
|
|
'tests/Feature/Filament/PolicyResourceAdminSearchParityTest.php',
|
|
'tests/Feature/Filament/PolicyVersionAdminSearchParityTest.php',
|
|
'tests/Feature/Rbac/BackupItemsRelationManagerUiEnforcementTest.php',
|
|
'tests/Feature/Rbac/WorkspaceMembershipsRelationManagerUiEnforcementTest.php',
|
|
'tests/Feature/SettingsFoundation/WorkspaceSettingsManageTest.php',
|
|
'tests/Feature/Filament/TenantReviewHeaderDisciplineTest.php',
|
|
'tests/Feature/Filament/PanelNavigationSegregationTest.php',
|
|
);
|
|
});
|
|
|
|
it('keeps the heavy-governance command config-driven and free of retained confidence workflows', function (): void {
|
|
$command = TestLaneManifest::buildCommand('heavy-governance');
|
|
$files = TestLaneManifest::discoverFiles('heavy-governance');
|
|
$configurationPath = TestLaneManifest::laneConfigurationPath('heavy-governance');
|
|
$configurationContents = (string) file_get_contents(TestLaneManifest::absolutePath($configurationPath));
|
|
|
|
expect(TestLaneManifest::commandRef('heavy-governance'))->toBe('test:heavy')
|
|
->and($command)->toContain('--configuration='.$configurationPath)
|
|
->and($command)->toContain('--testsuite=Lane')
|
|
->and($configurationContents)->toContain('tests/Feature/Drift/DriftBulkAcknowledgeAllMatchingConfirmationTest.php')
|
|
->and($configurationContents)->toContain('tests/Feature/Filament/BaselineActionAuthorizationTest.php')
|
|
->and($configurationContents)->toContain('tests/Feature/Filament/BaselineProfileCaptureStartSurfaceTest.php')
|
|
->and($configurationContents)->toContain('tests/Feature/Filament/BaselineProfileCompareStartSurfaceTest.php')
|
|
->and($configurationContents)->toContain('tests/Feature/Findings/FindingBulkActionsTest.php')
|
|
->and($configurationContents)->toContain('tests/Feature/Findings/FindingExceptionRenewalTest.php')
|
|
->and($configurationContents)->toContain('tests/Feature/Findings/FindingsListFiltersTest.php')
|
|
->and($configurationContents)->toContain('tests/Feature/Findings/FindingWorkflowRowActionsTest.php')
|
|
->and($configurationContents)->toContain('tests/Feature/Findings/FindingWorkflowViewActionsTest.php')
|
|
->and($configurationContents)->toContain('tests/Feature/Filament/WorkspaceOnlySurfaceTenantIndependenceTest.php')
|
|
->and($configurationContents)->toContain('tests/Feature/SettingsFoundation/WorkspaceSettingsManageTest.php')
|
|
->and($configurationContents)->toContain('tests/Feature/Guards/ActionSurfaceContractTest.php')
|
|
->and($configurationContents)->toContain('tests/Feature/Filament/PolicyResourceAdminSearchParityTest.php')
|
|
->and($files)->not->toContain(
|
|
'tests/Feature/Baselines/BaselineCompareMatrixCompareAllActionTest.php',
|
|
'tests/Feature/Baselines/BaselineCompareMatrixBuilderTest.php',
|
|
'tests/Feature/Rbac/OnboardingWizardUiEnforcementTest.php',
|
|
'tests/Feature/Filament/BackupSetAdminTenantParityTest.php',
|
|
);
|
|
});
|
|
|
|
it('keeps heavy-governance hotspot ownership honest across slimmed, retained, and follow-up families', function (): void {
|
|
$inventory = collect(TestLaneManifest::heavyGovernanceHotspotInventory())->keyBy('familyId');
|
|
$decomposition = collect(TestLaneManifest::heavyGovernanceDecompositionRecords())->keyBy('familyId');
|
|
$decisions = collect(TestLaneManifest::heavyGovernanceSlimmingDecisions())->keyBy('familyId');
|
|
$outcome = TestLaneManifest::heavyGovernanceBudgetOutcome();
|
|
|
|
expect($inventory->keys()->all())->toEqual([
|
|
'baseline-profile-start-surfaces',
|
|
'action-surface-contract',
|
|
'ops-ux-governance',
|
|
'findings-workflow-surfaces',
|
|
'finding-bulk-actions-workflow',
|
|
'workspace-settings-slice-management',
|
|
])
|
|
->and($inventory->get('baseline-profile-start-surfaces')['status'])->toBe('slimmed')
|
|
->and($inventory->get('findings-workflow-surfaces')['status'])->toBe('slimmed')
|
|
->and($inventory->get('finding-bulk-actions-workflow')['status'])->toBe('slimmed')
|
|
->and($inventory->get('action-surface-contract')['status'])->toBe('retained')
|
|
->and($inventory->get('ops-ux-governance')['status'])->toBe('retained')
|
|
->and($inventory->get('workspace-settings-slice-management')['status'])->toBe('follow-up')
|
|
->and($decomposition->get('finding-bulk-actions-workflow')['recommendedAction'])->toBe('narrow-assertions')
|
|
->and($decisions->get('finding-bulk-actions-workflow')['decisionType'])->toBe('trim-duplicate-work')
|
|
->and($decisions->get('workspace-settings-slice-management')['decisionType'])->toBe('follow-up')
|
|
->and($outcome['remainingOpenFamilies'])->toEqualCanonicalizing([
|
|
'action-surface-contract',
|
|
'ops-ux-governance',
|
|
'workspace-settings-slice-management',
|
|
]);
|
|
}); |