ahmido
a30be84084
Summary: - Baseline Compare landing: enterprise UI (stats grid, critical drift banner, better actions), navigation grouping under Governance, and Action Surface Contract declaration. - Baseline Profile view page: switches from disabled form fields to proper Infolist entries for a clean read-only view. - Fixes tenant name column usages (`display_name` → `name`) in baseline assignment flows. - Dashboard: improved baseline governance widget with severity breakdown + last compared. Notes: - Filament v5 / Livewire v4 compatible. - Destructive actions remain confirmed (`->requiresConfirmation()`). Tests: - `vendor/bin/sail artisan test --compact tests/Feature/Baselines` - `vendor/bin/sail artisan test --compact tests/Feature/Guards/ActionSurfaceContractTest.php` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #123
127 lines
4.7 KiB
PHP
127 lines
4.7 KiB
PHP
<?php
|
|
|
|
use App\Models\BaselineProfile;
|
|
use App\Models\BaselineTenantAssignment;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use App\Services\Audit\WorkspaceAuditLogger;
|
|
|
|
// --- T039: Assignment CRUD tests (RBAC + uniqueness) ---
|
|
|
|
it('creates a tenant assignment with workspace context', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$profile = BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => $tenant->workspace_id,
|
|
'scope_jsonb' => ['policy_types' => ['deviceConfiguration']],
|
|
]);
|
|
|
|
$assignment = BaselineTenantAssignment::create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'baseline_profile_id' => (int) $profile->getKey(),
|
|
'assigned_by_user_id' => (int) $user->getKey(),
|
|
]);
|
|
|
|
expect($assignment)->toBeInstanceOf(BaselineTenantAssignment::class);
|
|
expect($assignment->workspace_id)->toBe((int) $tenant->workspace_id);
|
|
expect($assignment->tenant_id)->toBe((int) $tenant->getKey());
|
|
expect($assignment->baseline_profile_id)->toBe((int) $profile->getKey());
|
|
expect($assignment->assigned_by_user_id)->toBe((int) $user->getKey());
|
|
});
|
|
|
|
it('prevents duplicate assignments for the same workspace+tenant', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$profile1 = BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => $tenant->workspace_id,
|
|
]);
|
|
$profile2 = BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => $tenant->workspace_id,
|
|
]);
|
|
|
|
BaselineTenantAssignment::create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'baseline_profile_id' => (int) $profile1->getKey(),
|
|
'assigned_by_user_id' => (int) $user->getKey(),
|
|
]);
|
|
|
|
// Attempting to assign the same tenant in the same workspace should fail
|
|
// due to the unique constraint on (workspace_id, tenant_id)
|
|
expect(fn () => BaselineTenantAssignment::create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'baseline_profile_id' => (int) $profile2->getKey(),
|
|
'assigned_by_user_id' => (int) $user->getKey(),
|
|
]))->toThrow(\Illuminate\Database\QueryException::class);
|
|
});
|
|
|
|
it('allows the same tenant to be assigned in different workspaces', function () {
|
|
[$user1, $tenant1] = createUserWithTenant(role: 'owner');
|
|
[$user2, $tenant2] = createUserWithTenant(role: 'owner');
|
|
|
|
$profile1 = BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => $tenant1->workspace_id,
|
|
]);
|
|
$profile2 = BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => $tenant2->workspace_id,
|
|
]);
|
|
|
|
$a1 = BaselineTenantAssignment::create([
|
|
'workspace_id' => (int) $tenant1->workspace_id,
|
|
'tenant_id' => (int) $tenant1->getKey(),
|
|
'baseline_profile_id' => (int) $profile1->getKey(),
|
|
]);
|
|
$a2 = BaselineTenantAssignment::create([
|
|
'workspace_id' => (int) $tenant2->workspace_id,
|
|
'tenant_id' => (int) $tenant2->getKey(),
|
|
'baseline_profile_id' => (int) $profile2->getKey(),
|
|
]);
|
|
|
|
expect($a1->exists)->toBeTrue();
|
|
expect($a2->exists)->toBeTrue();
|
|
});
|
|
|
|
it('deletes an assignment without deleting related models', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$profile = BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => $tenant->workspace_id,
|
|
]);
|
|
|
|
$assignment = BaselineTenantAssignment::create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'baseline_profile_id' => (int) $profile->getKey(),
|
|
'assigned_by_user_id' => (int) $user->getKey(),
|
|
]);
|
|
|
|
$assignmentId = $assignment->getKey();
|
|
$assignment->delete();
|
|
|
|
expect(BaselineTenantAssignment::query()->find($assignmentId))->toBeNull();
|
|
expect(BaselineProfile::query()->find($profile->getKey()))->not->toBeNull();
|
|
expect(Tenant::query()->find($tenant->getKey()))->not->toBeNull();
|
|
});
|
|
|
|
it('loads the baseline profile relationship from assignment', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$profile = BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => $tenant->workspace_id,
|
|
'name' => 'Test Profile',
|
|
]);
|
|
|
|
$assignment = BaselineTenantAssignment::create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'baseline_profile_id' => (int) $profile->getKey(),
|
|
]);
|
|
|
|
$loaded = $assignment->baselineProfile;
|
|
|
|
expect($loaded)->not->toBeNull();
|
|
expect($loaded->name)->toBe('Test Profile');
|
|
});
|