## Summary - harden the canonical operation run viewer so mismatched, missing, archived, onboarding, and selector-excluded tenant context no longer invalidates authorized canonical run viewing - extend canonical route, header-context, deep-link, and presentation coverage for Spec 144 and add the full spec artifact set under `specs/144-canonical-operation-viewer-context-decoupling/` - harden onboarding draft provider-connection resume logic so stale persisted provider connections fall back to the connect-provider step instead of resuming invalid state - add architecture-audit follow-up candidate material and prompt assets for the next governance hardening wave ## Testing - `vendor/bin/sail bin pint --dirty --format agent` - `vendor/bin/sail artisan test --compact tests/Feature/144/CanonicalOperationViewerContextMismatchTest.php tests/Feature/144/CanonicalOperationViewerDeepLinkTrustTest.php tests/Feature/Operations/TenantlessOperationRunViewerTest.php tests/Feature/OpsUx/OperateHubShellTest.php tests/Feature/Monitoring/OperationsTenantScopeTest.php tests/Feature/RunAuthorizationTenantIsolationTest.php tests/Feature/Filament/OperationRunEnterpriseDetailPageTest.php tests/Feature/Monitoring/HeaderContextBarTest.php tests/Feature/Monitoring/OperationRunResolvedReferencePresentationTest.php tests/Feature/Monitoring/OperationsCanonicalUrlsTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/ManagedTenantOnboardingWizardTest.php tests/Unit/Onboarding/OnboardingDraftStageResolverTest.php tests/Unit/Onboarding/OnboardingLifecycleServiceTest.php` ## Notes - branch: `144-canonical-operation-viewer-context-decoupling` - base: `dev` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #173
64 lines
2.1 KiB
PHP
64 lines
2.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\BackupSet;
|
|
use App\Models\OperationRun;
|
|
use App\Models\Tenant;
|
|
use App\Support\OperationRunLinks;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
|
|
it('renders operation run related context with backup set details', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$backupSet = BackupSet::factory()->for($tenant)->create([
|
|
'name' => 'Nightly backup',
|
|
]);
|
|
|
|
$run = OperationRun::factory()->for($tenant)->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'type' => 'backup_set.add_policies',
|
|
'context' => [
|
|
'backup_set_id' => (int) $backupSet->getKey(),
|
|
],
|
|
]);
|
|
|
|
$this->get(OperationRunLinks::tenantlessView($run))
|
|
->assertOk()
|
|
->assertSee('Nightly backup')
|
|
->assertSee('Backup set #'.$backupSet->getKey());
|
|
});
|
|
|
|
it('keeps archived run references viewable with lifecycle-aware framing', function (): void {
|
|
$activeTenant = Tenant::factory()->create([
|
|
'name' => 'Active Tenant',
|
|
]);
|
|
[$user, $activeTenant] = createUserWithTenant(tenant: $activeTenant, role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$archivedTenant = Tenant::factory()->create([
|
|
'name' => 'Archived Tenant',
|
|
'workspace_id' => (int) $activeTenant->workspace_id,
|
|
]);
|
|
|
|
createUserWithTenant(tenant: $archivedTenant, user: $user, role: 'owner');
|
|
$archivedTenant->delete();
|
|
|
|
$run = OperationRun::factory()->for($archivedTenant)->create([
|
|
'workspace_id' => (int) $activeTenant->workspace_id,
|
|
'type' => 'policy.sync',
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->withSession([WorkspaceContext::SESSION_KEY => (int) $activeTenant->workspace_id])
|
|
->get(OperationRunLinks::tenantlessView($run))
|
|
->assertOk()
|
|
->assertSee('Run tenant is not available in the current tenant selector')
|
|
->assertSee('This tenant is currently archived')
|
|
->assertSee('Back to Operations')
|
|
->assertDontSee('← Back to Archived Tenant');
|
|
});
|