ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity
a490261eca
TenantAtlas/tests/Feature/Guards/FilamentTableStandardsGuardTest.php
ahmido a490261eca feat: standardize filter UX across key resources (#154) 
## Summary
- standardize filter UX across key Filament resources with shared thin filter helpers for centralized option sourcing and archived/date-range presets
- add persistence, essential filters, and OperationCatalog-aligned labels across the targeted resource tables
- add and extend focused Pest coverage for guards, persistence, filter behavior, scope safety, and the new Spec 126 planning artifacts

## Spec 126
- add the full Spec 126 artifact set under `specs/126-filter-ux-standardization/`
- align spec, plan, research, data model, quickstart, contract, checklist, and tasks for implementation readiness

## Validation
- `vendor/bin/sail bin pint --dirty --format agent`
- `vendor/bin/sail artisan test --compact tests/Feature/Guards/FilamentTableStandardsGuardTest.php tests/Feature/Filament/TableStatePersistenceTest.php tests/Feature/Findings/FindingsListFiltersTest.php tests/Feature/Findings/FindingsListDefaultsTest.php tests/Feature/Alerts/AlertDeliveryDeepLinkFiltersTest.php tests/Feature/Filament/Alerts/AlertDeliveryViewerTest.php tests/Feature/Filament/OperationRunListFiltersTest.php tests/Feature/Filament/PolicyVersionListFiltersTest.php tests/Feature/Filament/RestoreRunListFiltersTest.php tests/Feature/Filament/InventoryItemListFiltersTest.php tests/Feature/Filament/BaselineProfileListFiltersTest.php tests/Feature/ProviderConnections/TenantFilterOverrideTest.php tests/Feature/Rbac/InventoryItemResourceAuthorizationTest.php tests/Feature/Filament/BaselineTenantAssignmentsRelationManagerTest.php`

## Notes
- no new OperationRun lifecycle or operational workflow behavior is introduced; only existing OperationRun table filter-label alignment and related coverage are in scope
- existing authorization and action-surface semantics remain unchanged

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #154
2026-03-09 06:27:22 +00:00

272 lines
13 KiB
PHP
Raw Blame History

<?php
declare(strict_types=1);
use Illuminate\Support\Collection;
it('declares default sorts for the standardized table surface inventory', function (): void {
$paths = collect([
'app/Filament/Resources/TenantResource.php',
'app/Filament/Resources/PolicyResource.php',
'app/Filament/Resources/BackupSetResource.php',
'app/Filament/Resources/BackupScheduleResource.php',
'app/Filament/Resources/ProviderConnectionResource.php',
'app/Filament/Resources/FindingResource.php',
'app/Filament/Resources/OperationRunResource.php',
'app/Filament/Resources/EntraGroupResource.php',
'app/Filament/Resources/AlertDeliveryResource.php',
'app/Filament/Resources/AlertRuleResource.php',
'app/Filament/Resources/AlertDestinationResource.php',
'app/Filament/Resources/BaselineProfileResource.php',
'app/Filament/Resources/BaselineSnapshotResource.php',
'app/Filament/Resources/InventoryItemResource.php',
'app/Filament/Resources/PolicyVersionResource.php',
'app/Filament/Resources/ReviewPackResource.php',
'app/Filament/Resources/Workspaces/WorkspaceResource.php',
'app/Filament/Resources/TenantResource/RelationManagers/TenantMembershipsRelationManager.php',
'app/Filament/Resources/Workspaces/RelationManagers/WorkspaceMembershipsRelationManager.php',
'app/Filament/Resources/BaselineProfileResource/RelationManagers/BaselineTenantAssignmentsRelationManager.php',
'app/Filament/Resources/BackupSetResource/RelationManagers/BackupItemsRelationManager.php',
'app/Filament/Resources/PolicyResource/RelationManagers/VersionsRelationManager.php',
'app/Filament/Resources/BackupScheduleResource/RelationManagers/BackupScheduleOperationRunsRelationManager.php',
'app/Filament/Pages/InventoryCoverage.php',
'app/Filament/System/Pages/Directory/Tenants.php',
'app/Filament/System/Pages/Directory/Workspaces.php',
'app/Filament/System/Pages/Ops/Runs.php',
'app/Filament/System/Pages/Ops/Failures.php',
'app/Filament/System/Pages/Ops/Stuck.php',
'app/Filament/System/Pages/Security/AccessLogs.php',
'app/Filament/System/Pages/RepairWorkspaceOwners.php',
'app/Filament/Widgets/Dashboard/RecentDriftFindings.php',
'app/Filament/Widgets/Dashboard/RecentOperations.php',
'app/Livewire/BackupSetPolicyPickerTable.php',
'app/Livewire/EntraGroupCachePickerTable.php',
'app/Livewire/SettingsCatalogSettingsTable.php',
]);
/** @var Collection<int, string> $missing */
$missing = $paths
->filter(function (string $relativePath): bool {
$contents = file_get_contents(base_path($relativePath));
return ! is_string($contents) || ! str_contains($contents, '->defaultSort(');
})
->values();
expect($missing)->toBeEmpty('Missing explicit default sort declarations: '.implode(', ', $missing->all()));
});
it('declares domain-specific empty states across the standardized table surface inventory', function (): void {
$patternByPath = [
'app/Filament/Resources/TenantResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/PolicyResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/BackupSetResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/BackupScheduleResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/ProviderConnectionResource/Pages/ListProviderConnections.php' => ['getTableEmptyStateHeading', 'getTableEmptyStateDescription'],
'app/Filament/Resources/FindingResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/OperationRunResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/EntraGroupResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/AlertDeliveryResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/AlertRuleResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/AlertDestinationResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/BaselineProfileResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/BaselineSnapshotResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/InventoryItemResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/PolicyVersionResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/ReviewPackResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/Workspaces/WorkspaceResource.php' => ['->emptyStateHeading('],
'app/Filament/Resources/TenantResource/RelationManagers/TenantMembershipsRelationManager.php' => ['->emptyStateHeading('],
'app/Filament/Resources/Workspaces/RelationManagers/WorkspaceMembershipsRelationManager.php' => ['->emptyStateHeading('],
'app/Filament/Resources/BaselineProfileResource/RelationManagers/BaselineTenantAssignmentsRelationManager.php' => ['->emptyStateHeading('],
'app/Filament/Resources/BackupSetResource/RelationManagers/BackupItemsRelationManager.php' => ['->emptyStateHeading('],
'app/Filament/Resources/PolicyResource/RelationManagers/VersionsRelationManager.php' => ['->emptyStateHeading('],
'app/Filament/Resources/BackupScheduleResource/RelationManagers/BackupScheduleOperationRunsRelationManager.php' => ['->emptyStateHeading('],
'app/Filament/Pages/InventoryCoverage.php' => ['->emptyStateHeading('],
'app/Filament/System/Pages/Directory/Tenants.php' => ['->emptyStateHeading('],
'app/Filament/System/Pages/Directory/Workspaces.php' => ['->emptyStateHeading('],
'app/Filament/System/Pages/Ops/Runs.php' => ['->emptyStateHeading('],
'app/Filament/System/Pages/Ops/Failures.php' => ['->emptyStateHeading('],
'app/Filament/System/Pages/Ops/Stuck.php' => ['->emptyStateHeading('],
'app/Filament/System/Pages/Security/AccessLogs.php' => ['->emptyStateHeading('],
'app/Filament/System/Pages/RepairWorkspaceOwners.php' => ['->emptyStateHeading('],
'app/Filament/Widgets/Dashboard/RecentDriftFindings.php' => ['->emptyStateHeading('],
'app/Filament/Widgets/Dashboard/RecentOperations.php' => ['->emptyStateHeading('],
'app/Livewire/BackupSetPolicyPickerTable.php' => ['->emptyStateHeading('],
'app/Livewire/EntraGroupCachePickerTable.php' => ['->emptyStateHeading('],
'app/Livewire/SettingsCatalogSettingsTable.php' => ['->emptyStateHeading('],
];
$missing = [];
foreach ($patternByPath as $relativePath => $patterns) {
$contents = file_get_contents(base_path($relativePath));
if (! is_string($contents)) {
$missing[] = $relativePath;
continue;
}
foreach ($patterns as $pattern) {
if (! str_contains($contents, $pattern)) {
$missing[] = $relativePath;
break;
}
}
}
expect($missing)->toBeEmpty('Missing standardized empty-state declarations: '.implode(', ', $missing));
});
it('keeps persistence declarations explicit on the designated critical resource lists', function (): void {
$paths = [
'app/Filament/Resources/TenantResource.php',
'app/Filament/Resources/PolicyResource.php',
'app/Filament/Resources/BackupSetResource.php',
'app/Filament/Resources/BackupScheduleResource.php',
'app/Filament/Resources/ProviderConnectionResource.php',
'app/Filament/Resources/FindingResource.php',
'app/Filament/Resources/InventoryItemResource.php',
'app/Filament/Resources/PolicyVersionResource.php',
'app/Filament/Resources/RestoreRunResource.php',
'app/Filament/Resources/AlertDeliveryResource.php',
'app/Filament/Resources/EntraGroupResource.php',
'app/Filament/Resources/OperationRunResource.php',
];
$missing = [];
foreach ($paths as $relativePath) {
$contents = file_get_contents(base_path($relativePath));
if (! is_string($contents)) {
$missing[] = $relativePath;
continue;
}
foreach (['->persistSearchInSession()', '->persistSortInSession()', '->persistFiltersInSession()'] as $pattern) {
if (! str_contains($contents, $pattern)) {
$missing[] = "{$relativePath} ({$pattern})";
}
}
}
expect($missing)->toBeEmpty('Missing persistence declarations: '.implode(', ', $missing));
});
it('uses shared archived and date-range presets on the repeated soft-delete filter surfaces', function (): void {
$patternByPath = [
'app/Filament/Resources/PolicyVersionResource.php' => [
'FilterPresets::dateRange(',
'FilterPresets::archived()',
],
'app/Filament/Resources/RestoreRunResource.php' => [
'FilterPresets::dateRange(',
'FilterPresets::archived()',
],
];
$missing = [];
foreach ($patternByPath as $relativePath => $patterns) {
$contents = file_get_contents(base_path($relativePath));
if (! is_string($contents)) {
$missing[] = $relativePath;
continue;
}
foreach ($patterns as $pattern) {
if (! str_contains($contents, $pattern)) {
$missing[] = "{$relativePath} ({$pattern})";
}
}
}
expect($missing)->toBeEmpty('Missing shared filter presets: '.implode(', ', $missing));
});
it('uses centralized option sources for the prioritized status and operation filters', function (): void {
$patternByPath = [
'app/Filament/Resources/FindingResource.php' => ['FilterOptionCatalog::findingStatuses()'],
'app/Filament/Resources/AlertDeliveryResource.php' => ['FilterOptionCatalog::alertDeliveryStatuses()'],
'app/Filament/Resources/BaselineProfileResource.php' => ['FilterOptionCatalog::baselineProfileStatuses()'],
'app/Filament/Resources/OperationRunResource.php' => ['FilterOptionCatalog::operationTypes('],
];
$missing = [];
foreach ($patternByPath as $relativePath => $patterns) {
$contents = file_get_contents(base_path($relativePath));
if (! is_string($contents)) {
$missing[] = $relativePath;
continue;
}
foreach ($patterns as $pattern) {
if (! str_contains($contents, $pattern)) {
$missing[] = "{$relativePath} ({$pattern})";
}
}
}
expect($missing)->toBeEmpty('Missing centralized filter option sourcing: '.implode(', ', $missing));
});
it('uses the shared pagination profile helper on standardized surfaces', function (): void {
$paths = [
'app/Filament/Resources/TenantResource.php',
'app/Filament/Resources/PolicyResource.php',
'app/Filament/Resources/BackupSetResource.php',
'app/Filament/Resources/BackupScheduleResource.php',
'app/Filament/Resources/ProviderConnectionResource.php',
'app/Filament/Resources/FindingResource.php',
'app/Filament/Resources/OperationRunResource.php',
'app/Filament/Resources/EntraGroupResource.php',
'app/Filament/Resources/AlertDeliveryResource.php',
'app/Filament/Resources/AlertRuleResource.php',
'app/Filament/Resources/AlertDestinationResource.php',
'app/Filament/Resources/BaselineProfileResource.php',
'app/Filament/Resources/BaselineSnapshotResource.php',
'app/Filament/Resources/InventoryItemResource.php',
'app/Filament/Resources/PolicyVersionResource.php',
'app/Filament/Resources/ReviewPackResource.php',
'app/Filament/Resources/Workspaces/WorkspaceResource.php',
'app/Filament/Resources/TenantResource/RelationManagers/TenantMembershipsRelationManager.php',
'app/Filament/Resources/Workspaces/RelationManagers/WorkspaceMembershipsRelationManager.php',
'app/Filament/Resources/BaselineProfileResource/RelationManagers/BaselineTenantAssignmentsRelationManager.php',
'app/Filament/Resources/BackupSetResource/RelationManagers/BackupItemsRelationManager.php',
'app/Filament/Resources/PolicyResource/RelationManagers/VersionsRelationManager.php',
'app/Filament/Resources/BackupScheduleResource/RelationManagers/BackupScheduleOperationRunsRelationManager.php',
'app/Filament/Pages/InventoryCoverage.php',
'app/Filament/System/Pages/Directory/Tenants.php',
'app/Filament/System/Pages/Directory/Workspaces.php',
'app/Filament/System/Pages/Ops/Runs.php',
'app/Filament/System/Pages/Ops/Failures.php',
'app/Filament/System/Pages/Ops/Stuck.php',
'app/Filament/System/Pages/Security/AccessLogs.php',
'app/Filament/System/Pages/RepairWorkspaceOwners.php',
'app/Filament/Widgets/Dashboard/RecentDriftFindings.php',
'app/Filament/Widgets/Dashboard/RecentOperations.php',
'app/Livewire/BackupSetPolicyPickerTable.php',
'app/Livewire/EntraGroupCachePickerTable.php',
'app/Livewire/SettingsCatalogSettingsTable.php',
];
$missing = collect($paths)
->filter(function (string $relativePath): bool {
$contents = file_get_contents(base_path($relativePath));
return ! is_string($contents) || ! str_contains($contents, 'TablePaginationProfiles::');
})
->values()
->all();
expect($missing)->toBeEmpty('Missing pagination profile helper usage: '.implode(', ', $missing));
});
Reference in New Issue View Git Blame Copy Permalink