TenantAtlas/tests/Feature/Filament/TableStandardsBaselineTest.php
ahmido a4f5c4f122 Spec 125: standardize Filament table UX (#152)
## Summary
- standardize Filament table defaults across resources, relation managers, widgets, custom pages, and picker tables
- add shared pagination profiles, calm default column visibility, explicit empty states, and session persistence on designated critical resource lists
- complete Spec 125 artifacts, regression tests, and dashboard widget follow-up for lazy loading, sortable columns, and toggleable detail columns

## Verification
- `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=BaselineCompareNow`
- `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=TableStandardsBaseline`
- `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=TableDetailVisibility`
- `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=FilamentTableRiskExceptions`
- full suite run completed: `2017 passed, 10 failed, 8 skipped`
- manual browser QA completed on the tenant dashboard for lazy loading, sortable widget columns, toggleable hidden status columns, badges, and pagination

## Known Failures
The full suite still has 10 pre-existing failures unrelated to this branch:
- `Tests\\Unit\\OpsUx\\SummaryCountsNormalizerTest`
- `Tests\\Feature\\BackupWithAssignmentsConsistencyTest` (2 tests)
- `Tests\\Feature\\BaselineDriftEngine\\CaptureBaselineContentTest`
- `Tests\\Feature\\BaselineDriftEngine\\CompareContentEvidenceTest`
- `Tests\\Feature\\BaselineDriftEngine\\ResolverTest`
- `Tests\\Feature\\Filament\\TenantDashboardDbOnlyTest`
- `Tests\\Feature\\Operations\\ReconcileAdapterRunsJobTrackingTest`
- `Tests\\Feature\\ReviewPack\\ReviewPackRbacTest`
- `Tests\\Feature\\Verification\\VerificationReportRedactionTest`

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #152
2026-03-08 22:54:56 +00:00

158 lines
7.0 KiB
PHP

<?php
declare(strict_types=1);
use App\Filament\Pages\InventoryCoverage;
use App\Filament\Resources\PolicyResource\Pages\ListPolicies;
use App\Filament\Resources\PolicyResource\Pages\ViewPolicy;
use App\Filament\Resources\PolicyResource\RelationManagers\VersionsRelationManager;
use App\Filament\Widgets\Dashboard\RecentDriftFindings;
use App\Livewire\EntraGroupCachePickerTable;
use App\Models\Policy;
use App\Support\Filament\TablePaginationProfiles;
use Filament\Facades\Filament;
use Filament\Tables\Table;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Livewire\Features\SupportTesting\Testable;
use Livewire\Livewire;
uses(RefreshDatabase::class);
function spec125BaselineTable(Testable $component): Table
{
return $component->instance()->getTable();
}
/**
* @return array{0: \App\Models\User, 1: \App\Models\Tenant}
*/
function spec125BaselineTenantContext(): array
{
[$user, $tenant] = createUserWithTenant(role: 'owner');
test()->actingAs($user);
$tenant->makeCurrent();
Filament::setTenant($tenant, true);
return [$user, $tenant];
}
it('keeps the policy resource list as the baseline resource-standard example', function (): void {
[$user] = spec125BaselineTenantContext();
$component = Livewire::actingAs($user)->test(ListPolicies::class)
->assertTableEmptyStateActionsExistInOrder(['sync']);
$table = spec125BaselineTable($component);
expect($table->getDefaultSortColumn())->toBe('display_name');
expect($table->getDefaultSortDirection())->toBe('asc');
expect($table->getPaginationPageOptions())->toBe(TablePaginationProfiles::resource());
expect($table->persistsSearchInSession())->toBeTrue();
expect($table->persistsSortInSession())->toBeTrue();
expect($table->persistsFiltersInSession())->toBeTrue();
expect($table->getEmptyStateHeading())->toBe('No policies synced yet');
expect($table->getEmptyStateDescription())->toBe('Sync your first tenant to see Intune policies here.');
expect(array_keys($table->getVisibleColumns()))->toContain('display_name', 'policy_type', 'platform', 'last_synced_at');
$displayName = $table->getColumn('display_name');
$externalId = $table->getColumn('external_id');
expect($displayName)->not->toBeNull();
expect($displayName?->isSearchable())->toBeTrue();
expect($displayName?->isSortable())->toBeTrue();
expect($externalId)->not->toBeNull();
expect($externalId?->isToggleable())->toBeTrue();
expect($externalId?->isToggledHiddenByDefault())->toBeTrue();
expect(array_keys($table->getVisibleColumns()))->not->toContain('external_id');
});
it('keeps the policy versions relation manager on the standard relation-manager contract', function (): void {
[$user, $tenant] = spec125BaselineTenantContext();
$policy = Policy::factory()->create([
'tenant_id' => (int) $tenant->getKey(),
]);
$component = Livewire::actingAs($user)->test(VersionsRelationManager::class, [
'ownerRecord' => $policy,
'pageClass' => ViewPolicy::class,
]);
$table = spec125BaselineTable($component);
expect($table->getDefaultSortColumn())->toBe('version_number');
expect($table->getDefaultSortDirection())->toBe('desc');
expect($table->getPaginationPageOptions())->toBe(TablePaginationProfiles::relationManager());
expect($table->getEmptyStateHeading())->toBe('No versions captured');
expect($table->getEmptyStateDescription())->toBe('Capture or sync this policy again to create version history entries.');
expect($table->getColumn('version_number')?->isSortable())->toBeTrue();
expect($table->getColumn('captured_at')?->isSortable())->toBeTrue();
expect($table->getColumn('policy_type')?->isToggleable())->toBeTrue();
expect($table->getColumn('policy_type')?->isToggledHiddenByDefault())->toBeTrue();
});
it('keeps the dashboard widget profile minimal and scan-first', function (): void {
[$user] = spec125BaselineTenantContext();
$component = Livewire::actingAs($user)->test(RecentDriftFindings::class);
$table = spec125BaselineTable($component);
expect($table->getDefaultSortColumn())->toBe('created_at');
expect($table->getDefaultSortDirection())->toBe('desc');
expect($table->getPaginationPageOptions())->toBe(TablePaginationProfiles::widget());
expect($table->getEmptyStateHeading())->toBe('No drift findings');
expect($table->getEmptyStateDescription())->toBe('You\'re looking good — no drift findings to review yet.');
expect(array_keys($table->getVisibleColumns()))->toBe([
'short_id',
'subject_display_name',
'severity',
'created_at',
]);
expect($table->getColumn('status')?->isToggleable())->toBeTrue();
expect($table->getColumn('status')?->isToggledHiddenByDefault())->toBeTrue();
expect($table->getColumn('severity')?->isSortable())->toBeTrue();
expect($table->getColumn('created_at')?->isSortable())->toBeTrue();
});
it('keeps custom table pages on their explicit profile without hidden framework defaults', function (): void {
[$user] = spec125BaselineTenantContext();
$component = Livewire::actingAs($user)->test(InventoryCoverage::class)
->assertTableEmptyStateActionsExistInOrder(['clear_filters']);
$table = spec125BaselineTable($component);
expect($table->getDefaultSortColumn())->toBe('label');
expect($table->getDefaultSortDirection())->toBe('asc');
expect($table->getPaginationPageOptions())->toBe(TablePaginationProfiles::customPage());
expect($table->getEmptyStateHeading())->toBe('No coverage entries match this view');
expect($table->getEmptyStateDescription())->toBe('Clear the current search or filters to return to the full coverage matrix.');
expect($table->getColumn('type')?->isSortable())->toBeTrue();
expect($table->getColumn('label')?->isSortable())->toBeTrue();
expect($table->getColumn('dependencies')?->isToggleable())->toBeTrue();
});
it('keeps picker tables workflow-local while still following the shared picker defaults', function (): void {
[$user] = spec125BaselineTenantContext();
$component = Livewire::actingAs($user)->test(EntraGroupCachePickerTable::class, [
'sourceGroupId' => 'source-group-1',
]);
$table = spec125BaselineTable($component);
expect($table->getDefaultSortColumn())->toBe('display_name');
expect($table->getDefaultSortDirection())->toBe('asc');
expect($table->getPaginationPageOptions())->toBe(TablePaginationProfiles::picker());
expect($table->getEmptyStateHeading())->toBe('No cached groups found');
expect($table->getEmptyStateDescription())->toBe('Run “Sync Groups” first, then come back here.');
expect($table->persistsSearchInSession())->toBeFalse();
expect($table->persistsSortInSession())->toBeFalse();
expect($table->persistsFiltersInSession())->toBeFalse();
expect($table->getColumn('display_name')?->isSearchable())->toBeTrue();
expect($table->getColumn('display_name')?->isSortable())->toBeTrue();
expect($table->getColumn('entra_id')?->isToggleable())->toBeTrue();
expect($table->getColumn('entra_id')?->isToggledHiddenByDefault())->toBeTrue();
});