ahmido
3030dd9af2
Summary Kurz: Implementiert Feature 054 — canonical OperationRun-flow, Monitoring UI, dispatch-safety, notifications, dedupe, plus small UX safety clarifications (RBAC group search delegated; Restore group mapping DB-only). What Changed Core service: OperationRun lifecycle, dedupe and dispatch helpers — OperationRunService.php. Model + migration: OperationRun model and migration — OperationRun.php, 2026_01_16_180642_create_operation_runs_table.php. Notifications: queued + terminal DB notifications (initiator-only) — OperationRunQueued.php, OperationRunCompleted.php. Monitoring UI: Filament list/detail + Livewire pieces (DB-only render) — OperationRunResource.php and related pages/views. Start surfaces / Jobs: instrumented start surfaces, job middleware, and job updates to use canonical runs — multiple app/Jobs/* and app/Filament/* updates (see tests for full coverage). RBAC + Restore UX clarifications: RBAC group search is delegated-Graph-based and disabled without delegated token; Restore group mapping remains DB-only (directory cache) and helper text always visible — TenantResource.php, RestoreRunResource.php. Specs / Constitution: updated spec & quickstart and added one-line constitution guideline about Graph usage: spec.md quickstart.md constitution.md Tests & Verification Unit / Feature tests added/updated for run lifecycle, notifications, idempotency, and UI guards: see tests/Feature/* (notably OperationRunServiceTest, MonitoringOperationsTest, OperationRunNotificationTest, and various Filament feature tests). Full test run locally: ./vendor/bin/sail artisan test → 587 passed, 5 skipped. Migrations Adds create_operation_runs_table migration; run php artisan migrate in staging after review. Notes / Rationale Monitoring pages are explicitly DB-only at render time (no Graph calls). Start surfaces enqueue work only and return a “View run” link. Delegated Graph access is used only for explicit user actions (RBAC group search); restore mapping intentionally uses cached DB data only to avoid render-time Graph calls. Dispatch wrapper marks runs failed immediately if background dispatch throws synchronously to avoid misleading “queued” states. Upgrade / Deploy Considerations Run migrations: ./vendor/bin/sail artisan migrate. Background workers should be running to process queued jobs (recommended to monitor queue health during rollout). No secret or token persistence changes. PR checklist Tests updated/added for changed behavior Specs updated: 054-unify-runs-suitewide docs + quickstart Constitution note added (.specify) Pint formatting applied Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #63
108 lines
4.2 KiB
PHP
108 lines
4.2 KiB
PHP
<x-filament::page>
|
|
<x-filament::section>
|
|
<div class="flex flex-col gap-3">
|
|
<div class="text-sm text-gray-600 dark:text-gray-300">
|
|
Review new drift findings between the last two inventory sync runs for the current scope.
|
|
</div>
|
|
|
|
@if (filled($scopeKey))
|
|
<div class="text-sm text-gray-600 dark:text-gray-300">
|
|
Scope: {{ $scopeKey }}
|
|
@if ($baselineRunId && $currentRunId)
|
|
· Baseline
|
|
@if ($this->getBaselineRunUrl())
|
|
<a class="text-primary-600 hover:underline" href="{{ $this->getBaselineRunUrl() }}">
|
|
#{{ $baselineRunId }}
|
|
</a>
|
|
@else
|
|
#{{ $baselineRunId }}
|
|
@endif
|
|
@if (filled($baselineFinishedAt))
|
|
({{ $baselineFinishedAt }})
|
|
@endif
|
|
· Current
|
|
@if ($this->getCurrentRunUrl())
|
|
<a class="text-primary-600 hover:underline" href="{{ $this->getCurrentRunUrl() }}">
|
|
#{{ $currentRunId }}
|
|
</a>
|
|
@else
|
|
#{{ $currentRunId }}
|
|
@endif
|
|
@if (filled($currentFinishedAt))
|
|
({{ $currentFinishedAt }})
|
|
@endif
|
|
@endif
|
|
</div>
|
|
@endif
|
|
|
|
@if ($state === 'blocked')
|
|
<x-filament::badge color="gray">
|
|
Blocked
|
|
</x-filament::badge>
|
|
|
|
@if (filled($message))
|
|
<div class="text-sm text-gray-600 dark:text-gray-300">
|
|
{{ $message }}
|
|
</div>
|
|
@endif
|
|
@elseif ($state === 'generating')
|
|
<x-filament::badge color="warning">
|
|
Generating
|
|
</x-filament::badge>
|
|
|
|
<div class="text-sm text-gray-600 dark:text-gray-300">
|
|
Drift generation has been queued. Refresh this page once it finishes.
|
|
</div>
|
|
|
|
@if ($this->getOperationRunUrl())
|
|
<div class="text-sm">
|
|
<a class="text-primary-600 hover:underline" href="{{ $this->getOperationRunUrl() }}">
|
|
View run #{{ $operationRunId }}
|
|
</a>
|
|
</div>
|
|
@endif
|
|
@elseif ($state === 'error')
|
|
<x-filament::badge color="danger">
|
|
Error
|
|
</x-filament::badge>
|
|
|
|
@if (filled($message))
|
|
<div class="text-sm text-gray-600 dark:text-gray-300">
|
|
{{ $message }}
|
|
</div>
|
|
@endif
|
|
|
|
@if ($this->getOperationRunUrl())
|
|
<div class="text-sm">
|
|
<a class="text-primary-600 hover:underline" href="{{ $this->getOperationRunUrl() }}">
|
|
View run #{{ $operationRunId }}
|
|
</a>
|
|
</div>
|
|
@endif
|
|
@elseif ($state === 'ready')
|
|
<div class="flex flex-wrap gap-3">
|
|
<x-filament::badge color="success">
|
|
New: {{ (int) ($statusCounts['new'] ?? 0) }}
|
|
</x-filament::badge>
|
|
</div>
|
|
|
|
@if (filled($message))
|
|
<div class="text-sm text-gray-600 dark:text-gray-300">
|
|
{{ $message }}
|
|
</div>
|
|
@endif
|
|
@else
|
|
<x-filament::badge color="gray">
|
|
Ready
|
|
</x-filament::badge>
|
|
@endif
|
|
|
|
<div class="flex flex-wrap gap-3">
|
|
<x-filament::button tag="a" :href="$this->getFindingsUrl()">
|
|
Findings
|
|
</x-filament::button>
|
|
</div>
|
|
</div>
|
|
</x-filament::section>
|
|
</x-filament::page>
|