ahmido
fb32e9bfa5
Some checks failed
Main Confidence / confidence (push) Failing after 49s
## Summary - implement the canonical operation type source-of-truth slice across operation writers, monitoring surfaces, onboarding flows, and supporting services - add focused contract and regression coverage for canonical operation type handling - include the generated spec 239 artifacts for the feature slice ## Validation - browser smoke PASS for `/admin` -> workspace overview -> operations -> operation detail -> tenant-scoped operations drilldown - spec/plan/tasks/quickstart artifact analysis cleaned up to a no-findings state - automated test suite not run in this session Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #276
105 lines
3.5 KiB
PHP
105 lines
3.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\AuditLog;
|
|
use App\Models\OperationRun;
|
|
use App\Services\Evidence\Sources\OperationsSummarySource;
|
|
use App\Services\OperationRunService;
|
|
use App\Support\Audit\AuditOutcome;
|
|
use App\Support\OperationRunOutcome;
|
|
use App\Support\OperationRunStatus;
|
|
|
|
it('writes a terminal audit row when an operation run completes', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$service = app(OperationRunService::class);
|
|
|
|
$run = $service->ensureRunWithIdentity(
|
|
tenant: $tenant,
|
|
type: 'inventory.sync',
|
|
identityInputs: ['selection_hash' => 'abc123'],
|
|
context: ['selection_hash' => 'abc123'],
|
|
initiator: $user,
|
|
);
|
|
|
|
$service->updateRun(
|
|
$run,
|
|
status: OperationRunStatus::Completed->value,
|
|
outcome: OperationRunOutcome::Succeeded->value,
|
|
summaryCounts: [
|
|
'total' => 3,
|
|
'processed' => 3,
|
|
'succeeded' => 3,
|
|
'failed' => 0,
|
|
],
|
|
);
|
|
|
|
$audit = AuditLog::query()
|
|
->where('operation_run_id', (int) $run->getKey())
|
|
->latest('id')
|
|
->first();
|
|
|
|
expect($audit)->not->toBeNull();
|
|
|
|
expect($audit?->action)->toBe('operation.completed')
|
|
->and($audit?->summaryText())->toBe('Inventory sync completed')
|
|
->and($audit?->resource_type)->toBe('operation_run')
|
|
->and((string) $audit?->resource_id)->toBe((string) $run->getKey())
|
|
->and($audit?->normalizedOutcome())->toBe(AuditOutcome::Success)
|
|
->and($audit?->actorDisplayLabel())->toBe($user->name)
|
|
->and(data_get($audit?->metadata, 'operation_type'))->toBe('inventory.sync');
|
|
});
|
|
|
|
it('writes blocked terminal audit semantics for blocked runs', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$service = app(OperationRunService::class);
|
|
|
|
$run = $service->ensureRunWithIdentity(
|
|
tenant: $tenant,
|
|
type: 'restore.execute',
|
|
identityInputs: ['restore_run_id' => 44],
|
|
context: ['restore_run_id' => 44],
|
|
initiator: $user,
|
|
);
|
|
|
|
$service->finalizeBlockedRun(
|
|
$run,
|
|
reasonCode: 'intune_rbac.not_configured',
|
|
message: 'Restore is blocked until RBAC is configured.',
|
|
);
|
|
|
|
$audit = AuditLog::query()
|
|
->where('operation_run_id', (int) $run->getKey())
|
|
->latest('id')
|
|
->first();
|
|
|
|
expect($audit)->not->toBeNull();
|
|
|
|
expect($audit?->action)->toBe('operation.blocked')
|
|
->and($audit?->summaryText())->toBe('Restore execution blocked')
|
|
->and($audit?->normalizedOutcome())->toBe(AuditOutcome::Blocked)
|
|
->and(data_get($audit?->metadata, 'failure_summary.0.reason_code'))->toBe('intune_rbac.not_configured');
|
|
});
|
|
|
|
it('emits canonical operation types in operations evidence summaries for historical rows', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
OperationRun::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'user_id' => (int) $user->getKey(),
|
|
'type' => 'inventory_sync',
|
|
'outcome' => OperationRunOutcome::Failed->value,
|
|
'created_at' => now()->subMinute(),
|
|
]);
|
|
|
|
$payload = app(OperationsSummarySource::class)->collect($tenant);
|
|
$entry = data_get($payload, 'summary_payload.entries.0');
|
|
|
|
expect($entry)->toBeArray()
|
|
->and($entry['operation_type'] ?? null)->toBe('inventory.sync')
|
|
->and($entry['type'] ?? null)->toBe('inventory_sync');
|
|
});
|