ahmido
e0c2cdb1f4
## Summary - enforce the canonical workspace/environment scope contract for workspace hubs and environment-owned surfaces - replace first-party Operations deep links that leaked Filament `tableFilters[...]` internals with stable product-level query behavior - add the sidebar scope indicator and split environment-page navigation into explicit `Workspace-wide` and `Workspace admin` groups - remove redundant tenantless `All environments` scope badges from workspace-wide pages while preserving explicit environment filter affordances - include the Spec 338 artifacts, guard tests, and browser smoke coverage for the new contract ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Navigation/Spec338EnvironmentSidebarSeparationTest.php tests/Feature/Navigation/Spec338OperationRunLinksQueryContractTest.php tests/Feature/Navigation/Spec338SidebarScopeIndicatorTest.php tests/Feature/Filament/PanelNavigationSegregationTest.php` - `cd apps/platform && ./vendor/bin/sail php vendor/bin/pest tests/Browser/Spec338ScopeContractSmokeTest.php --compact` ## Notes - Livewire v4 compliance unchanged - Filament provider registration remains in `bootstrap/providers.php` - no destructive action behavior changed - no migrations, env var changes, or new Filament asset registration Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #409
43 lines
1.8 KiB
PHP
43 lines
1.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Models\User;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('shows a recovery label when workspace-scoped surfaces render without an active workspace', function (): void {
|
|
$tenant = ManagedEnvironment::factory()->active()->create(['name' => 'Recovery ManagedEnvironment']);
|
|
[$user] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
session()->forget(WorkspaceContext::SESSION_KEY);
|
|
|
|
$this->actingAs($user)
|
|
->get('/admin/workspaces')
|
|
->assertOk()
|
|
->assertSee('Context unavailable')
|
|
->assertSee('Choose workspace');
|
|
});
|
|
|
|
it('shows explicit recovery wording when an invalid tenant hint is discarded on a workspace route', function (): void {
|
|
$validTenant = ManagedEnvironment::factory()->active()->create(['name' => 'Valid Workspace ManagedEnvironment']);
|
|
[$user, $validTenant] = createUserWithTenant(tenant: $validTenant, role: 'owner');
|
|
|
|
$foreignTenant = ManagedEnvironment::factory()->active()->create(['name' => 'Foreign Workspace ManagedEnvironment']);
|
|
createUserWithTenant(tenant: $foreignTenant, user: User::factory()->create(), role: 'owner');
|
|
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $validTenant->workspace_id,
|
|
])
|
|
->get(route('admin.operations.index', ['workspace' => $validTenant->workspace, 'tenant' => $foreignTenant->external_id]))
|
|
->assertOk()
|
|
->assertSee(__('localization.shell.choose_environment'))
|
|
->assertDontSee('Context unavailable')
|
|
->assertDontSee(__('localization.shell.no_environment_selected'))
|
|
->assertDontSee(__('localization.shell.environment_scope').': '.$foreignTenant->name);
|
|
});
|