ahmido
ec9649897a
## Summary - cut over workspace-owned analysis and library surfaces to workspace shell ownership instead of inheriting remembered environment shell context - update the affected findings pages, scope resolution, navigation helpers, and related Blade views to keep environment focus explicit instead of implicit - add and update Spec 320 artifacts plus focused regression coverage for findings navigation context, workspace hub registration, and admin surface scope behavior ## Guardrails - Filament remains on v5 with Livewire v4 compliance unchanged - provider registration remains in apps/platform/bootstrap/providers.php - no new globally searchable resources were introduced or changed - no new destructive actions were introduced or changed - no Filament assets were added or changed, so the deploy requirement for filament:assets is unchanged ## Testing - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Findings/FindingsAssignmentHygieneReportTest.php tests/Feature/Findings/FindingsIntakeQueueNavigationContextTest.php tests/Feature/Findings/FindingsIntakeQueueTest.php tests/Feature/Findings/MyFindingsInboxNavigationContextTest.php tests/Feature/Findings/MyWorkInboxTest.php tests/Feature/Navigation/WorkspaceHubRegistryTest.php tests/Unit/Support/OperateHub/OperateHubShellResolutionTest.php tests/Unit/Tenants/AdminSurfaceScopeTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #375
60 lines
2.3 KiB
PHP
60 lines
2.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Pages\Findings\FindingsIntakeQueue;
|
|
use App\Filament\Pages\Governance\GovernanceInbox;
|
|
use App\Models\Finding;
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Support\Navigation\CanonicalNavigationContext;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Livewire\Livewire;
|
|
|
|
it('keeps findings intake secondary when opened from the governance inbox', function (): void {
|
|
$tenant = ManagedEnvironment::factory()->create([
|
|
'status' => 'active',
|
|
'name' => 'Alpha ManagedEnvironment',
|
|
'external_id' => 'alpha-tenant',
|
|
]);
|
|
[$user, $tenant] = createUserWithTenant($tenant, role: 'owner', workspaceRole: 'owner');
|
|
|
|
$finding = Finding::factory()
|
|
->for($tenant)
|
|
->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'assignee_user_id' => null,
|
|
'status' => Finding::STATUS_NEW,
|
|
'subject_external_id' => 'intake-from-governance',
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
Filament::setCurrentPanel('admin');
|
|
Filament::setTenant(null, true);
|
|
Filament::bootCurrentPanel();
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenant->workspace_id);
|
|
|
|
$context = CanonicalNavigationContext::forGovernanceInbox(
|
|
canonicalRouteName: GovernanceInbox::getRouteName(Filament::getPanel('admin')),
|
|
tenantId: (int) $tenant->getKey(),
|
|
familyKey: 'intake_findings',
|
|
backLinkUrl: GovernanceInbox::getUrl(panel: 'admin', parameters: [
|
|
'environment_id' => (int) $tenant->getKey(),
|
|
'family' => 'intake_findings',
|
|
]),
|
|
);
|
|
|
|
Livewire::withHeaders(['referer' => FindingsIntakeQueue::getUrl(panel: 'admin')])
|
|
->withQueryParams(array_replace($context->toQuery(), [
|
|
'environment_id' => (int) $tenant->getKey(),
|
|
'view' => 'needs_triage',
|
|
]))
|
|
->actingAs($user)
|
|
->test(FindingsIntakeQueue::class)
|
|
->assertSet('tableFilters.managed_environment_id.value', (string) $tenant->getKey())
|
|
->assertActionVisible('return_to_governance_inbox')
|
|
->assertCanSeeTableRecords([$finding])
|
|
->assertSee('Shared unassigned work')
|
|
->assertDontSee('This workspace decision surface routes you');
|
|
});
|