ahmido
d644265d30
## Summary - extract baseline compare orchestration behind an explicit strategy contract and registry - preserve the current Intune compare path through a dedicated `IntuneCompareStrategy` - harden compare launch and review surfaces for mixed, unsupported, incomplete, and strategy-failure truth - add Spec 203 artifacts, focused regression coverage, and future-domain strategy proof tests ## Testing - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Unit/Baselines/CompareStrategyRegistryTest.php tests/Unit/Baselines/CompareSubjectResultContractTest.php tests/Feature/Baselines/BaselineCompareStrategySelectionTest.php tests/Feature/Baselines/BaselineComparePreconditionsTest.php tests/Feature/Baselines/BaselineCompareExecutionGuardTest.php tests/Feature/Baselines/BaselineCompareMatrixCompareAllActionTest.php tests/Feature/Filament/BaselineProfileCompareStartSurfaceTest.php tests/Feature/Filament/BaselineCompareLandingStartSurfaceTest.php tests/Feature/Filament/BaselineCompareLandingWhyNoFindingsTest.php tests/Feature/Filament/BaselineCompareMatrixPageTest.php tests/Feature/Filament/OperationRunBaselineTruthSurfaceTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Notes - no new Filament panel/provider registration changes - no global-search resource changes - no new asset registration or deployment step changes Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #233
82 lines
3.0 KiB
PHP
82 lines
3.0 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Support\Baselines\Compare;
|
|
|
|
use InvalidArgumentException;
|
|
|
|
final class CompareOrchestrationContext
|
|
{
|
|
/**
|
|
* @param array<string, mixed> $normalizedScope
|
|
* @param array<string, mixed> $coverageContext
|
|
* @param array<string, mixed> $launchContext
|
|
*/
|
|
public function __construct(
|
|
public readonly int $workspaceId,
|
|
public readonly int $tenantId,
|
|
public readonly int $baselineProfileId,
|
|
public readonly int $baselineSnapshotId,
|
|
public readonly int $operationRunId,
|
|
public readonly array $normalizedScope,
|
|
public readonly CompareStrategySelection $strategySelection,
|
|
public readonly array $coverageContext = [],
|
|
public readonly array $launchContext = [],
|
|
) {
|
|
if ($this->workspaceId <= 0 || $this->tenantId <= 0 || $this->baselineProfileId <= 0 || $this->baselineSnapshotId <= 0 || $this->operationRunId <= 0) {
|
|
throw new InvalidArgumentException('Compare orchestration contexts require positive workspace, tenant, profile, snapshot, and operation run identifiers.');
|
|
}
|
|
}
|
|
|
|
public function strategyKey(): CompareStrategyKey
|
|
{
|
|
if (! $this->strategySelection->strategyKey instanceof CompareStrategyKey) {
|
|
throw new InvalidArgumentException('Compare orchestration context requires a supported strategy selection before execution.');
|
|
}
|
|
|
|
return $this->strategySelection->strategyKey;
|
|
}
|
|
|
|
public function inventorySyncRunId(): ?int
|
|
{
|
|
$value = $this->coverageContext['inventory_sync_run_id'] ?? $this->launchContext['inventory_sync_run_id'] ?? null;
|
|
|
|
return is_numeric($value) ? (int) $value : null;
|
|
}
|
|
|
|
/**
|
|
* @return array{
|
|
* workspace_id: int,
|
|
* tenant_id: int,
|
|
* baseline_profile_id: int,
|
|
* baseline_snapshot_id: int,
|
|
* operation_run_id: int,
|
|
* normalized_scope: array<string, mixed>,
|
|
* strategy_selection: array{
|
|
* selection_state: string,
|
|
* strategy_key: ?string,
|
|
* matched_scope_entries: list<array<string, mixed>>,
|
|
* rejected_scope_entries: list<array<string, mixed>>,
|
|
* operator_reason: string,
|
|
* diagnostics: array<string, mixed>
|
|
* },
|
|
* coverage_context: array<string, mixed>,
|
|
* launch_context: array<string, mixed>
|
|
* }
|
|
*/
|
|
public function toArray(): array
|
|
{
|
|
return [
|
|
'workspace_id' => $this->workspaceId,
|
|
'tenant_id' => $this->tenantId,
|
|
'baseline_profile_id' => $this->baselineProfileId,
|
|
'baseline_snapshot_id' => $this->baselineSnapshotId,
|
|
'operation_run_id' => $this->operationRunId,
|
|
'normalized_scope' => $this->normalizedScope,
|
|
'strategy_selection' => $this->strategySelection->toArray(),
|
|
'coverage_context' => $this->coverageContext,
|
|
'launch_context' => $this->launchContext,
|
|
];
|
|
}
|
|
} |