TenantAtlas/apps/platform/app/Support/Baselines/Compare/CompareStrategyRegistry.php
ahmido d644265d30 Spec 203: extract baseline compare strategy (#233)
## Summary
- extract baseline compare orchestration behind an explicit strategy contract and registry
- preserve the current Intune compare path through a dedicated `IntuneCompareStrategy`
- harden compare launch and review surfaces for mixed, unsupported, incomplete, and strategy-failure truth
- add Spec 203 artifacts, focused regression coverage, and future-domain strategy proof tests

## Testing
- `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Unit/Baselines/CompareStrategyRegistryTest.php tests/Unit/Baselines/CompareSubjectResultContractTest.php tests/Feature/Baselines/BaselineCompareStrategySelectionTest.php tests/Feature/Baselines/BaselineComparePreconditionsTest.php tests/Feature/Baselines/BaselineCompareExecutionGuardTest.php tests/Feature/Baselines/BaselineCompareMatrixCompareAllActionTest.php tests/Feature/Filament/BaselineProfileCompareStartSurfaceTest.php tests/Feature/Filament/BaselineCompareLandingStartSurfaceTest.php tests/Feature/Filament/BaselineCompareLandingWhyNoFindingsTest.php tests/Feature/Filament/BaselineCompareMatrixPageTest.php tests/Feature/Filament/OperationRunBaselineTruthSurfaceTest.php`
- `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent`

## Notes
- no new Filament panel/provider registration changes
- no global-search resource changes
- no new asset registration or deployment step changes

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #233
2026-04-13 21:17:04 +00:00

202 lines
6.0 KiB
PHP

<?php
declare(strict_types=1);
namespace App\Support\Baselines\Compare;
use App\Support\Baselines\BaselineScope;
use App\Support\Governance\GovernanceDomainKey;
use App\Support\Governance\GovernanceSubjectClass;
use InvalidArgumentException;
final class CompareStrategyRegistry
{
/**
* @param list<CompareStrategy> $strategies
*/
public function __construct(
private readonly array $strategies = [],
) {}
/**
* @return list<CompareStrategy>
*/
public function all(): array
{
if ($this->strategies !== []) {
return $this->strategies;
}
return [app(IntuneCompareStrategy::class)];
}
public function find(CompareStrategyKey|string|null $strategyKey): ?CompareStrategy
{
if ($strategyKey === null) {
return null;
}
$normalizedKey = CompareStrategyKey::from($strategyKey);
foreach ($this->all() as $strategy) {
if ($strategy->key()->equals($normalizedKey)) {
return $strategy;
}
}
return null;
}
public function resolve(CompareStrategyKey|string $strategyKey): CompareStrategy
{
$strategy = $this->find($strategyKey);
if ($strategy instanceof CompareStrategy) {
return $strategy;
}
throw new InvalidArgumentException('Unknown compare strategy ['.CompareStrategyKey::from($strategyKey)->value.'].');
}
public function select(BaselineScope $scope): CompareStrategySelection
{
$entries = $this->entriesForScope($scope);
if ($entries === []) {
return CompareStrategySelection::unsupported(
matchedScopeEntries: [],
rejectedScopeEntries: [],
diagnostics: [],
operatorReason: 'No governed subjects were selected for compare.',
);
}
$matchedScopeEntries = [];
$rejectedScopeEntries = [];
$matchedStrategyKeys = [];
$entryMatches = [];
foreach ($entries as $entry) {
$matchingKeys = $this->matchingStrategyKeysForEntry($entry);
$entryFingerprint = $this->entryFingerprint($entry);
$entryMatches[$entryFingerprint] = $matchingKeys;
if ($matchingKeys === []) {
$rejectedScopeEntries[] = $entry;
continue;
}
$matchedScopeEntries[] = $entry;
$matchedStrategyKeys = array_values(array_unique(array_merge($matchedStrategyKeys, $matchingKeys)));
}
sort($matchedStrategyKeys, SORT_STRING);
if ($rejectedScopeEntries !== []) {
return CompareStrategySelection::unsupported(
matchedScopeEntries: $matchedScopeEntries,
rejectedScopeEntries: $rejectedScopeEntries,
diagnostics: [
'matched_strategy_keys' => $matchedStrategyKeys,
'entry_matches' => $entryMatches,
],
);
}
if (count($matchedStrategyKeys) !== 1) {
return CompareStrategySelection::mixed(
matchedScopeEntries: $matchedScopeEntries,
diagnostics: [
'matched_strategy_keys' => $matchedStrategyKeys,
'entry_matches' => $entryMatches,
],
);
}
return CompareStrategySelection::supported(
strategyKey: $matchedStrategyKeys[0],
matchedScopeEntries: $matchedScopeEntries,
diagnostics: [
'matched_strategy_keys' => $matchedStrategyKeys,
'entry_matches' => $entryMatches,
],
);
}
/**
* @param array{domain_key?: mixed, subject_class?: mixed, subject_type_keys?: mixed, filters?: mixed} $entry
* @return list<string>
*/
private function matchingStrategyKeysForEntry(array $entry): array
{
$matches = [];
foreach ($this->all() as $strategy) {
foreach ($strategy->capabilities() as $capability) {
if (! $capability->supportsEntry($entry)) {
continue;
}
$matches[] = $strategy->key()->value;
break;
}
}
$matches = array_values(array_unique($matches));
sort($matches, SORT_STRING);
return $matches;
}
/**
* @return list<array{domain_key: string, subject_class: string, subject_type_keys: list<string>, filters: array<string, mixed>}>
*/
private function entriesForScope(BaselineScope $scope): array
{
if ($scope->entries !== []) {
return $scope->entries;
}
$entries = [];
if ($scope->policyTypes !== []) {
$entries[] = [
'domain_key' => GovernanceDomainKey::Intune->value,
'subject_class' => GovernanceSubjectClass::Policy->value,
'subject_type_keys' => $scope->policyTypes,
'filters' => [],
];
}
if ($scope->foundationTypes !== []) {
$entries[] = [
'domain_key' => GovernanceDomainKey::PlatformFoundation->value,
'subject_class' => GovernanceSubjectClass::ConfigurationResource->value,
'subject_type_keys' => $scope->foundationTypes,
'filters' => [],
];
}
return $entries;
}
/**
* @param array{domain_key?: mixed, subject_class?: mixed, subject_type_keys?: mixed, filters?: mixed} $entry
*/
private function entryFingerprint(array $entry): string
{
$subjectTypeKeys = is_array($entry['subject_type_keys'] ?? null)
? array_values(array_filter($entry['subject_type_keys'], 'is_string'))
: [];
sort($subjectTypeKeys, SORT_STRING);
return implode('|', [
trim((string) ($entry['domain_key'] ?? '')),
trim((string) ($entry['subject_class'] ?? '')),
implode(',', $subjectTypeKeys),
]);
}
}