ahmido
ad16eee591
## Summary - add the Spec 204 platform vocabulary foundation, including canonical glossary terms, registry ownership descriptors, canonical operation type and alias resolution, and explicit reason ownership and platform reason-family metadata - harden platform-facing compare, snapshot, evidence, monitoring, review, and reporting surfaces so they prefer governed-subject and canonical operation semantics while preserving intentional Intune-owned terminology - extend Spec 204 unit, feature, Filament, and architecture coverage and add the full spec artifacts, checklist, and completed task ledger ## Verification - ran the focused recent-change Sail verification pack for the new glossary and reason-semantics work - ran the full Spec 204 quickstart verification pack under Sail - ran `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - ran an integrated-browser smoke pass covering tenant dashboard, operations, operation detail, baseline compare, evidence, reviews, review packs, provider connections, inventory items, backup schedules, onboarding, and the system dashboard/operations/failures/run-detail surfaces ## Notes - provider registration is unchanged and remains in `bootstrap/providers.php` - no new destructive actions or asset-registration changes are introduced by this branch Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #234
65 lines
2.8 KiB
PHP
65 lines
2.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Support\ReasonTranslation\FallbackReasonTranslator;
|
|
use App\Support\ReasonTranslation\NextStepOption;
|
|
use App\Support\ReasonTranslation\PlatformReasonFamily;
|
|
use App\Support\ReasonTranslation\ReasonOwnershipDescriptor;
|
|
use App\Support\ReasonTranslation\ReasonResolutionEnvelope;
|
|
|
|
it('renders body lines and legacy next steps from the shared envelope', function (): void {
|
|
$envelope = new ReasonResolutionEnvelope(
|
|
internalCode: 'provider_consent_missing',
|
|
operatorLabel: 'Admin consent required',
|
|
shortExplanation: 'The provider connection cannot continue until admin consent is granted.',
|
|
actionability: 'prerequisite_missing',
|
|
nextSteps: [
|
|
NextStepOption::link('Grant admin consent', 'https://example.test/admin-consent'),
|
|
],
|
|
);
|
|
|
|
expect($envelope->toBodyLines())->toBe([
|
|
'Admin consent required',
|
|
'The provider connection cannot continue until admin consent is granted.',
|
|
'Next step: Grant admin consent.',
|
|
])->and($envelope->toLegacyNextSteps())->toBe([
|
|
[
|
|
'label' => 'Grant admin consent',
|
|
'url' => 'https://example.test/admin-consent',
|
|
],
|
|
]);
|
|
});
|
|
|
|
it('builds understandable fallback translations without exposing raw codes as operator labels', function (): void {
|
|
$envelope = app(FallbackReasonTranslator::class)->translate('custom_retry_timeout');
|
|
|
|
expect($envelope)->not->toBeNull()
|
|
->and($envelope?->operatorLabel)->toBe('Custom Retry Timeout')
|
|
->and($envelope?->operatorLabel)->not->toBe('custom_retry_timeout')
|
|
->and($envelope?->shortExplanation)->toContain('transient dependency issue')
|
|
->and($envelope?->guidanceText())->toBe('Next step: Retry after the dependency recovers.');
|
|
});
|
|
|
|
it('round-trips explicit reason ownership and platform-family metadata', function (): void {
|
|
$envelope = new ReasonResolutionEnvelope(
|
|
internalCode: 'provider_consent_missing',
|
|
operatorLabel: 'Admin consent required',
|
|
shortExplanation: 'The provider connection cannot continue until admin consent is granted.',
|
|
actionability: 'prerequisite_missing',
|
|
reasonOwnership: new ReasonOwnershipDescriptor(
|
|
ownerLayer: 'provider_owned',
|
|
ownerNamespace: 'provider.microsoft_graph',
|
|
reasonCode: 'provider_consent_missing',
|
|
platformReasonFamily: PlatformReasonFamily::Prerequisite,
|
|
),
|
|
);
|
|
|
|
$restored = ReasonResolutionEnvelope::fromArray($envelope->toArray());
|
|
|
|
expect($restored)->not->toBeNull()
|
|
->and($restored?->ownerLayer())->toBe('provider_owned')
|
|
->and($restored?->ownerNamespace())->toBe('provider.microsoft_graph')
|
|
->and($restored?->platformReasonFamily())->toBe(PlatformReasonFamily::Prerequisite->value);
|
|
});
|