ahmido
e64bae9cfc
## Summary - replace the legacy Tenant and TenantMembership core models with ManagedEnvironment and ManagedEnvironmentMembership - propagate the managed environment naming and key changes across Filament resources, pages, controllers, jobs, models, and supporting runtime paths - add feature 279 spec artifacts and focused managed-environment test coverage for model behavior, route binding, panel context, authorization, and legacy guardrails ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ManagedEnvironment/LegacyTenantCoreGuardTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentAuthorizationTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentPanelContextTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentRouteBindingTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentContextResolverTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentModelTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Notes - branch pushed from commit `1123b122` - browser smoke test file was added but not run in this pass Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #335
114 lines
3.4 KiB
PHP
114 lines
3.4 KiB
PHP
<?php
|
|
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Services\Intune\TenantRequiredPermissionsViewModelBuilder;
|
|
|
|
it('builds copy payload as newline-separated missing permissions for the selected type', function (): void {
|
|
$rows = [
|
|
[
|
|
'key' => 'DeviceManagementApps.Read.All',
|
|
'type' => 'application',
|
|
'description' => null,
|
|
'features' => ['backup'],
|
|
'status' => 'missing',
|
|
'details' => null,
|
|
],
|
|
[
|
|
'key' => 'DeviceManagementApps.ReadWrite.All',
|
|
'type' => 'application',
|
|
'description' => null,
|
|
'features' => ['backup'],
|
|
'status' => 'granted',
|
|
'details' => null,
|
|
],
|
|
[
|
|
'key' => 'Group.Read.All',
|
|
'type' => 'delegated',
|
|
'description' => null,
|
|
'features' => ['directory-groups'],
|
|
'status' => 'missing',
|
|
'details' => null,
|
|
],
|
|
[
|
|
'key' => 'Policy.Read.All',
|
|
'type' => 'application',
|
|
'description' => null,
|
|
'features' => ['conditional-access'],
|
|
'status' => 'missing',
|
|
'details' => null,
|
|
],
|
|
];
|
|
|
|
$payload = TenantRequiredPermissionsViewModelBuilder::deriveCopyPayload($rows, 'application');
|
|
|
|
expect($payload)->toBe(implode("\n", [
|
|
'DeviceManagementApps.Read.All',
|
|
'Policy.Read.All',
|
|
]));
|
|
});
|
|
|
|
it('respects the feature filter for copy payload', function (): void {
|
|
$rows = [
|
|
[
|
|
'key' => 'A',
|
|
'type' => 'delegated',
|
|
'description' => null,
|
|
'features' => ['f1', 'f2'],
|
|
'status' => 'missing',
|
|
'details' => null,
|
|
],
|
|
[
|
|
'key' => 'B',
|
|
'type' => 'delegated',
|
|
'description' => null,
|
|
'features' => ['f2'],
|
|
'status' => 'missing',
|
|
'details' => null,
|
|
],
|
|
[
|
|
'key' => 'C',
|
|
'type' => 'delegated',
|
|
'description' => null,
|
|
'features' => ['f3'],
|
|
'status' => 'missing',
|
|
'details' => null,
|
|
],
|
|
];
|
|
|
|
$payload = TenantRequiredPermissionsViewModelBuilder::deriveCopyPayload($rows, 'delegated', ['f2']);
|
|
|
|
expect($payload)->toBe(implode("\n", [
|
|
'A',
|
|
'B',
|
|
]));
|
|
});
|
|
|
|
it('ignores search terms for copy payload but respects the feature filter', function (): void {
|
|
$permissionService = \Mockery::mock(\App\Services\Intune\TenantPermissionService::class);
|
|
$permissionService->shouldReceive('compare')
|
|
->andReturn([
|
|
'overall_status' => 'missing',
|
|
'permissions' => [
|
|
[
|
|
'key' => 'Match.Me',
|
|
'type' => 'application',
|
|
'description' => 'Some description',
|
|
'features' => ['f1'],
|
|
'status' => 'missing',
|
|
'details' => null,
|
|
],
|
|
],
|
|
]);
|
|
|
|
$builder = new TenantRequiredPermissionsViewModelBuilder($permissionService);
|
|
$tenant = ManagedEnvironment::factory()->make(['external_id' => 'tenant-copy-a', 'name' => 'ManagedEnvironment']);
|
|
|
|
$vm = $builder->build($tenant, [
|
|
'features' => ['f1'],
|
|
'search' => 'does not match',
|
|
]);
|
|
|
|
expect($vm['permissions'])->toBeEmpty();
|
|
expect($vm['copy']['application'])->toBe('Match.Me');
|
|
});
|