TenantAtlas/apps/platform/app/Policies/ProviderConnectionPolicy.php
ahmido c7b38606a9 feat: implement spec 285 workspace-first environment access (#344)
Implements platform feature branch `285-workspace-rbac-environment-access`.

Summary:
- switch managed environment authorization to workspace-first role resolution with explicit environment-scope narrowing
- rewire Filament pages, resources, policies, and user tenant access helpers to the shared access-scope resolver
- add Spec 285 coverage across unit, feature, and browser tests plus full spec artifacts

Validation:
- `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Unit/Auth/WorkspaceFirstCapabilityResolverTest.php tests/Unit/Auth/ManagedEnvironmentAccessScopeResolverTest.php`
- `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Auth/WorkspaceFirstManagedEnvironmentAccessTest.php tests/Feature/Filament/ManagedEnvironmentAccessScopeManagementTest.php tests/Feature/Filament/WorkspaceMembershipRoleManagementTest.php tests/Feature/Rbac/GovernanceArtifactsWorkspaceFirstAuthorizationTest.php tests/Feature/Rbac/OperationRunWorkspaceFirstAuthorizationTest.php tests/Feature/Rbac/ProviderConnectionWorkspaceFirstPolicyTest.php`
- `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Verification/ProviderExecutionReauthorizationTest.php tests/Feature/ProviderConnections/ProviderConnectionHealthCheckStartSurfaceTest.php tests/Feature/Tenants/TenantProviderBackedActionStartTest.php`
- `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Audit/TenantMembershipAuditLogTest.php tests/Feature/Filament/TenantMembersTest.php tests/Feature/TenantRBAC/TenantMembershipCrudTest.php tests/Feature/TenantRBAC/TenantSwitcherScopeTest.php`
- `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php`
- `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent`

Target branch: `platform-dev`.

Follow-up integration path after merge:
- `platform-dev` -> `dev`.

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #344
2026-05-09 12:40:50 +00:00

285 lines
8.7 KiB
PHP

<?php
namespace App\Policies;
use App\Models\ProviderConnection;
use App\Models\ManagedEnvironment;
use App\Models\User;
use App\Models\Workspace;
use App\Services\Auth\ManagedEnvironmentAccessScopeResolver;
use App\Support\Auth\Capabilities;
use App\Support\Workspaces\WorkspaceContext;
use Filament\Facades\Filament;
use Illuminate\Auth\Access\HandlesAuthorization;
use Illuminate\Auth\Access\Response;
use Illuminate\Support\Facades\Gate;
class ProviderConnectionPolicy
{
use HandlesAuthorization;
public function viewAny(User $user): Response|bool
{
$workspace = $this->currentWorkspace($user);
if (! $workspace instanceof Workspace) {
return Response::denyAsNotFound();
}
/** @var ManagedEnvironmentAccessScopeResolver $scopeResolver */
$scopeResolver = app(ManagedEnvironmentAccessScopeResolver::class);
$entitledTenantsQuery = ManagedEnvironment::query()
->where('managed_environments.workspace_id', (int) $workspace->getKey());
$scopeResolver->applyWorkspaceScopeToQuery(
query: $entitledTenantsQuery,
user: $user,
workspaceId: (int) $workspace->getKey(),
qualifiedEnvironmentColumn: 'managed_environments.id',
);
$entitledTenants = $entitledTenantsQuery->get();
if ($entitledTenants->isEmpty()) {
return true;
}
foreach ($entitledTenants as $tenant) {
if (Gate::forUser($user)->allows(Capabilities::PROVIDER_VIEW, $tenant)) {
return true;
}
}
return false;
}
public function view(User $user, ProviderConnection $connection): Response|bool
{
$workspace = $this->currentWorkspace($user);
if (! $workspace instanceof Workspace) {
return Response::denyAsNotFound();
}
$tenant = $this->tenantForConnection($connection);
if (! $tenant instanceof ManagedEnvironment || (int) $tenant->workspace_id !== (int) $workspace->getKey()) {
return Response::denyAsNotFound();
}
if (! $this->isTenantMember($user, $tenant)) {
return Response::denyAsNotFound();
}
if (! Gate::forUser($user)->allows(Capabilities::PROVIDER_VIEW, $tenant)) {
return false;
}
if ((int) $connection->managed_environment_id !== (int) $tenant->getKey()) {
return Response::denyAsNotFound();
}
if ((int) $connection->workspace_id !== (int) $workspace->getKey()) {
return Response::denyAsNotFound();
}
return true;
}
public function create(User $user): Response|bool
{
$workspace = $this->currentWorkspace($user);
if (! $workspace instanceof Workspace) {
return Response::denyAsNotFound();
}
$tenant = $this->resolveCreateTenant($workspace);
if (! $tenant instanceof ManagedEnvironment || ! $this->isTenantMember($user, $tenant)) {
return Response::denyAsNotFound();
}
if (! Gate::forUser($user)->allows(Capabilities::PROVIDER_MANAGE, $tenant)) {
return false;
}
return true;
}
public function update(User $user, ProviderConnection $connection): Response|bool
{
$workspace = $this->currentWorkspace($user);
if (! $workspace instanceof Workspace) {
return Response::denyAsNotFound();
}
$tenant = $this->tenantForConnection($connection);
if (! $tenant instanceof ManagedEnvironment || (int) $tenant->workspace_id !== (int) $workspace->getKey()) {
return Response::denyAsNotFound();
}
if (! $this->isTenantMember($user, $tenant)) {
return Response::denyAsNotFound();
}
if (! Gate::forUser($user)->allows(Capabilities::PROVIDER_MANAGE, $tenant)) {
return false;
}
if ((int) $connection->managed_environment_id !== (int) $tenant->getKey()) {
return Response::denyAsNotFound();
}
if ((int) $connection->workspace_id !== (int) $workspace->getKey()) {
return Response::denyAsNotFound();
}
return true;
}
public function delete(User $user, ProviderConnection $connection): Response|bool
{
$workspace = $this->currentWorkspace($user);
if (! $workspace instanceof Workspace) {
return Response::denyAsNotFound();
}
$tenant = $this->tenantForConnection($connection);
if (! $tenant instanceof ManagedEnvironment || (int) $tenant->workspace_id !== (int) $workspace->getKey()) {
return Response::denyAsNotFound();
}
if (! $this->isTenantMember($user, $tenant)) {
return Response::denyAsNotFound();
}
if (! Gate::forUser($user)->allows(Capabilities::PROVIDER_MANAGE, $tenant)) {
return false;
}
if ((int) $connection->managed_environment_id !== (int) $tenant->getKey()) {
return Response::denyAsNotFound();
}
if ((int) $connection->workspace_id !== (int) $workspace->getKey()) {
return Response::denyAsNotFound();
}
return true;
}
public function manageDedicated(User $user, ProviderConnection $connection): Response|bool
{
$baseAccess = $this->update($user, $connection);
if ($baseAccess !== true) {
return $baseAccess;
}
$tenant = $this->tenantForConnection($connection);
if (! $tenant instanceof ManagedEnvironment) {
return Response::denyAsNotFound();
}
return Gate::forUser($user)->allows(Capabilities::PROVIDER_MANAGE_DEDICATED, $tenant);
}
public function changeConnectionType(User $user, ProviderConnection $connection): Response|bool
{
return $this->manageDedicated($user, $connection);
}
public function manageDedicatedCredential(User $user, ProviderConnection $connection): Response|bool
{
return $this->manageDedicated($user, $connection);
}
public function deleteDedicatedCredential(User $user, ProviderConnection $connection): Response|bool
{
return $this->manageDedicated($user, $connection);
}
private function currentWorkspace(User $user): ?Workspace
{
$workspaceId = app(WorkspaceContext::class)->currentWorkspaceId(request());
if (! is_int($workspaceId)) {
$filamentTenant = Filament::getTenant();
if ($filamentTenant instanceof ManagedEnvironment) {
$workspaceId = (int) $filamentTenant->workspace_id;
}
}
if (! is_int($workspaceId)) {
return null;
}
$workspace = Workspace::query()->whereKey($workspaceId)->first();
if (! $workspace instanceof Workspace) {
return null;
}
if (! app(WorkspaceContext::class)->isMember($user, $workspace)) {
return null;
}
return $workspace;
}
private function resolveCreateTenant(Workspace $workspace): ?ManagedEnvironment
{
$tenantExternalId = request()->query('managed_environment_id');
if (! is_string($tenantExternalId) || $tenantExternalId === '') {
$lastTenantId = app(WorkspaceContext::class)->lastTenantId(request());
if (is_int($lastTenantId)) {
return ManagedEnvironment::query()
->whereKey($lastTenantId)
->where('workspace_id', (int) $workspace->getKey())
->first();
}
$filamentTenant = Filament::getTenant();
if ($filamentTenant instanceof ManagedEnvironment && (int) $filamentTenant->workspace_id === (int) $workspace->getKey()) {
return $filamentTenant;
}
return null;
}
return ManagedEnvironment::query()
->where('slug', $tenantExternalId)
->where('workspace_id', (int) $workspace->getKey())
->first();
}
private function tenantForConnection(ProviderConnection $connection): ?ManagedEnvironment
{
if ($connection->relationLoaded('tenant') && $connection->tenant instanceof ManagedEnvironment) {
return $connection->tenant;
}
if (is_int($connection->managed_environment_id) || is_numeric($connection->managed_environment_id)) {
return ManagedEnvironment::query()->whereKey((int) $connection->managed_environment_id)->first();
}
return null;
}
private function isTenantMember(User $user, ManagedEnvironment $tenant): bool
{
return app(ManagedEnvironmentAccessScopeResolver::class)->canAccess($user, $tenant);
}
}