Implements platform feature branch `285-workspace-rbac-environment-access`. Summary: - switch managed environment authorization to workspace-first role resolution with explicit environment-scope narrowing - rewire Filament pages, resources, policies, and user tenant access helpers to the shared access-scope resolver - add Spec 285 coverage across unit, feature, and browser tests plus full spec artifacts Validation: - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Unit/Auth/WorkspaceFirstCapabilityResolverTest.php tests/Unit/Auth/ManagedEnvironmentAccessScopeResolverTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Auth/WorkspaceFirstManagedEnvironmentAccessTest.php tests/Feature/Filament/ManagedEnvironmentAccessScopeManagementTest.php tests/Feature/Filament/WorkspaceMembershipRoleManagementTest.php tests/Feature/Rbac/GovernanceArtifactsWorkspaceFirstAuthorizationTest.php tests/Feature/Rbac/OperationRunWorkspaceFirstAuthorizationTest.php tests/Feature/Rbac/ProviderConnectionWorkspaceFirstPolicyTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Verification/ProviderExecutionReauthorizationTest.php tests/Feature/ProviderConnections/ProviderConnectionHealthCheckStartSurfaceTest.php tests/Feature/Tenants/TenantProviderBackedActionStartTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Audit/TenantMembershipAuditLogTest.php tests/Feature/Filament/TenantMembersTest.php tests/Feature/TenantRBAC/TenantMembershipCrudTest.php tests/Feature/TenantRBAC/TenantSwitcherScopeTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` Target branch: `platform-dev`. Follow-up integration path after merge: - `platform-dev` -> `dev`. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #344
148 lines
4.7 KiB
PHP
148 lines
4.7 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Policies;
|
|
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Models\TenantOnboardingSession;
|
|
use App\Models\User;
|
|
use App\Models\Workspace;
|
|
use App\Services\Auth\WorkspaceCapabilityResolver;
|
|
use App\Services\Tenants\TenantOperabilityService;
|
|
use App\Support\Auth\Capabilities;
|
|
use App\Support\Tenants\TenantInteractionLane;
|
|
use App\Support\Tenants\TenantOperabilityQuestion;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Illuminate\Auth\Access\Response;
|
|
use Illuminate\Support\Facades\Gate;
|
|
|
|
class TenantOnboardingSessionPolicy
|
|
{
|
|
public function viewAny(User $user): bool|Response
|
|
{
|
|
$workspace = $this->currentWorkspace($user);
|
|
|
|
if (! $workspace instanceof Workspace) {
|
|
return Response::denyAsNotFound();
|
|
}
|
|
|
|
return $this->authorizeForWorkspace($user, $workspace, Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD);
|
|
}
|
|
|
|
public function view(User $user, TenantOnboardingSession $tenantOnboardingSession): bool|Response
|
|
{
|
|
return $this->authorizeForDraft(
|
|
user: $user,
|
|
tenantOnboardingSession: $tenantOnboardingSession,
|
|
capability: Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD,
|
|
);
|
|
}
|
|
|
|
public function update(User $user, TenantOnboardingSession $tenantOnboardingSession): bool|Response
|
|
{
|
|
return $this->authorizeForDraft(
|
|
user: $user,
|
|
tenantOnboardingSession: $tenantOnboardingSession,
|
|
capability: Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD,
|
|
);
|
|
}
|
|
|
|
public function cancel(User $user, TenantOnboardingSession $tenantOnboardingSession): bool|Response
|
|
{
|
|
return $this->authorizeForDraft(
|
|
user: $user,
|
|
tenantOnboardingSession: $tenantOnboardingSession,
|
|
capability: Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD_CANCEL,
|
|
);
|
|
}
|
|
|
|
private function currentWorkspace(User $user): ?Workspace
|
|
{
|
|
$workspaceId = app(WorkspaceContext::class)->currentWorkspaceId(request());
|
|
|
|
if (! is_int($workspaceId)) {
|
|
return null;
|
|
}
|
|
|
|
$workspace = Workspace::query()->whereKey($workspaceId)->first();
|
|
|
|
if (! $workspace instanceof Workspace) {
|
|
return null;
|
|
}
|
|
|
|
/** @var WorkspaceCapabilityResolver $resolver */
|
|
$resolver = app(WorkspaceCapabilityResolver::class);
|
|
|
|
if (! $resolver->isMember($user, $workspace)) {
|
|
return null;
|
|
}
|
|
|
|
return $workspace;
|
|
}
|
|
|
|
private function authorizeForDraft(
|
|
User $user,
|
|
TenantOnboardingSession $tenantOnboardingSession,
|
|
string $capability,
|
|
): bool|Response {
|
|
$workspace = $this->currentWorkspace($user);
|
|
|
|
if (! $workspace instanceof Workspace) {
|
|
return Response::denyAsNotFound();
|
|
}
|
|
|
|
if ((int) $tenantOnboardingSession->workspace_id !== (int) $workspace->getKey()) {
|
|
return Response::denyAsNotFound();
|
|
}
|
|
|
|
$tenant = $tenantOnboardingSession->tenant;
|
|
|
|
if ($tenant instanceof ManagedEnvironment) {
|
|
if ((int) $tenant->workspace_id !== (int) $workspace->getKey()) {
|
|
return Response::denyAsNotFound();
|
|
}
|
|
|
|
if (! $user->canAccessTenant($tenant)) {
|
|
return Response::denyAsNotFound();
|
|
}
|
|
|
|
$viewability = app(TenantOperabilityService::class)->outcomeFor(
|
|
tenant: $tenant,
|
|
question: TenantOperabilityQuestion::TenantBoundViewability,
|
|
actor: $user,
|
|
workspaceId: (int) $workspace->getKey(),
|
|
lane: TenantInteractionLane::AdministrativeManagement,
|
|
);
|
|
|
|
if (! $viewability->allowed) {
|
|
return Response::denyAsNotFound();
|
|
}
|
|
}
|
|
|
|
return $this->authorizeForWorkspace($user, $workspace, $capability);
|
|
}
|
|
|
|
private function authorizeForWorkspace(User $user, Workspace $workspace, string $capability): bool|Response
|
|
{
|
|
/** @var WorkspaceCapabilityResolver $resolver */
|
|
$resolver = app(WorkspaceCapabilityResolver::class);
|
|
|
|
if (! $resolver->isMember($user, $workspace)) {
|
|
return Response::denyAsNotFound();
|
|
}
|
|
|
|
return Gate::forUser($user)->allows($capability, $workspace)
|
|
? Response::allow()
|
|
: Response::deny($this->forbiddenCapabilityMessage($capability));
|
|
}
|
|
|
|
private function forbiddenCapabilityMessage(string $capability): string
|
|
{
|
|
return match ($capability) {
|
|
Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD_CANCEL => 'You do not have permission to cancel this onboarding draft.',
|
|
default => 'You do not have permission to continue this onboarding draft.',
|
|
};
|
|
}
|
|
}
|