TenantAtlas/apps/platform/tests/Feature/TenantRBAC/TenantSwitcherScopeTest.php
ahmido aeef285d1d feat: implement spec 286 UI copy, IA & localization neutralization (#345)
## Summary

Implements feature branch `286-ui-copy-ia-localization-neutralization`.

This change set:
- aligns chooser, managed-environment landing, dashboard, shell, and workspace context copy to environment-first terminology
- neutralizes the bounded policy and baseline helper copy called out by Spec 286
- adds focused feature, guard, and browser coverage plus the complete Spec 286 artifact set
- records the discovered `Capture snapshot` modal issue as out-of-scope runtime debt in the Spec 286 close-out notes

## Validation

- `export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Localization/EnvironmentContextTerminologyTest.php tests/Feature/Filament/EnvironmentContextSurfaceCopyTest.php tests/Feature/Filament/Localization/PolicyInventoryLocalizationTest.php tests/Feature/Guards/EnvironmentCopyNeutralizationGuardTest.php`
- `export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec286EnvironmentCopyNeutralizationSmokeTest.php`
- `export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent`

## Notes

- Target branch: `platform-dev`
- Filament remains on v5 with Livewire v4.
- Provider registration remains unchanged in `apps/platform/bootstrap/providers.php`.
- No new destructive actions, asset strategy changes, or global-search posture changes are introduced in this slice.

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #345
2026-05-09 23:29:11 +00:00

159 lines
6.0 KiB
PHP

<?php
declare(strict_types=1);
use App\Filament\Pages\ChooseTenant;
use App\Filament\Resources\TenantResource;
use App\Models\ManagedEnvironment;
use App\Models\User;
use App\Models\WorkspaceMembership;
use App\Support\Workspaces\WorkspaceContext;
use Filament\Facades\Filament;
use Filament\PanelRegistry;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Livewire\Livewire;
uses(RefreshDatabase::class);
it('only returns active membership tenants for normal users', function (): void {
$user = User::factory()->create();
$allowed = ManagedEnvironment::factory()->active()->create(['name' => 'Allowed']);
$onboarding = ManagedEnvironment::factory()->onboarding()->create([
'workspace_id' => (int) $allowed->workspace_id,
'name' => 'Onboarding',
]);
$archived = ManagedEnvironment::factory()->archived()->create([
'workspace_id' => (int) $allowed->workspace_id,
'name' => 'Archived',
]);
WorkspaceMembership::factory()->create([
'workspace_id' => (int) $allowed->workspace_id,
'user_id' => (int) $user->getKey(),
'role' => 'readonly',
]);
session()->put(WorkspaceContext::SESSION_KEY, (int) $allowed->workspace_id);
/** @var \Filament\Panel $panel */
$panel = app(PanelRegistry::class)->get('admin');
$tenants = $user->getTenants($panel);
expect($tenants)->toHaveCount(1);
expect($tenants->first()?->getKey())->toBe($allowed->getKey());
expect($tenants->contains(fn (ManagedEnvironment $tenant): bool => $tenant->name === 'Onboarding'))->toBeFalse();
expect($tenants->contains(fn (ManagedEnvironment $tenant): bool => $tenant->name === 'Archived'))->toBeFalse();
});
it('returns no tenants for users without active tenant memberships', function (): void {
$user = User::factory()->create();
$draft = ManagedEnvironment::factory()->draft()->create(['name' => 'Draft']);
$archived = ManagedEnvironment::factory()->archived()->create([
'workspace_id' => (int) $draft->workspace_id,
'name' => 'Archived',
]);
/** @var \Filament\Panel $panel */
$panel = app(PanelRegistry::class)->get('admin');
expect($user->getTenants($panel))->toHaveCount(0);
});
it('rejects selecting non-active memberships as tenant context', function (): void {
$user = User::factory()->create();
$active = ManagedEnvironment::factory()->active()->create(['name' => 'Allowed']);
$onboarding = ManagedEnvironment::factory()->onboarding()->create([
'workspace_id' => (int) $active->workspace_id,
'name' => 'Onboarding',
]);
$archived = ManagedEnvironment::factory()->archived()->create([
'workspace_id' => (int) $active->workspace_id,
'name' => 'Archived',
]);
WorkspaceMembership::factory()->create([
'workspace_id' => (int) $active->workspace_id,
'user_id' => (int) $user->getKey(),
'role' => 'readonly',
]);
session()->put(WorkspaceContext::SESSION_KEY, (int) $active->workspace_id);
Livewire::actingAs($user)
->test(ChooseTenant::class)
->call('selectTenant', $onboarding->getKey())
->assertStatus(404);
Livewire::actingAs($user)
->test(ChooseTenant::class)
->call('selectTenant', $archived->getKey())
->assertStatus(404);
});
it('keeps tenant global-search broader than selector eligibility when the user only has administratively discoverable memberships', function (): void {
$user = User::factory()->create();
$draft = ManagedEnvironment::factory()->draft()->create(['name' => 'Search Draft']);
$onboarding = ManagedEnvironment::factory()->onboarding()->create([
'workspace_id' => (int) $draft->workspace_id,
'name' => 'Search Onboarding',
]);
$archived = ManagedEnvironment::factory()->archived()->create([
'workspace_id' => (int) $draft->workspace_id,
'name' => 'Search Archived',
]);
WorkspaceMembership::factory()->create([
'workspace_id' => (int) $draft->workspace_id,
'user_id' => (int) $user->getKey(),
'role' => 'readonly',
]);
$this->actingAs($user);
Filament::setCurrentPanel('admin');
Filament::setTenant(null, true);
Filament::bootCurrentPanel();
session()->put(WorkspaceContext::SESSION_KEY, (int) $draft->workspace_id);
expect(TenantResource::getGlobalSearchResults('Search'))
->toHaveCount(3)
->sequence(
fn ($result) => $result->title->toContain('Search'),
fn ($result) => $result->title->toContain('Search'),
fn ($result) => $result->title->toContain('Search'),
);
});
it('does not render onboarding or archived tenants in the header selector on workspace pages', function (): void {
$activeTenant = ManagedEnvironment::factory()->active()->create(['name' => 'Header Active ManagedEnvironment']);
[$user, $activeTenant] = createUserWithTenant(tenant: $activeTenant, role: 'owner');
$onboardingTenant = ManagedEnvironment::factory()->onboarding()->create([
'workspace_id' => (int) $activeTenant->workspace_id,
'name' => 'Header Onboarding ManagedEnvironment',
]);
$archivedTenant = ManagedEnvironment::factory()->archived()->create([
'workspace_id' => (int) $activeTenant->workspace_id,
'name' => 'Header Archived ManagedEnvironment',
]);
createUserWithTenant(tenant: $onboardingTenant, user: $user, role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
createUserWithTenant(tenant: $archivedTenant, user: $user, role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
Filament::setTenant(null, true);
$this->actingAs($user)
->withSession([WorkspaceContext::SESSION_KEY => (int) $activeTenant->workspace_id])
->get(route('admin.operations.index', ['workspace' => $activeTenant->workspace]))
->assertSuccessful()
->assertSee('Header Active ManagedEnvironment')
->assertDontSee('Header Onboarding ManagedEnvironment')
->assertDontSee('Header Archived ManagedEnvironment')
->assertSee(__('localization.shell.no_environment_selected'));
});