ahmido
a449ecec5b
Beschreibung Implementiert das Drift MVP Feature (Spec: 044-drift-mvp) mit Fokus auf automatische Drift-Erkennung zwischen Inventory Sync Runs und Bulk-Triage für Findings. Was wurde implementiert? Drift-Erkennung: Vergleicht Policy-Snapshots, Assignments und Scope Tags zwischen Baseline- und Current-Runs. Deterministische Fingerprints verhindern Duplikate. Findings UI: Neue Filament Resource für Findings mit Listen- und Detail-Ansicht. DB-only Diffs (keine Graph-Calls zur Laufzeit). Bulk Acknowledge: "Acknowledge selected" (Bulk-Action auf der Liste) "Acknowledge all matching" (Header-Action, respektiert aktuelle Filter; Type-to-Confirm bei >100 Findings) Scope Tag Fix: Behebt False Positives bei Legacy-Daten ohne scope_tags.ids (inferiert Default-Werte). Authorization: Tenant-isoliert, Rollen-basiert (Owner/Manager/Operator können acknowledge). Tests: Vollständige Pest-Coverage (28 Tests, 347 Assertions) für Drift-Logik, UI und Bulk-Actions. Warum diese Änderungen? Problem: Keine automatisierte Drift-Erkennung; manuelle Triage bei vielen Findings ist mühsam. Lösung: Async Drift-Generierung mit persistenter Findings-Tabelle. Safe Bulk-Tools für Massen-Triage ohne Deletes. Konformität: Folgt AGENTS.md Workflow, Spec-Kit (Tasks + Checklists abgehakt), Laravel/Filament Best Practices. Technische Details Neue Dateien: ~40 (Models, Services, Tests, Views, Migrations) Änderungen: Filament Resources, Jobs, Policies DB: Neue findings Tabelle (JSONB für Evidence, Indexes für Performance) Tests: ./vendor/bin/sail artisan test tests/Feature/Drift --parallel → 28 passed Migration: ./vendor/bin/sail artisan migrate (neue Tabelle + Indexes) Screenshots / Links Spec: spec.md Tasks: tasks.md (alle abgehakt) UI: Findings-Liste mit Bulk-Actions; Detail-View mit Diffs Checklist Tests passieren (parallel + serial) Code formatiert (./vendor/bin/pint --dirty) Migration reversibel Tenant-Isolation enforced No Graph-Calls in Views Authorization checks Spec + Tasks aligned Deployment Notes Neue Migration: create_findings_table Neue Permissions: drift.view, drift.acknowledge Queue-Job: GenerateDriftFindingsJob (async, deduped)
101 lines
3.5 KiB
PHP
101 lines
3.5 KiB
PHP
<?php
|
|
|
|
use App\Filament\Resources\FindingResource;
|
|
use App\Models\Finding;
|
|
use App\Models\InventoryItem;
|
|
use App\Models\InventorySyncRun;
|
|
use App\Models\Policy;
|
|
use App\Models\PolicyVersion;
|
|
|
|
test('finding detail shows a normalized settings diff for policy_snapshot evidence', function () {
|
|
bindFailHardGraphClient();
|
|
|
|
[$user, $tenant] = createUserWithTenant(role: 'manager');
|
|
|
|
$baseline = InventorySyncRun::factory()->for($tenant)->create([
|
|
'selection_hash' => hash('sha256', 'scope-settings-diff'),
|
|
'status' => InventorySyncRun::STATUS_SUCCESS,
|
|
'finished_at' => now()->subDays(2),
|
|
]);
|
|
|
|
$current = InventorySyncRun::factory()->for($tenant)->create([
|
|
'selection_hash' => $baseline->selection_hash,
|
|
'status' => InventorySyncRun::STATUS_SUCCESS,
|
|
'finished_at' => now()->subDay(),
|
|
]);
|
|
|
|
$policy = Policy::factory()->for($tenant)->create([
|
|
'external_id' => 'policy-123',
|
|
'policy_type' => 'deviceConfiguration',
|
|
'platform' => 'windows10',
|
|
]);
|
|
|
|
$baselineVersion = PolicyVersion::factory()->for($tenant)->create([
|
|
'policy_id' => $policy->getKey(),
|
|
'version_number' => 1,
|
|
'policy_type' => $policy->policy_type,
|
|
'platform' => $policy->platform,
|
|
'captured_at' => $baseline->finished_at->copy()->subHour(),
|
|
'snapshot' => [
|
|
'displayName' => 'My Policy',
|
|
'description' => 'Old description',
|
|
'customSettingFoo' => 'Old value',
|
|
],
|
|
]);
|
|
|
|
$currentVersion = PolicyVersion::factory()->for($tenant)->create([
|
|
'policy_id' => $policy->getKey(),
|
|
'version_number' => 2,
|
|
'policy_type' => $policy->policy_type,
|
|
'platform' => $policy->platform,
|
|
'captured_at' => $current->finished_at->copy()->subHour(),
|
|
'snapshot' => [
|
|
'displayName' => 'My Policy',
|
|
'description' => 'New description',
|
|
'customSettingFoo' => 'New value',
|
|
],
|
|
]);
|
|
|
|
$finding = Finding::factory()->for($tenant)->create([
|
|
'finding_type' => Finding::FINDING_TYPE_DRIFT,
|
|
'scope_key' => (string) $current->selection_hash,
|
|
'baseline_run_id' => $baseline->getKey(),
|
|
'current_run_id' => $current->getKey(),
|
|
'subject_type' => 'policy',
|
|
'subject_external_id' => $policy->external_id,
|
|
'evidence_jsonb' => [
|
|
'change_type' => 'modified',
|
|
'summary' => [
|
|
'kind' => 'policy_snapshot',
|
|
'changed_fields' => ['snapshot_hash'],
|
|
],
|
|
'baseline' => [
|
|
'policy_id' => $policy->external_id,
|
|
'policy_version_id' => $baselineVersion->getKey(),
|
|
'snapshot_hash' => 'baseline-hash',
|
|
],
|
|
'current' => [
|
|
'policy_id' => $policy->external_id,
|
|
'policy_version_id' => $currentVersion->getKey(),
|
|
'snapshot_hash' => 'current-hash',
|
|
],
|
|
],
|
|
]);
|
|
|
|
InventoryItem::factory()->for($tenant)->create([
|
|
'external_id' => $finding->subject_external_id,
|
|
'display_name' => 'My Policy 123',
|
|
]);
|
|
|
|
$this->actingAs($user)
|
|
->get(FindingResource::getUrl('view', ['record' => $finding], tenant: $tenant))
|
|
->assertOk()
|
|
->assertSee('Normalized diff')
|
|
->assertSee('1 changed')
|
|
->assertSee('Custom Setting Foo')
|
|
->assertSee('From')
|
|
->assertSee('To')
|
|
->assertSee('Old value')
|
|
->assertSee('New value');
|
|
});
|