## Summary - replace broad substring-based masking with a shared exact/path-based secret classifier and workspace-scoped fingerprint hashing - persist protected snapshot metadata on `policy_versions` and keep secret-only changes visible in compare, drift, restore, review, verification, and ops surfaces - add Spec 120 artifacts, audit documentation, and focused Pest regression coverage for snapshot, audit, verification, review-pack, and notification behavior ## Validation - `vendor/bin/sail artisan test --compact tests/Feature/Intune/PolicySnapshotRedactionTest.php tests/Feature/Intune/PolicySnapshotFingerprintIsolationTest.php tests/Feature/ReviewPack/ReviewPackRedactionIntegrityTest.php tests/Feature/OpsUx/OperationRunNotificationRedactionTest.php tests/Feature/Verification/VerificationReportViewerDbOnlyTest.php` - `vendor/bin/sail bin pint --dirty --format agent` ## Spec / checklist status | Checklist | Total | Completed | Incomplete | Status | |-----------|-------|-----------|------------|--------| | requirements.md | 16 | 16 | 0 | ✓ PASS | - `tasks.md`: T001-T032 complete - `tasks.md`: T033 manual quickstart validation is still open and noted for follow-up ## Filament / platform notes - Livewire v4 compliance is unchanged - no panel provider changes; `bootstrap/providers.php` remains the registration location - no new globally searchable resources were introduced, so global search requirements are unchanged - no new destructive Filament actions were added - no new Filament assets were added; no `filament:assets` deployment change is required ## Testing coverage touched - snapshot persistence and fingerprint isolation - compare/drift protected-change evidence - audit, verification, review-pack, ops-failure, and notification sanitization - viewer/read-only Filament presentation updates Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #146
146 lines
3.6 KiB
PHP
146 lines
3.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Support;
|
|
|
|
use App\Models\OperationRun;
|
|
use App\Models\PolicyVersion;
|
|
use App\Services\Intune\SecretClassificationService;
|
|
|
|
final class RedactionIntegrity
|
|
{
|
|
public static function protectedValueNote(): string
|
|
{
|
|
return 'Protected values are intentionally hidden as [REDACTED]. Secret-only changes remain detectable without revealing the value.';
|
|
}
|
|
|
|
public static function noteForPolicyVersion(PolicyVersion $version): ?string
|
|
{
|
|
if (self::fingerprintCount($version->secret_fingerprints) > 0) {
|
|
return self::protectedValueNote();
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* @param array<string, mixed> $evidence
|
|
*/
|
|
public static function noteForFindingEvidence(array $evidence): ?string
|
|
{
|
|
$notes = self::findingEvidenceNotes($evidence);
|
|
|
|
return $notes === [] ? null : implode(' ', $notes);
|
|
}
|
|
|
|
public static function noteForRun(OperationRun $run): ?string
|
|
{
|
|
$context = is_array($run->context) ? $run->context : [];
|
|
$integrityNote = data_get($context, 'redaction_integrity.note');
|
|
|
|
if (is_string($integrityNote) && trim($integrityNote) !== '') {
|
|
return trim($integrityNote);
|
|
}
|
|
|
|
if ((bool) data_get($context, 'redaction_integrity.protected_values_hidden', false)) {
|
|
return self::protectedValueNote();
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
/**
|
|
* @param array<string, mixed>|null $report
|
|
* @return array<int, string>
|
|
*/
|
|
public static function verificationNotes(?array $report): array
|
|
{
|
|
if (! is_array($report)) {
|
|
return [];
|
|
}
|
|
|
|
if (! self::containsPlaceholderFragment($report)) {
|
|
return [];
|
|
}
|
|
|
|
return [self::protectedValueNote()];
|
|
}
|
|
|
|
/**
|
|
* @param array<string, mixed>|null $fingerprints
|
|
*/
|
|
public static function fingerprintCount(?array $fingerprints): int
|
|
{
|
|
if (! is_array($fingerprints)) {
|
|
return 0;
|
|
}
|
|
|
|
$count = 0;
|
|
|
|
foreach ($fingerprints as $bucket) {
|
|
if (! is_array($bucket)) {
|
|
continue;
|
|
}
|
|
|
|
foreach ($bucket as $digest) {
|
|
if (is_string($digest) && trim($digest) !== '') {
|
|
$count++;
|
|
}
|
|
}
|
|
}
|
|
|
|
return $count;
|
|
}
|
|
|
|
/**
|
|
* @param array<string, mixed> $evidence
|
|
*/
|
|
private static function evidenceHasProtectedData(array $evidence): bool
|
|
{
|
|
foreach (['baseline', 'current'] as $side) {
|
|
$fingerprints = data_get($evidence, "{$side}.secret_fingerprints");
|
|
|
|
if (is_array($fingerprints) && self::fingerprintCount($fingerprints) > 0) {
|
|
return true;
|
|
}
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* @param array<string, mixed> $evidence
|
|
* @return array<int, string>
|
|
*/
|
|
private static function findingEvidenceNotes(array $evidence): array
|
|
{
|
|
$notes = [];
|
|
|
|
if (self::evidenceHasProtectedData($evidence)) {
|
|
$notes[] = self::protectedValueNote();
|
|
}
|
|
|
|
return array_values(array_unique($notes));
|
|
}
|
|
|
|
private static function containsPlaceholderFragment(mixed $value): bool
|
|
{
|
|
if (is_string($value)) {
|
|
return str_contains($value, SecretClassificationService::REDACTED);
|
|
}
|
|
|
|
if (! is_array($value)) {
|
|
return false;
|
|
}
|
|
|
|
foreach ($value as $item) {
|
|
if (self::containsPlaceholderFragment($item)) {
|
|
return true;
|
|
}
|
|
}
|
|
|
|
return false;
|
|
}
|
|
}
|