## Summary - harden the canonical operation run viewer so mismatched, missing, archived, onboarding, and selector-excluded tenant context no longer invalidates authorized canonical run viewing - extend canonical route, header-context, deep-link, and presentation coverage for Spec 144 and add the full spec artifact set under `specs/144-canonical-operation-viewer-context-decoupling/` - harden onboarding draft provider-connection resume logic so stale persisted provider connections fall back to the connect-provider step instead of resuming invalid state - add architecture-audit follow-up candidate material and prompt assets for the next governance hardening wave ## Testing - `vendor/bin/sail bin pint --dirty --format agent` - `vendor/bin/sail artisan test --compact tests/Feature/144/CanonicalOperationViewerContextMismatchTest.php tests/Feature/144/CanonicalOperationViewerDeepLinkTrustTest.php tests/Feature/Operations/TenantlessOperationRunViewerTest.php tests/Feature/OpsUx/OperateHubShellTest.php tests/Feature/Monitoring/OperationsTenantScopeTest.php tests/Feature/RunAuthorizationTenantIsolationTest.php tests/Feature/Filament/OperationRunEnterpriseDetailPageTest.php tests/Feature/Monitoring/HeaderContextBarTest.php tests/Feature/Monitoring/OperationRunResolvedReferencePresentationTest.php tests/Feature/Monitoring/OperationsCanonicalUrlsTest.php` - `vendor/bin/sail artisan test --compact tests/Feature/ManagedTenantOnboardingWizardTest.php tests/Unit/Onboarding/OnboardingDraftStageResolverTest.php tests/Unit/Onboarding/OnboardingLifecycleServiceTest.php` ## Notes - branch: `144-canonical-operation-viewer-context-decoupling` - base: `dev` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #173
171 lines
6.9 KiB
PHP
171 lines
6.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\OperationRun;
|
|
use App\Models\Tenant;
|
|
use App\Support\OperationRunOutcome;
|
|
use App\Support\OperationRunStatus;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Tests\TestCase;
|
|
|
|
final class CanonicalOperationViewerContextMismatchTest extends TestCase
|
|
{
|
|
use RefreshDatabase;
|
|
|
|
public function test_shows_non_blocking_mismatch_context_when_the_selected_tenant_differs_from_the_run_tenant(): void
|
|
{
|
|
$runTenant = Tenant::factory()->create([
|
|
'name' => 'Run Tenant',
|
|
'workspace_id' => null,
|
|
]);
|
|
[$user, $runTenant] = createUserWithTenant(tenant: $runTenant, role: 'owner');
|
|
|
|
$currentTenant = Tenant::factory()->create([
|
|
'name' => 'Current Tenant',
|
|
'workspace_id' => (int) $runTenant->workspace_id,
|
|
]);
|
|
|
|
createUserWithTenant(tenant: $currentTenant, user: $user, role: 'owner');
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'workspace_id' => (int) $runTenant->workspace_id,
|
|
'tenant_id' => (int) $runTenant->getKey(),
|
|
'type' => 'policy.sync',
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Succeeded->value,
|
|
]);
|
|
|
|
Filament::setTenant($currentTenant, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $runTenant->workspace_id])
|
|
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
|
->assertOk()
|
|
->assertSee('Current tenant context differs from this run')
|
|
->assertSee('Current tenant context: Current Tenant.')
|
|
->assertSee('Run tenant: Run Tenant.')
|
|
->assertSee('canonical workspace view');
|
|
}
|
|
|
|
public function test_frames_tenantless_runs_as_workspace_level_even_when_tenant_context_is_selected(): void
|
|
{
|
|
$selectedTenant = Tenant::factory()->create([
|
|
'name' => 'Selected Tenant',
|
|
]);
|
|
[$user, $selectedTenant] = createUserWithTenant(tenant: $selectedTenant, role: 'owner');
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'workspace_id' => (int) $selectedTenant->workspace_id,
|
|
'tenant_id' => null,
|
|
'type' => 'provider.connection.check',
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Succeeded->value,
|
|
]);
|
|
|
|
Filament::setTenant($selectedTenant, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $selectedTenant->workspace_id])
|
|
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
|
->assertOk()
|
|
->assertSee('Workspace-level run')
|
|
->assertSee('This canonical workspace view is not tied to the current tenant context (Selected Tenant).');
|
|
}
|
|
|
|
public function test_keeps_onboarding_tenant_runs_viewable_with_lifecycle_aware_context(): void
|
|
{
|
|
$tenant = Tenant::factory()->create([
|
|
'name' => 'Onboarding Tenant',
|
|
'status' => Tenant::STATUS_ONBOARDING,
|
|
]);
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'type' => 'inventory_sync',
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Succeeded->value,
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
|
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
|
->assertOk()
|
|
->assertSee('Run tenant is not available in the current tenant selector')
|
|
->assertSee('Run tenant: Onboarding Tenant.')
|
|
->assertSee('This tenant is currently onboarding')
|
|
->assertSee('Back to Operations')
|
|
->assertDontSee('← Back to Onboarding Tenant');
|
|
}
|
|
|
|
public function test_keeps_archived_tenant_runs_viewable_with_lifecycle_aware_context(): void
|
|
{
|
|
$activeTenant = Tenant::factory()->create([
|
|
'name' => 'Active Tenant',
|
|
]);
|
|
[$user, $activeTenant] = createUserWithTenant(tenant: $activeTenant, role: 'owner');
|
|
|
|
$archivedTenant = Tenant::factory()->create([
|
|
'name' => 'Archived Tenant',
|
|
'workspace_id' => (int) $activeTenant->workspace_id,
|
|
'status' => Tenant::STATUS_ACTIVE,
|
|
]);
|
|
|
|
createUserWithTenant(tenant: $archivedTenant, user: $user, role: 'owner');
|
|
$archivedTenant->delete();
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'workspace_id' => (int) $activeTenant->workspace_id,
|
|
'tenant_id' => (int) $archivedTenant->getKey(),
|
|
'type' => 'inventory_sync',
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Succeeded->value,
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $activeTenant->workspace_id])
|
|
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
|
->assertOk()
|
|
->assertSee('Run tenant is not available in the current tenant selector')
|
|
->assertSee('Run tenant: Archived Tenant.')
|
|
->assertSee('This tenant is currently archived')
|
|
->assertSee('Back to Operations')
|
|
->assertDontSee('← Back to Archived Tenant');
|
|
}
|
|
|
|
public function test_keeps_selector_excluded_draft_tenant_runs_viewable_with_lifecycle_aware_context(): void
|
|
{
|
|
$tenant = Tenant::factory()->create([
|
|
'name' => 'Draft Tenant',
|
|
'status' => Tenant::STATUS_DRAFT,
|
|
]);
|
|
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'type' => 'policy.sync',
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Succeeded->value,
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
|
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
|
->assertOk()
|
|
->assertSee('Run tenant is not available in the current tenant selector')
|
|
->assertSee('Run tenant: Draft Tenant.')
|
|
->assertSee('This tenant is currently draft');
|
|
}
|
|
}
|