Some checks failed
PR Fast Feedback / fast-feedback (pull_request) Failing after 56s
## Summary - decommission the legacy findings lifecycle backfill substrate across command, job, service, and UI layers - remove related platform capabilities, operation catalog entries, and action surface exemptions - add regression and removal verification tests to ensure runtime integrity and surface absence - include spec, plan, tasks, and data-model artifacts for the removal slice ## Scope - active spec: specs/253-remove-findings-backfill-runtime-surfaces - target branch: dev ## Validation - integrated regression and removal verification tests for console, findings, and system ops surfaces - audit log and capability trace verification for the removal path
60 lines
1.8 KiB
PHP
60 lines
1.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\System\Pages\Ops\Runbooks;
|
|
use App\Models\PlatformUser;
|
|
use App\Support\Auth\PlatformCapabilities;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Livewire\Livewire;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
beforeEach(function (): void {
|
|
Filament::setCurrentPanel('system');
|
|
Filament::bootCurrentPanel();
|
|
});
|
|
|
|
it('keeps the system runbooks page accessible without findings lifecycle backfill launch surfaces', function (): void {
|
|
$user = PlatformUser::factory()->create([
|
|
'capabilities' => [
|
|
PlatformCapabilities::ACCESS_SYSTEM_PANEL,
|
|
PlatformCapabilities::OPS_VIEW,
|
|
PlatformCapabilities::RUNBOOKS_VIEW,
|
|
PlatformCapabilities::RUNBOOKS_RUN,
|
|
],
|
|
'is_active' => true,
|
|
]);
|
|
|
|
$this->actingAs($user, 'platform');
|
|
|
|
$this->get(Runbooks::getUrl(panel: 'system'))
|
|
->assertSuccessful()
|
|
->assertSee('No supported runbooks')
|
|
->assertDontSee('Rebuild Findings Lifecycle')
|
|
->assertDontSee('Backfills legacy findings lifecycle fields')
|
|
->assertDontSee('Preflight')
|
|
->assertDontSee('preflight')
|
|
->assertDontSee('Run: Rebuild Findings Lifecycle')
|
|
->assertDontSee('BACKFILL');
|
|
|
|
Livewire::test(Runbooks::class)
|
|
->assertActionDoesNotExist('preflight')
|
|
->assertActionDoesNotExist('run');
|
|
});
|
|
|
|
it('preserves runbooks view authorization semantics after removing the backfill runbook', function (): void {
|
|
$user = PlatformUser::factory()->create([
|
|
'capabilities' => [
|
|
PlatformCapabilities::ACCESS_SYSTEM_PANEL,
|
|
PlatformCapabilities::OPS_VIEW,
|
|
],
|
|
'is_active' => true,
|
|
]);
|
|
|
|
$this->actingAs($user, 'platform')
|
|
->get(Runbooks::getUrl(panel: 'system'))
|
|
->assertForbidden();
|
|
});
|