ahmido
a4f5c4f122
## Summary - standardize Filament table defaults across resources, relation managers, widgets, custom pages, and picker tables - add shared pagination profiles, calm default column visibility, explicit empty states, and session persistence on designated critical resource lists - complete Spec 125 artifacts, regression tests, and dashboard widget follow-up for lazy loading, sortable columns, and toggleable detail columns ## Verification - `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=BaselineCompareNow` - `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=TableStandardsBaseline` - `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=TableDetailVisibility` - `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=FilamentTableRiskExceptions` - full suite run completed: `2017 passed, 10 failed, 8 skipped` - manual browser QA completed on the tenant dashboard for lazy loading, sortable widget columns, toggleable hidden status columns, badges, and pagination ## Known Failures The full suite still has 10 pre-existing failures unrelated to this branch: - `Tests\\Unit\\OpsUx\\SummaryCountsNormalizerTest` - `Tests\\Feature\\BackupWithAssignmentsConsistencyTest` (2 tests) - `Tests\\Feature\\BaselineDriftEngine\\CaptureBaselineContentTest` - `Tests\\Feature\\BaselineDriftEngine\\CompareContentEvidenceTest` - `Tests\\Feature\\BaselineDriftEngine\\ResolverTest` - `Tests\\Feature\\Filament\\TenantDashboardDbOnlyTest` - `Tests\\Feature\\Operations\\ReconcileAdapterRunsJobTrackingTest` - `Tests\\Feature\\ReviewPack\\ReviewPackRbacTest` - `Tests\\Feature\\Verification\\VerificationReportRedactionTest` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #152
73 lines
3.0 KiB
PHP
73 lines
3.0 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\ProviderConnectionResource;
|
|
use App\Filament\Resources\ProviderConnectionResource\Pages\ListProviderConnections;
|
|
use App\Models\ProviderConnection;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Support\Facades\Bus;
|
|
use Livewire\Livewire;
|
|
|
|
it('renders Provider Connections DB-only (no outbound HTTP, no background work)', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$connection = ProviderConnection::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'display_name' => 'Contoso',
|
|
'entra_tenant_id' => fake()->uuid(),
|
|
'provider' => 'microsoft',
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
|
|
Bus::fake();
|
|
|
|
assertNoOutboundHttp(function () use ($tenant, $connection): void {
|
|
$this->get(ProviderConnectionResource::getUrl('index', tenant: $tenant))
|
|
->assertOk()
|
|
->assertSee('Contoso');
|
|
|
|
$this->get(ProviderConnectionResource::getUrl('edit', ['record' => $connection], tenant: $tenant))
|
|
->assertOk()
|
|
->assertSee('Contoso');
|
|
});
|
|
|
|
Bus::assertNothingDispatched();
|
|
});
|
|
|
|
it('keeps provider connection table defaults calm and persists state without outbound HTTP', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
|
|
|
|
$this->actingAs($user);
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
assertNoOutboundHttp(function () use ($user): void {
|
|
$component = Livewire::actingAs($user)
|
|
->test(ListProviderConnections::class)
|
|
->assertTableEmptyStateActionsExistInOrder(['create'])
|
|
->searchTable('Contoso')
|
|
->call('sortTable', 'display_name', 'desc')
|
|
->set('tableFilters.default_only.isActive', true);
|
|
|
|
$table = $component->instance()->getTable();
|
|
|
|
expect($table->getPaginationPageOptions())->toBe(\App\Support\Filament\TablePaginationProfiles::resource());
|
|
expect($table->getEmptyStateHeading())->toBe('No provider connections found');
|
|
expect($table->getColumn('display_name')?->isSearchable())->toBeTrue();
|
|
expect($table->getColumn('display_name')?->isSortable())->toBeTrue();
|
|
expect($table->getColumn('provider')?->isToggledHiddenByDefault())->toBeTrue();
|
|
expect($table->getColumn('entra_tenant_id')?->isToggledHiddenByDefault())->toBeTrue();
|
|
expect(count($table->getVisibleColumns()))->toBeLessThanOrEqual(7);
|
|
expect(session()->get($component->instance()->getTableSearchSessionKey()))->toBe('Contoso');
|
|
expect(session()->get($component->instance()->getTableSortSessionKey()))->toBe('display_name:desc');
|
|
|
|
Livewire::actingAs($user)
|
|
->test(ListProviderConnections::class)
|
|
->assertSet('tableSearch', 'Contoso')
|
|
->assertSet('tableSort', 'display_name:desc')
|
|
->assertSet('tableFilters.default_only.isActive', true);
|
|
});
|
|
});
|