ahmido
3030dd9af2
Summary Kurz: Implementiert Feature 054 — canonical OperationRun-flow, Monitoring UI, dispatch-safety, notifications, dedupe, plus small UX safety clarifications (RBAC group search delegated; Restore group mapping DB-only). What Changed Core service: OperationRun lifecycle, dedupe and dispatch helpers — OperationRunService.php. Model + migration: OperationRun model and migration — OperationRun.php, 2026_01_16_180642_create_operation_runs_table.php. Notifications: queued + terminal DB notifications (initiator-only) — OperationRunQueued.php, OperationRunCompleted.php. Monitoring UI: Filament list/detail + Livewire pieces (DB-only render) — OperationRunResource.php and related pages/views. Start surfaces / Jobs: instrumented start surfaces, job middleware, and job updates to use canonical runs — multiple app/Jobs/* and app/Filament/* updates (see tests for full coverage). RBAC + Restore UX clarifications: RBAC group search is delegated-Graph-based and disabled without delegated token; Restore group mapping remains DB-only (directory cache) and helper text always visible — TenantResource.php, RestoreRunResource.php. Specs / Constitution: updated spec & quickstart and added one-line constitution guideline about Graph usage: spec.md quickstart.md constitution.md Tests & Verification Unit / Feature tests added/updated for run lifecycle, notifications, idempotency, and UI guards: see tests/Feature/* (notably OperationRunServiceTest, MonitoringOperationsTest, OperationRunNotificationTest, and various Filament feature tests). Full test run locally: ./vendor/bin/sail artisan test → 587 passed, 5 skipped. Migrations Adds create_operation_runs_table migration; run php artisan migrate in staging after review. Notes / Rationale Monitoring pages are explicitly DB-only at render time (no Graph calls). Start surfaces enqueue work only and return a “View run” link. Delegated Graph access is used only for explicit user actions (RBAC group search); restore mapping intentionally uses cached DB data only to avoid render-time Graph calls. Dispatch wrapper marks runs failed immediately if background dispatch throws synchronously to avoid misleading “queued” states. Upgrade / Deploy Considerations Run migrations: ./vendor/bin/sail artisan migrate. Background workers should be running to process queued jobs (recommended to monitor queue health during rollout). No secret or token persistence changes. PR checklist Tests updated/added for changed behavior Specs updated: 054-unify-runs-suitewide docs + quickstart Constitution note added (.specify) Pint formatting applied Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #63
61 lines
2.3 KiB
PHP
61 lines
2.3 KiB
PHP
<div class="space-y-6">
|
|
<div class="grid grid-cols-1 md:grid-cols-2 gap-4">
|
|
<div class="bg-white p-4 rounded shadow">
|
|
<h3 class="font-bold text-lg mb-2">Summary</h3>
|
|
<dl class="grid grid-cols-2 gap-x-4 gap-y-2">
|
|
<dt class="text-gray-600">Type:</dt>
|
|
<dd>{{ $run->type }}</dd>
|
|
|
|
<dt class="text-gray-600">Status:</dt>
|
|
<dd>{{ $run->status }}</dd>
|
|
|
|
<dt class="text-gray-600">Outcome:</dt>
|
|
<dd>{{ $run->outcome }}</dd>
|
|
|
|
<dt class="text-gray-600">Initiator:</dt>
|
|
<dd>{{ $run->initiator_name }}</dd>
|
|
</dl>
|
|
</div>
|
|
|
|
<div class="bg-white p-4 rounded shadow">
|
|
<h3 class="font-bold text-lg mb-2">Timing</h3>
|
|
<dl class="grid grid-cols-2 gap-x-4 gap-y-2">
|
|
<dt class="text-gray-600">Created:</dt>
|
|
<dd>{{ $run->created_at }}</dd>
|
|
|
|
<dt class="text-gray-600">Started:</dt>
|
|
<dd>{{ $run->started_at ?? '-' }}</dd>
|
|
|
|
<dt class="text-gray-600">Completed:</dt>
|
|
<dd>{{ $run->completed_at ?? '-' }}</dd>
|
|
</dl>
|
|
</div>
|
|
</div>
|
|
|
|
@if(!empty($run->summary_counts))
|
|
<div class="bg-white p-4 rounded shadow">
|
|
<h3 class="font-bold text-lg mb-2">Counts</h3>
|
|
<pre class="bg-gray-100 p-2 rounded text-sm overflow-auto">{{ json_encode($run->summary_counts, JSON_PRETTY_PRINT) }}</pre>
|
|
</div>
|
|
@endif
|
|
|
|
@if(!empty($run->failure_summary))
|
|
<div class="bg-white p-4 rounded shadow border-l-4 border-red-500">
|
|
<h3 class="font-bold text-lg mb-2 text-red-700">Failures</h3>
|
|
<div class="space-y-2">
|
|
@foreach($run->failure_summary as $failure)
|
|
<div class="bg-red-50 p-2 rounded">
|
|
<div class="font-mono text-xs text-red-800">{{ $failure['code'] ?? 'UNKNOWN' }}</div>
|
|
<div class="text-sm text-red-900">{{ $failure['message'] ?? 'Unknown error' }}</div>
|
|
</div>
|
|
@endforeach
|
|
</div>
|
|
</div>
|
|
@endif
|
|
|
|
<div class="bg-white p-4 rounded shadow">
|
|
<h3 class="font-bold text-lg mb-2">Context</h3>
|
|
<pre class="bg-gray-100 p-2 rounded text-sm overflow-auto">{{ json_encode($run->context, JSON_PRETTY_PRINT) }}</pre>
|
|
</div>
|
|
</div>
|