TenantAtlas/tests/Unit/BulkPolicyVersionForceDeleteJobTest.php
ahmido a97beefda3 056-remove-legacy-bulkops (#65)
Kurzbeschreibung

Versteckt die Rerun-Row-Action für archivierte (soft-deleted) RestoreRuns und verhindert damit fehlerhafte Neu-Starts aus dem Archiv; ergänzt einen Regressionstest.
Änderungen

Code: RestoreRunResource.php — Sichtbarkeit der rerun-Action geprüft auf ! $record->trashed() und defensive Abbruchprüfung im Action-Handler.
Tests: RestoreRunRerunTest.php — neuer Test rerun action is hidden for archived restore runs.
Warum

Archivierte RestoreRuns durften nicht neu gestartet werden; UI zeigte trotzdem die Option. Das führte zu verwirrendem Verhalten und möglichen Fehlern beim Enqueueing.
Verifikation / QA

Unit/Feature:
./vendor/bin/sail artisan test tests/Feature/RestoreRunRerunTest.php
Stil/format:
./vendor/bin/pint --dirty
Manuell (UI):
Als Tenant-Admin Filament → Restore Runs öffnen.
Filter Archived aktivieren (oder Trashed filter auswählen).
Sicherstellen, dass für archivierte Einträge die Rerun-Action nicht sichtbar ist.
Auf einem aktiven (nicht-archivierten) Run prüfen, dass Rerun sichtbar bleibt und wie erwartet eine neue RestoreRun erzeugt.
Wichtige Hinweise

Kein DB-Migration required.
Diese PR enthält nur den UI-/Filament-Fix; die zuvor gemachten operative Fixes für Queue/adapter-Reconciliation bleiben ebenfalls auf dem Branch (z. B. frühere commits während der Debugging-Session).
T055 (Schema squash) wurde bewusst zurückgestellt und ist nicht Teil dieses PRs.
Merge-Checklist

 Tests lokal laufen (RestoreRunRerunTest grünt)
 Pint läuft ohne ungepatchte Fehler
 Branch gepusht: 056-remove-legacy-bulkops (PR-URL: https://git.cloudarix.de/ahmido/TenantAtlas/compare/dev...056-remove-legacy-bulkops)

Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local>
Reviewed-on: #65
2026-01-19 23:27:52 +00:00

118 lines
3.8 KiB
PHP

<?php
use App\Models\Policy;
use App\Models\PolicyVersion;
use App\Models\OperationRun;
use App\Models\Tenant;
use App\Models\User;
use App\Jobs\Operations\PolicyVersionForceDeleteWorkerJob;
use App\Services\OperationRunService;
use App\Services\Operations\TargetScopeConcurrencyLimiter;
use Illuminate\Foundation\Testing\RefreshDatabase;
uses(RefreshDatabase::class);
test('worker force deletes archived versions and skips active versions', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create();
$policy = Policy::factory()->create(['tenant_id' => $tenant->id]);
$archived = PolicyVersion::factory()->create([
'tenant_id' => $tenant->id,
'policy_id' => $policy->id,
'version_number' => 1,
'captured_at' => now()->subDays(120),
]);
$archived->delete();
$active = PolicyVersion::factory()->create([
'tenant_id' => $tenant->id,
'policy_id' => $policy->id,
'version_number' => 2,
'captured_at' => now()->subDays(10),
]);
$run = OperationRun::factory()->create([
'tenant_id' => $tenant->id,
'user_id' => $user->id,
'type' => 'policy_version.force_delete',
'status' => 'running',
'outcome' => 'pending',
'summary_counts' => ['total' => 2],
'failure_summary' => [],
'context' => [
'target_scope' => ['directory_context_id' => 1],
],
]);
$runs = app(OperationRunService::class);
$limiter = app(TargetScopeConcurrencyLimiter::class);
(new PolicyVersionForceDeleteWorkerJob(
tenantId: $tenant->id,
userId: $user->id,
policyVersionId: $archived->id,
operationRun: $run,
))->handle($runs, $limiter);
(new PolicyVersionForceDeleteWorkerJob(
tenantId: $tenant->id,
userId: $user->id,
policyVersionId: $active->id,
operationRun: $run,
))->handle($runs, $limiter);
$run->refresh();
expect($run->status)->toBe('completed')
->and($run->outcome)->toBe('succeeded')
->and($run->summary_counts['total'] ?? null)->toBe(2)
->and($run->summary_counts['processed'] ?? null)->toBe(2)
->and($run->summary_counts['succeeded'] ?? null)->toBe(1)
->and($run->summary_counts['skipped'] ?? null)->toBe(1)
->and((int) ($run->summary_counts['failed'] ?? 0))->toBe(0);
expect(PolicyVersion::withTrashed()->whereKey($archived->id)->exists())->toBeFalse();
expect($active->refresh()->trashed())->toBeFalse();
});
test('worker records failure when policy version is missing', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create();
$run = OperationRun::factory()->create([
'tenant_id' => $tenant->id,
'user_id' => $user->id,
'type' => 'policy_version.force_delete',
'status' => 'running',
'outcome' => 'pending',
'summary_counts' => ['total' => 1],
'failure_summary' => [],
'context' => [
'target_scope' => ['directory_context_id' => 1],
],
]);
$runs = app(OperationRunService::class);
$limiter = app(TargetScopeConcurrencyLimiter::class);
(new PolicyVersionForceDeleteWorkerJob(
tenantId: $tenant->id,
userId: $user->id,
policyVersionId: 999999,
operationRun: $run,
))->handle($runs, $limiter);
$run->refresh();
expect($run->status)->toBe('completed')
->and($run->outcome)->toBe('failed')
->and($run->summary_counts['total'] ?? null)->toBe(1)
->and($run->summary_counts['processed'] ?? null)->toBe(1)
->and($run->summary_counts['failed'] ?? null)->toBe(1);
$codes = collect($run->failure_summary ?? [])->pluck('code')->all();
expect($codes)->toContain('policy_version.not_found');
});