Kurzbeschreibung Filament-native UI-Polish für das Tenant-Dashboard und zugehörige Inventory/Operations-Ansichten; entfernt alte custom Blade‑Panel-Wrapper (die die dicken Rahmen erzeugten) und ersetzt sie durch Filament‑Widgets (StatsOverview / TableWidget). Keine DB-Migrationen. Änderungen (Kurz) Dashboard: KPI‑Kacheln als StatsOverviewWidget (4 Tiles). Needs‑Attention: sinnvolle Leerstaat‑UI (3 Health‑Checks + Links) und begrenzte, badge‑gestützte Issue‑Liste. Recent Drift Findings & Recent Operations: Filament TableWidget (10 Zeilen), badge‑Spalten für Severity/Status/Outcome, kurze copyable IDs, freundliche Subject‑Labels statt roher UUIDs. Entfernen der alten Blade-Wrapper, die ring- / shadow Klassen erzeugten. Tests aktualisiert/ergänzt, um Tenant‑Scope und DB‑only Garantien zu prüfen. Kleinigkeiten / UI‑Polish in Inventory/Operations-Listen und Panel‑Provider. Wichtige Dateien (Auswahl) DashboardKpis.php NeedsAttention.php RecentDriftFindings.php RecentOperations.php needs-attention.blade.php Tests: TenantDashboardTenantScopeTest.php, inventory/operations test updates Testing / Verifikation Lokale Tests (empfohlen, vor Merge ausführen): Formatter: Filament assets (falls panel assets geändert wurden): Review‑Hinweise (Was prüfen) UI: Dashboard sieht visuell wie Filament‑Demo‑Widgets aus (keine dicken ring- Rahmen mehr). Tables: Primary text zeigt freundliche Labels, nicht UUIDs; IDs sind copyable und kurz dargestellt. Needs‑Attention: Leerstaat zeigt die 3 Health‑Checks + korrekte Links; bei Issues sind Badges und Farben korrekt. Tenant‑Scope: Keine Daten von anderen Tenants leakieren (prüfe die aktualisierten TenantScope‑Tests). Polling: Widgets poll nur wenn nötig (z.B. aktive Runs existieren). Keine externen HTTP‑Calls oder ungeprüfte Jobs während Dashboard‑Rendering. Deployment / Migrations Keine Datenbankmigrationen. Empfohlen: nach Merge ./vendor/bin/sail artisan filament:assets in Deployment‑Pipeline prüfen, falls neue panel assets registriert wurden. Zusammenfassung für den Reviewer Zweck: Entfernen der alten, handgebauten Panel‑Wrappers und Vereinheitlichung der Dashboard‑UX mit Filament‑nativen Komponenten; kleinere UI‑Polish in Inventory/Operations. Tests: Unit/Feature tests für Tenant‑Scope und DB‑only Verhalten wurden aktualisiert; bitte laufen lassen. Merge: Branch 058-tenant-ui-polish → dev (protected) via Pull Request in Gitea. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #70
159 lines
5.2 KiB
PHP
159 lines
5.2 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Filament\Widgets\Dashboard;
|
|
|
|
use App\Filament\Pages\DriftLanding;
|
|
use App\Filament\Resources\FindingResource;
|
|
use App\Models\Finding;
|
|
use App\Models\OperationRun;
|
|
use App\Models\Tenant;
|
|
use App\Support\OperationRunLinks;
|
|
use App\Support\OpsUx\ActiveRuns;
|
|
use Filament\Facades\Filament;
|
|
use Filament\Widgets\Widget;
|
|
|
|
class NeedsAttention extends Widget
|
|
{
|
|
protected static bool $isLazy = false;
|
|
|
|
protected string $view = 'filament.widgets.dashboard.needs-attention';
|
|
|
|
/**
|
|
* @return array<string, mixed>
|
|
*/
|
|
protected function getViewData(): array
|
|
{
|
|
$tenant = Filament::getTenant();
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
return [
|
|
'pollingInterval' => null,
|
|
'items' => [],
|
|
'healthyChecks' => [],
|
|
];
|
|
}
|
|
|
|
$tenantId = (int) $tenant->getKey();
|
|
|
|
$items = [];
|
|
|
|
$highSeverityCount = (int) Finding::query()
|
|
->where('tenant_id', $tenantId)
|
|
->where('finding_type', Finding::FINDING_TYPE_DRIFT)
|
|
->where('status', Finding::STATUS_NEW)
|
|
->where('severity', Finding::SEVERITY_HIGH)
|
|
->count();
|
|
|
|
if ($highSeverityCount > 0) {
|
|
$items[] = [
|
|
'title' => 'High severity drift findings',
|
|
'body' => "{$highSeverityCount} finding(s) need review.",
|
|
'url' => FindingResource::getUrl('index', tenant: $tenant),
|
|
'badge' => 'Drift',
|
|
'badgeColor' => 'danger',
|
|
];
|
|
}
|
|
|
|
$latestDriftSuccess = OperationRun::query()
|
|
->where('tenant_id', $tenantId)
|
|
->where('type', 'drift.generate')
|
|
->where('status', 'completed')
|
|
->where('outcome', 'succeeded')
|
|
->whereNotNull('completed_at')
|
|
->latest('completed_at')
|
|
->first();
|
|
|
|
if (! $latestDriftSuccess) {
|
|
$items[] = [
|
|
'title' => 'No drift scan yet',
|
|
'body' => 'Generate drift after you have at least two successful inventory runs.',
|
|
'url' => DriftLanding::getUrl(tenant: $tenant),
|
|
'badge' => 'Drift',
|
|
'badgeColor' => 'warning',
|
|
];
|
|
} else {
|
|
$isStale = $latestDriftSuccess->completed_at?->lt(now()->subDays(7)) ?? true;
|
|
|
|
if ($isStale) {
|
|
$items[] = [
|
|
'title' => 'Drift stale',
|
|
'body' => 'Last drift scan is older than 7 days.',
|
|
'url' => DriftLanding::getUrl(tenant: $tenant),
|
|
'badge' => 'Drift',
|
|
'badgeColor' => 'warning',
|
|
];
|
|
}
|
|
}
|
|
|
|
$latestDriftFailure = OperationRun::query()
|
|
->where('tenant_id', $tenantId)
|
|
->where('type', 'drift.generate')
|
|
->where('status', 'completed')
|
|
->where('outcome', 'failed')
|
|
->latest('id')
|
|
->first();
|
|
|
|
if ($latestDriftFailure instanceof OperationRun) {
|
|
$items[] = [
|
|
'title' => 'Drift generation failed',
|
|
'body' => 'Investigate the latest failed run.',
|
|
'url' => OperationRunLinks::view($latestDriftFailure, $tenant),
|
|
'badge' => 'Operations',
|
|
'badgeColor' => 'danger',
|
|
];
|
|
}
|
|
|
|
$activeRuns = (int) OperationRun::query()
|
|
->where('tenant_id', $tenantId)
|
|
->active()
|
|
->count();
|
|
|
|
if ($activeRuns > 0) {
|
|
$items[] = [
|
|
'title' => 'Operations in progress',
|
|
'body' => "{$activeRuns} run(s) are active.",
|
|
'url' => OperationRunLinks::index($tenant),
|
|
'badge' => 'Operations',
|
|
'badgeColor' => 'warning',
|
|
];
|
|
}
|
|
|
|
$items = array_slice($items, 0, 5);
|
|
|
|
$healthyChecks = [];
|
|
|
|
if ($items === []) {
|
|
$healthyChecks = [
|
|
[
|
|
'title' => 'Drift findings look healthy',
|
|
'body' => 'No high severity drift findings are open.',
|
|
'url' => FindingResource::getUrl('index', tenant: $tenant),
|
|
'linkLabel' => 'View findings',
|
|
],
|
|
[
|
|
'title' => 'Drift scans are up to date',
|
|
'body' => $latestDriftSuccess?->completed_at
|
|
? 'Last drift scan: '.$latestDriftSuccess->completed_at->diffForHumans(['short' => true]).'.'
|
|
: 'Drift scan history is available in Drift.',
|
|
'url' => DriftLanding::getUrl(tenant: $tenant),
|
|
'linkLabel' => 'Open Drift',
|
|
],
|
|
[
|
|
'title' => 'No active operations',
|
|
'body' => 'Nothing is currently running for this tenant.',
|
|
'url' => OperationRunLinks::index($tenant),
|
|
'linkLabel' => 'View operations',
|
|
],
|
|
];
|
|
}
|
|
|
|
return [
|
|
'pollingInterval' => ActiveRuns::existForTenant($tenant) ? '10s' : null,
|
|
'items' => $items,
|
|
'healthyChecks' => $healthyChecks,
|
|
];
|
|
}
|
|
}
|