ahmido
e0c2cdb1f4
## Summary - enforce the canonical workspace/environment scope contract for workspace hubs and environment-owned surfaces - replace first-party Operations deep links that leaked Filament `tableFilters[...]` internals with stable product-level query behavior - add the sidebar scope indicator and split environment-page navigation into explicit `Workspace-wide` and `Workspace admin` groups - remove redundant tenantless `All environments` scope badges from workspace-wide pages while preserving explicit environment filter affordances - include the Spec 338 artifacts, guard tests, and browser smoke coverage for the new contract ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Navigation/Spec338EnvironmentSidebarSeparationTest.php tests/Feature/Navigation/Spec338OperationRunLinksQueryContractTest.php tests/Feature/Navigation/Spec338SidebarScopeIndicatorTest.php tests/Feature/Filament/PanelNavigationSegregationTest.php` - `cd apps/platform && ./vendor/bin/sail php vendor/bin/pest tests/Browser/Spec338ScopeContractSmokeTest.php --compact` ## Notes - Livewire v4 compliance unchanged - Filament provider registration remains in `bootstrap/providers.php` - no destructive action behavior changed - no migrations, env var changes, or new Filament asset registration Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #409
87 lines
3.5 KiB
PHP
87 lines
3.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Pages\Monitoring\Operations;
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Models\OperationRun;
|
|
use App\Support\OperationRunLinks;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Livewire\Livewire;
|
|
|
|
it('Spec314 operations sidebar entry does not carry managed environment filters', function (): void {
|
|
$environment = ManagedEnvironment::factory()->active()->create();
|
|
[$user, $environment] = createUserWithTenant(tenant: $environment, role: 'owner');
|
|
$workspace = $environment->workspace()->firstOrFail();
|
|
|
|
Filament::setTenant($environment, true);
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $workspace->getKey());
|
|
session()->put(WorkspaceContext::LAST_ENVIRONMENT_IDS_SESSION_KEY, [
|
|
(string) $workspace->getKey() => (int) $environment->getKey(),
|
|
]);
|
|
|
|
$url = OperationRunLinks::index();
|
|
|
|
expect($url)->not->toContain('managed_environment_id')
|
|
->and($url)->not->toContain('tenant_scope')
|
|
->and($url)->not->toContain('tableFilters');
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $workspace->getKey()])
|
|
->get($url)
|
|
->assertOk()
|
|
->assertSee(__('localization.shell.choose_environment'))
|
|
->assertDontSee(__('localization.shell.no_environment_selected'))
|
|
->assertDontSee(__('localization.shell.all_environments'));
|
|
});
|
|
|
|
it('Spec314 operations clean workspace entry sees runs across entitled environments', function (): void {
|
|
$environmentA = ManagedEnvironment::factory()->active()->create();
|
|
[$user, $environmentA] = createUserWithTenant(tenant: $environmentA, role: 'owner');
|
|
|
|
$environmentB = ManagedEnvironment::factory()->active()->create([
|
|
'workspace_id' => (int) $environmentA->workspace_id,
|
|
]);
|
|
createUserWithTenant(tenant: $environmentB, user: $user, role: 'owner');
|
|
|
|
$runA = OperationRun::factory()->forTenant($environmentA)->create(['type' => 'policy.sync']);
|
|
$runB = OperationRun::factory()->forTenant($environmentB)->create(['type' => 'inventory_sync']);
|
|
|
|
$this->actingAs($user);
|
|
setAdminPanelContext();
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $environmentA->workspace_id);
|
|
|
|
Livewire::test(Operations::class)
|
|
->assertCanSeeTableRecords([$runA, $runB]);
|
|
});
|
|
|
|
it('Spec314 operations ignores stale persisted environment filters on clean entry', function (): void {
|
|
$environmentA = ManagedEnvironment::factory()->active()->create();
|
|
[$user, $environmentA] = createUserWithTenant(tenant: $environmentA, role: 'owner');
|
|
|
|
$environmentB = ManagedEnvironment::factory()->active()->create([
|
|
'workspace_id' => (int) $environmentA->workspace_id,
|
|
]);
|
|
createUserWithTenant(tenant: $environmentB, user: $user, role: 'owner');
|
|
|
|
$runA = OperationRun::factory()->forTenant($environmentA)->create();
|
|
$runB = OperationRun::factory()->forTenant($environmentB)->create();
|
|
|
|
$this->actingAs($user);
|
|
setAdminPanelContext();
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $environmentA->workspace_id);
|
|
|
|
$component = Livewire::test(Operations::class);
|
|
$filtersSessionKey = $component->instance()->getTableFiltersSessionKey();
|
|
|
|
session()->put($filtersSessionKey, [
|
|
'managed_environment_id' => ['value' => (string) $environmentA->getKey()],
|
|
]);
|
|
|
|
Livewire::test(Operations::class)
|
|
->assertCanSeeTableRecords([$runA, $runB]);
|
|
|
|
expect(data_get(session()->get($filtersSessionKey, []), 'managed_environment_id.value'))->toBeNull();
|
|
});
|