ahmido
b511b08371
Some checks failed
PR Fast Feedback / fast-feedback (pull_request) Failing after 1m0s
This PR removes the legacy "acknowledged" status compatibility for findings and unifies the canonical operation types (e.g., transitioning from baseline_capture to baseline.capture). It includes updated tests, models, and services to reflect these changes. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #296
68 lines
2.5 KiB
PHP
68 lines
2.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\Finding;
|
|
use App\Support\Badges\BadgeCatalog;
|
|
use App\Support\Badges\BadgeDomain;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('renders resolved status badge with neutral color', function (): void {
|
|
$spec = BadgeCatalog::spec(BadgeDomain::FindingStatus, Finding::STATUS_RESOLVED);
|
|
|
|
expect($spec->label)->toBe('Resolved')
|
|
->and($spec->color)->toBe('gray')
|
|
->and($spec->icon)->toBe('heroicon-o-check-circle');
|
|
});
|
|
|
|
it('still renders new status badge', function (): void {
|
|
$spec = BadgeCatalog::spec(BadgeDomain::FindingStatus, Finding::STATUS_NEW);
|
|
|
|
expect($spec->label)->toBe('New')
|
|
->and($spec->color)->toBe('warning');
|
|
});
|
|
|
|
it('renders unknown for removed acknowledged status badges', function (): void {
|
|
$spec = BadgeCatalog::spec(BadgeDomain::FindingStatus, 'acknowledged');
|
|
|
|
expect($spec->label)->toBe('Unknown')
|
|
->and($spec->color)->toBe('gray');
|
|
});
|
|
|
|
it('renders v2 workflow status badges', function (): void {
|
|
$triaged = BadgeCatalog::spec(BadgeDomain::FindingStatus, Finding::STATUS_TRIAGED);
|
|
$inProgress = BadgeCatalog::spec(BadgeDomain::FindingStatus, Finding::STATUS_IN_PROGRESS);
|
|
$reopened = BadgeCatalog::spec(BadgeDomain::FindingStatus, Finding::STATUS_REOPENED);
|
|
$closed = BadgeCatalog::spec(BadgeDomain::FindingStatus, Finding::STATUS_CLOSED);
|
|
$riskAccepted = BadgeCatalog::spec(BadgeDomain::FindingStatus, Finding::STATUS_RISK_ACCEPTED);
|
|
|
|
expect($triaged->label)->toBe('Triaged')
|
|
->and($inProgress->label)->toBe('In progress')
|
|
->and($reopened->label)->toBe('Reopened')
|
|
->and($closed->label)->toBe('Closed')
|
|
->and($riskAccepted->label)->toBe('Risk accepted');
|
|
});
|
|
|
|
it('renders permission_posture finding type badge', function (): void {
|
|
$spec = BadgeCatalog::spec(BadgeDomain::FindingType, Finding::FINDING_TYPE_PERMISSION_POSTURE);
|
|
|
|
expect($spec->label)->toBe('Permission posture')
|
|
->and($spec->color)->toBe('warning')
|
|
->and($spec->icon)->toBe('heroicon-m-shield-exclamation');
|
|
});
|
|
|
|
it('renders drift finding type badge', function (): void {
|
|
$spec = BadgeCatalog::spec(BadgeDomain::FindingType, Finding::FINDING_TYPE_DRIFT);
|
|
|
|
expect($spec->label)->toBe('Drift')
|
|
->and($spec->color)->toBe('info');
|
|
});
|
|
|
|
it('renders unknown for unrecognized finding type', function (): void {
|
|
$spec = BadgeCatalog::spec(BadgeDomain::FindingType, 'nonexistent_type');
|
|
|
|
expect($spec->label)->toBe('Unknown');
|
|
});
|