ahmido
d90fb0f963
PR Body Implements Spec 065 “Tenant RBAC v1” with capabilities-first RBAC, tenant membership scoping (Option 3), and consistent Filament action semantics. Key decisions / rules Tenancy Option 3: tenant switching is tenantless (ChooseTenant), tenant-scoped routes stay scoped, non-members get 404 (not 403). RBAC model: canonical capability registry + role→capability map + Gates for each capability (no role-string checks in UI logic). UX policy: for tenant members lacking permission → actions are visible but disabled + tooltip (avoid click→403). Security still enforced server-side. What’s included Capabilities foundation: Central capability registry (Capabilities::*) Role→capability mapping (RoleCapabilityMap) Gate registration + resolver/manager updates to support tenant-scoped authorization Filament enforcement hardening across the app: Tenant registration & tenant CRUD properly gated Backup/restore/policy flows aligned to “visible-but-disabled” where applicable Provider operations (health check / inventory sync / compliance snapshot) guarded and normalized Directory groups + inventory sync start surfaces normalized Policy version maintenance actions (archive/restore/prune/force delete) gated SpecKit artifacts for 065: spec.md, plan/tasks updates, checklists, enforcement hitlist Security guarantees Non-member → 404 via tenant scoping/membership guards. Member without capability → 403 on execution, even if UI is disabled. No destructive actions execute without proper authorization checks. Tests Adds/updates Pest coverage for: Tenant scoping & membership denial behavior Role matrix expectations (owner/manager/operator/readonly) Filament surface checks (visible/disabled actions, no side effects) Provider/Inventory/Groups run-start authorization Verified locally with targeted vendor/bin/sail artisan test --compact … Deployment / ops notes No new services required. Safe change: behavior is authorization + UI semantics; no breaking route changes intended. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Reviewed-on: #79
83 lines
2.9 KiB
PHP
83 lines
2.9 KiB
PHP
<?php
|
|
|
|
use App\Models\Policy;
|
|
use App\Models\PolicyVersion;
|
|
use App\Models\Tenant;
|
|
use App\Services\Graph\AssignmentFetcher;
|
|
use App\Services\Graph\AssignmentFilterResolver;
|
|
use App\Services\Graph\GroupResolver;
|
|
use App\Services\Graph\ScopeTagResolver;
|
|
use App\Services\Intune\AuditLogger;
|
|
use App\Services\Intune\PolicySnapshotService;
|
|
use App\Services\Intune\VersionService;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('retries and succeeds after a policy_versions unique collision during capture', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
$policy = Policy::factory()->for($tenant)->create();
|
|
$policy->load('tenant');
|
|
|
|
$service = new VersionService(
|
|
auditLogger: new AuditLogger,
|
|
snapshotService: Mockery::mock(PolicySnapshotService::class),
|
|
assignmentFetcher: Mockery::mock(AssignmentFetcher::class),
|
|
groupResolver: Mockery::mock(GroupResolver::class),
|
|
assignmentFilterResolver: Mockery::mock(AssignmentFilterResolver::class),
|
|
scopeTagResolver: Mockery::mock(ScopeTagResolver::class),
|
|
);
|
|
|
|
$fired = false;
|
|
$collisionInserted = false;
|
|
$dispatcher = PolicyVersion::getEventDispatcher();
|
|
|
|
PolicyVersion::creating(function (PolicyVersion $model) use (&$fired, &$collisionInserted): void {
|
|
if ($fired) {
|
|
return;
|
|
}
|
|
|
|
$fired = true;
|
|
|
|
PolicyVersion::withoutEvents(function () use ($model, &$collisionInserted): void {
|
|
PolicyVersion::query()->create([
|
|
'tenant_id' => $model->tenant_id,
|
|
'policy_id' => $model->policy_id,
|
|
'version_number' => $model->version_number,
|
|
'policy_type' => $model->policy_type,
|
|
'platform' => $model->platform,
|
|
'created_by' => $model->created_by,
|
|
'captured_at' => now(),
|
|
'snapshot' => $model->snapshot,
|
|
'metadata' => $model->metadata,
|
|
'assignments' => $model->assignments,
|
|
'scope_tags' => $model->scope_tags,
|
|
'assignments_hash' => $model->assignments_hash,
|
|
'scope_tags_hash' => $model->scope_tags_hash,
|
|
]);
|
|
|
|
$collisionInserted = true;
|
|
});
|
|
});
|
|
|
|
try {
|
|
$version = $service->captureVersion(
|
|
policy: $policy,
|
|
payload: ['id' => 'p-1'],
|
|
createdBy: 'tester@example.com',
|
|
metadata: ['source' => 'test'],
|
|
assignments: null,
|
|
scopeTags: null,
|
|
);
|
|
} finally {
|
|
PolicyVersion::flushEventListeners();
|
|
PolicyVersion::setEventDispatcher($dispatcher);
|
|
}
|
|
|
|
expect($fired)->toBeTrue();
|
|
expect($collisionInserted)->toBeTrue();
|
|
expect($version->policy_id)->toBe($policy->getKey());
|
|
expect($version->version_number)->toBe(1);
|
|
expect(PolicyVersion::query()->where('policy_id', $policy->getKey())->count())->toBe(1);
|
|
});
|