Implements workspace-scoped managed tenant onboarding wizard (Filament v5 / Livewire v4) with strict RBAC (404/403 semantics), resumable sessions, provider connection selection/creation, verification OperationRun, and optional bootstrap. Removes legacy onboarding entrypoints and adds Pest coverage + spec artifacts (073). ## Summary <!-- Kurz: Was ändert sich und warum? --> ## Spec-Driven Development (SDD) - [ ] Es gibt eine Spec unter `specs/<NNN>-<feature>/` - [ ] Enthaltene Dateien: `plan.md`, `tasks.md`, `spec.md` - [ ] Spec beschreibt Verhalten/Acceptance Criteria (nicht nur Implementation) - [ ] Wenn sich Anforderungen während der Umsetzung geändert haben: Spec/Plan/Tasks wurden aktualisiert ## Implementation - [ ] Implementierung entspricht der Spec - [ ] Edge cases / Fehlerfälle berücksichtigt - [ ] Keine unbeabsichtigten Änderungen außerhalb des Scopes ## Tests - [ ] Tests ergänzt/aktualisiert (Pest/PHPUnit) - [ ] Relevante Tests lokal ausgeführt (`./vendor/bin/sail artisan test` oder `php artisan test`) ## Migration / Config / Ops (falls relevant) - [ ] Migration(en) enthalten und getestet - [ ] Rollback bedacht (rückwärts kompatibel, sichere Migration) - [ ] Neue Env Vars dokumentiert (`.env.example` / Doku) - [ ] Queue/cron/storage Auswirkungen geprüft ## UI (Filament/Livewire) (falls relevant) - [ ] UI-Flows geprüft - [ ] Screenshots/Notizen hinzugefügt ## Notes <!-- Links, Screenshots, Follow-ups, offene Punkte --> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.fritz.box> Reviewed-on: #88
223 lines
7.2 KiB
PHP
223 lines
7.2 KiB
PHP
<?php
|
|
|
|
use App\Models\Policy;
|
|
use App\Models\PolicyVersion;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
|
|
beforeEach(function () {
|
|
putenv('INTUNE_TENANT_ID');
|
|
unset($_ENV['INTUNE_TENANT_ID'], $_SERVER['INTUNE_TENANT_ID']);
|
|
|
|
$this->tenant = Tenant::factory()->create();
|
|
$this->policy = Policy::factory()->create([
|
|
'tenant_id' => $this->tenant->id,
|
|
]);
|
|
$this->user = User::factory()->create();
|
|
[$this->user, $this->tenant] = createUserWithTenant($this->tenant, $this->user, role: 'owner');
|
|
});
|
|
|
|
it('displays policy version page', function () {
|
|
$version = PolicyVersion::factory()->create([
|
|
'tenant_id' => $this->tenant->id,
|
|
'policy_id' => $this->policy->id,
|
|
'version_number' => 1,
|
|
]);
|
|
|
|
$this->actingAs($this->user);
|
|
|
|
$response = $this->get(route('filament.admin.resources.policy-versions.view', array_merge(
|
|
filamentTenantRouteParams($this->tenant),
|
|
['record' => $version],
|
|
)));
|
|
|
|
$response->assertOk();
|
|
});
|
|
|
|
it('displays assignments widget when version has assignments', function () {
|
|
$version = PolicyVersion::factory()->create([
|
|
'tenant_id' => $this->tenant->id,
|
|
'policy_id' => $this->policy->id,
|
|
'version_number' => 1,
|
|
'assignments' => [
|
|
[
|
|
'id' => 'assignment-1',
|
|
'intent' => 'apply',
|
|
'target' => [
|
|
'@odata.type' => '#microsoft.graph.groupAssignmentTarget',
|
|
'groupId' => 'group-123',
|
|
'assignment_filter_name' => 'Targeted Devices',
|
|
'deviceAndAppManagementAssignmentFilterId' => 'filter-1',
|
|
'deviceAndAppManagementAssignmentFilterType' => 'include',
|
|
],
|
|
],
|
|
[
|
|
'id' => 'assignment-2',
|
|
'intent' => 'apply',
|
|
'target' => [
|
|
'@odata.type' => '#microsoft.graph.exclusionGroupAssignmentTarget',
|
|
'groupId' => 'group-456',
|
|
'deviceAndAppManagementAssignmentFilterId' => null,
|
|
'deviceAndAppManagementAssignmentFilterType' => 'none',
|
|
],
|
|
],
|
|
],
|
|
'scope_tags' => [
|
|
'ids' => ['0'],
|
|
'names' => ['Default'],
|
|
],
|
|
]);
|
|
|
|
$this->actingAs($this->user);
|
|
|
|
$response = $this->get(route('filament.admin.resources.policy-versions.view', array_merge(
|
|
filamentTenantRouteParams($this->tenant),
|
|
['record' => $version],
|
|
)));
|
|
|
|
$response->assertOk();
|
|
$response->assertSeeLivewire('policy-version-assignments-widget');
|
|
$response->assertSee('2 assignment(s)');
|
|
$response->assertSee('Include group');
|
|
$response->assertSee('Exclude group');
|
|
$response->assertSee('Filter (include): Targeted Devices');
|
|
});
|
|
|
|
it('displays empty state when version has no assignments', function () {
|
|
$version = PolicyVersion::factory()->create([
|
|
'tenant_id' => $this->tenant->id,
|
|
'policy_id' => $this->policy->id,
|
|
'version_number' => 1,
|
|
'assignments' => null,
|
|
]);
|
|
|
|
$this->actingAs($this->user);
|
|
|
|
$response = $this->get(route('filament.admin.resources.policy-versions.view', array_merge(
|
|
filamentTenantRouteParams($this->tenant),
|
|
['record' => $version],
|
|
)));
|
|
|
|
$response->assertOk();
|
|
$response->assertSee('Assignments were not captured for this version');
|
|
});
|
|
|
|
it('shows empty assignments message when assignments were fetched', function () {
|
|
$version = PolicyVersion::factory()->create([
|
|
'tenant_id' => $this->tenant->id,
|
|
'policy_id' => $this->policy->id,
|
|
'version_number' => 1,
|
|
'assignments' => null,
|
|
'metadata' => [
|
|
'assignments_fetched' => true,
|
|
'assignments_count' => 0,
|
|
],
|
|
]);
|
|
|
|
$this->actingAs($this->user);
|
|
|
|
$response = $this->get(route('filament.admin.resources.policy-versions.view', array_merge(
|
|
filamentTenantRouteParams($this->tenant),
|
|
['record' => $version],
|
|
)));
|
|
|
|
$response->assertOk();
|
|
$response->assertSee('No assignments found for this version');
|
|
});
|
|
|
|
it('shows compliance notifications when present', function () {
|
|
$version = PolicyVersion::factory()->create([
|
|
'tenant_id' => $this->tenant->id,
|
|
'policy_id' => $this->policy->id,
|
|
'version_number' => 1,
|
|
'policy_type' => 'deviceCompliancePolicy',
|
|
'assignments' => null,
|
|
'snapshot' => [
|
|
'scheduledActionsForRule' => [
|
|
[
|
|
'ruleName' => 'Test rule',
|
|
'scheduledActionConfigurations' => [
|
|
[
|
|
'actionType' => 'notification',
|
|
'notificationTemplateId' => 'template-123',
|
|
],
|
|
],
|
|
],
|
|
],
|
|
],
|
|
]);
|
|
|
|
$this->actingAs($this->user);
|
|
|
|
$response = $this->get(route('filament.admin.resources.policy-versions.view', array_merge(
|
|
filamentTenantRouteParams($this->tenant),
|
|
['record' => $version],
|
|
)));
|
|
|
|
$response->assertOk();
|
|
$response->assertSee('Compliance notifications');
|
|
$response->assertSee('Test rule');
|
|
$response->assertSee('template-123');
|
|
});
|
|
|
|
it('uses a default label when compliance rule name is missing', function () {
|
|
$version = PolicyVersion::factory()->create([
|
|
'tenant_id' => $this->tenant->id,
|
|
'policy_id' => $this->policy->id,
|
|
'version_number' => 1,
|
|
'policy_type' => 'deviceCompliancePolicy',
|
|
'assignments' => null,
|
|
'snapshot' => [
|
|
'scheduledActionsForRule' => [
|
|
[
|
|
'ruleName' => null,
|
|
'scheduledActionConfigurations' => [
|
|
[
|
|
'actionType' => 'notification',
|
|
'notificationTemplateId' => 'template-456',
|
|
],
|
|
],
|
|
],
|
|
],
|
|
],
|
|
]);
|
|
|
|
$this->actingAs($this->user);
|
|
|
|
$response = $this->get(route('filament.admin.resources.policy-versions.view', array_merge(
|
|
filamentTenantRouteParams($this->tenant),
|
|
['record' => $version],
|
|
)));
|
|
|
|
$response->assertOk();
|
|
$response->assertSee('Compliance notifications');
|
|
$response->assertSee('Default rule');
|
|
$response->assertSee('template-456');
|
|
});
|
|
|
|
it('renders structured normalized settings for compliance policy versions', function () {
|
|
$version = PolicyVersion::factory()->create([
|
|
'tenant_id' => $this->tenant->id,
|
|
'policy_id' => $this->policy->id,
|
|
'version_number' => 1,
|
|
'policy_type' => 'deviceCompliancePolicy',
|
|
'platform' => 'all',
|
|
'snapshot' => [
|
|
'@odata.type' => '#microsoft.graph.windows10CompliancePolicy',
|
|
'passwordRequired' => true,
|
|
],
|
|
]);
|
|
|
|
$this->actingAs($this->user);
|
|
|
|
$response = $this->get(route('filament.admin.resources.policy-versions.view', array_merge(
|
|
filamentTenantRouteParams($this->tenant),
|
|
['record' => $version],
|
|
)).'?tab=normalized-settings');
|
|
|
|
$response->assertOk();
|
|
$response->assertSee('Password & Access');
|
|
$response->assertSee('Password required');
|
|
$response->assertSee('Enabled');
|
|
});
|