ahmido
a490261eca
## Summary - standardize filter UX across key Filament resources with shared thin filter helpers for centralized option sourcing and archived/date-range presets - add persistence, essential filters, and OperationCatalog-aligned labels across the targeted resource tables - add and extend focused Pest coverage for guards, persistence, filter behavior, scope safety, and the new Spec 126 planning artifacts ## Spec 126 - add the full Spec 126 artifact set under `specs/126-filter-ux-standardization/` - align spec, plan, research, data model, quickstart, contract, checklist, and tasks for implementation readiness ## Validation - `vendor/bin/sail bin pint --dirty --format agent` - `vendor/bin/sail artisan test --compact tests/Feature/Guards/FilamentTableStandardsGuardTest.php tests/Feature/Filament/TableStatePersistenceTest.php tests/Feature/Findings/FindingsListFiltersTest.php tests/Feature/Findings/FindingsListDefaultsTest.php tests/Feature/Alerts/AlertDeliveryDeepLinkFiltersTest.php tests/Feature/Filament/Alerts/AlertDeliveryViewerTest.php tests/Feature/Filament/OperationRunListFiltersTest.php tests/Feature/Filament/PolicyVersionListFiltersTest.php tests/Feature/Filament/RestoreRunListFiltersTest.php tests/Feature/Filament/InventoryItemListFiltersTest.php tests/Feature/Filament/BaselineProfileListFiltersTest.php tests/Feature/ProviderConnections/TenantFilterOverrideTest.php tests/Feature/Rbac/InventoryItemResourceAuthorizationTest.php tests/Feature/Filament/BaselineTenantAssignmentsRelationManagerTest.php` ## Notes - no new OperationRun lifecycle or operational workflow behavior is introduced; only existing OperationRun table filter-label alignment and related coverage are in scope - existing authorization and action-surface semantics remain unchanged Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #154
70 lines
2.8 KiB
PHP
70 lines
2.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\BaselineProfileResource\Pages\EditBaselineProfile;
|
|
use App\Filament\Resources\BaselineProfileResource\RelationManagers\BaselineTenantAssignmentsRelationManager;
|
|
use App\Models\BaselineProfile;
|
|
use App\Models\BaselineTenantAssignment;
|
|
use App\Models\Tenant;
|
|
use Filament\Forms\Components\Select;
|
|
use Livewire\Livewire;
|
|
|
|
it('shows already assigned tenants as disabled with their baseline label', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$currentProfile = BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'name' => 'Current Baseline',
|
|
]);
|
|
|
|
$otherProfile = BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'name' => 'Device Hardening',
|
|
]);
|
|
|
|
BaselineTenantAssignment::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'baseline_profile_id' => (int) $currentProfile->getKey(),
|
|
]);
|
|
|
|
$assignedTenant = Tenant::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'name' => 'Already Assigned Tenant',
|
|
]);
|
|
|
|
$availableTenant = Tenant::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'name' => 'Available Tenant',
|
|
]);
|
|
|
|
BaselineTenantAssignment::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $assignedTenant->getKey(),
|
|
'baseline_profile_id' => (int) $otherProfile->getKey(),
|
|
]);
|
|
|
|
Livewire::actingAs($user)
|
|
->test(BaselineTenantAssignmentsRelationManager::class, [
|
|
'ownerRecord' => $currentProfile,
|
|
'pageClass' => EditBaselineProfile::class,
|
|
])
|
|
->mountTableAction('assign')
|
|
->assertFormFieldExists('tenant_id', function (Select $field) use ($assignedTenant, $availableTenant, $otherProfile): bool {
|
|
$options = $field->getOptions();
|
|
|
|
$assignedTenantKey = (int) $assignedTenant->getKey();
|
|
$availableTenantKey = (int) $availableTenant->getKey();
|
|
|
|
$assignedLabel = $options[$assignedTenantKey] ?? $options[(string) $assignedTenantKey] ?? null;
|
|
$availableLabel = $options[$availableTenantKey] ?? $options[(string) $availableTenantKey] ?? null;
|
|
|
|
return $field->isSearchable()
|
|
&& $assignedLabel === 'Already Assigned Tenant (assigned to baseline: '.$otherProfile->name.')'
|
|
&& $field->isOptionDisabled($assignedTenantKey, $assignedLabel)
|
|
&& $availableLabel === 'Available Tenant'
|
|
&& ! $field->isOptionDisabled($availableTenantKey, $availableLabel);
|
|
});
|
|
});
|