Summary This PR implements Spec 049 – Backup/Restore Job Orchestration: all critical Backup/Restore execution paths are job-only, idempotent, tenant-scoped, and observable via run records + DB notifications (Phase 1). The UI no longer performs heavy Graph work inside request/Filament actions for these flows. Why We want predictable UX and operations at MSP scale: • no timeouts / long-running requests • reproducible run state + per-item results • safe error persistence (no secrets / no token leakage) • strict tenant isolation + auditability for write paths What changed Foundational (Runs + Idempotency + Observability) • Added a shared RunIdempotency helper (dedupe while queued/running). • Added a read-only BulkOperationRuns surface (list + view) for status/progress. • Added DB notifications for run status changes (with “View run” link). US1 – Policy “Capture snapshot” is job-only • Policy detail “Capture snapshot” now: • creates/reuses a run (dedupe key: tenant + policy.capture_snapshot + policy DB id) • dispatches a queued job • returns immediately with notification + link to run detail • Graph capture work moved fully into the job; request path stays Graph-free. US3 – Restore runs orchestration is job-only + safe • Live restore execution is queued and updates RestoreRun status/progress. • Per-item outcomes are persisted deterministically (per internal DB record). • Audit logging is written for live restore. • Preview/dry-run is enforced as read-only (no writes). Tenant isolation / authorization (non-negotiable) • Run list/view/start are tenant-scoped and policy-guarded (cross-tenant access => 403, not 404). • Explicit Pest tests cover cross-tenant denial and start authorization. Tests / Verification • ./vendor/bin/pint --dirty • Targeted suite (examples): • policy capture snapshot queued + idempotency tests • restore orchestration + audit logging + preview read-only tests • run authorization / tenant isolation tests Notes / Scope boundaries • Phase 1 UX = DB notifications + run detail page. A global “progress widget” is tracked as Phase 2 and not required for merge. • Resilience/backoff is tracked in tasks but can be iterated further after merge. Review focus • Dedupe behavior for queued/running runs (reuse vs create-new) • Tenant scoping & policy gates for all run surfaces • Restore safety: audit event + preview no-writes Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #56
153 lines
4.2 KiB
PHP
153 lines
4.2 KiB
PHP
<?php
|
|
|
|
namespace App\Models;
|
|
|
|
use App\Support\RestoreRunStatus;
|
|
use Illuminate\Database\Eloquent\Builder;
|
|
use Illuminate\Database\Eloquent\Factories\HasFactory;
|
|
use Illuminate\Database\Eloquent\Model;
|
|
use Illuminate\Database\Eloquent\Relations\BelongsTo;
|
|
use Illuminate\Database\Eloquent\SoftDeletes;
|
|
|
|
class RestoreRun extends Model
|
|
{
|
|
use HasFactory;
|
|
use SoftDeletes;
|
|
|
|
protected $guarded = [];
|
|
|
|
protected $casts = [
|
|
'is_dry_run' => 'boolean',
|
|
'idempotency_key' => 'string',
|
|
'requested_items' => 'array',
|
|
'preview' => 'array',
|
|
'results' => 'array',
|
|
'metadata' => 'array',
|
|
'group_mapping' => 'array',
|
|
'started_at' => 'datetime',
|
|
'completed_at' => 'datetime',
|
|
];
|
|
|
|
public function tenant(): BelongsTo
|
|
{
|
|
return $this->belongsTo(Tenant::class);
|
|
}
|
|
|
|
public function backupSet(): BelongsTo
|
|
{
|
|
return $this->belongsTo(BackupSet::class)->withTrashed();
|
|
}
|
|
|
|
public function scopeDeletable(Builder $query): Builder
|
|
{
|
|
return $query->whereIn('status', array_map(
|
|
static fn (RestoreRunStatus $status): string => $status->value,
|
|
[
|
|
RestoreRunStatus::Draft,
|
|
RestoreRunStatus::Scoped,
|
|
RestoreRunStatus::Checked,
|
|
RestoreRunStatus::Previewed,
|
|
RestoreRunStatus::Completed,
|
|
RestoreRunStatus::Partial,
|
|
RestoreRunStatus::Failed,
|
|
RestoreRunStatus::Cancelled,
|
|
RestoreRunStatus::Aborted,
|
|
RestoreRunStatus::CompletedWithErrors,
|
|
]
|
|
));
|
|
}
|
|
|
|
public function isDeletable(): bool
|
|
{
|
|
$status = RestoreRunStatus::fromString($this->status);
|
|
|
|
return $status?->isDeletable() ?? false;
|
|
}
|
|
|
|
// Group mapping helpers
|
|
public function hasGroupMapping(): bool
|
|
{
|
|
return ! empty($this->group_mapping);
|
|
}
|
|
|
|
public function getMappedGroupId(string $sourceGroupId): ?string
|
|
{
|
|
$mapping = $this->group_mapping ?? [];
|
|
|
|
return $mapping[$sourceGroupId] ?? null;
|
|
}
|
|
|
|
public function isGroupSkipped(string $sourceGroupId): bool
|
|
{
|
|
$mapping = $this->group_mapping ?? [];
|
|
|
|
return ($mapping[$sourceGroupId] ?? null) === 'SKIP';
|
|
}
|
|
|
|
public function getUnmappedGroupIds(array $sourceGroupIds): array
|
|
{
|
|
return array_diff($sourceGroupIds, array_keys($this->group_mapping ?? []));
|
|
}
|
|
|
|
public function addGroupMapping(string $sourceGroupId, string $targetGroupId): void
|
|
{
|
|
$mapping = $this->group_mapping ?? [];
|
|
$mapping[$sourceGroupId] = $targetGroupId;
|
|
$this->group_mapping = $mapping;
|
|
}
|
|
|
|
// Assignment restore outcome helpers
|
|
public function getAssignmentRestoreOutcomes(): array
|
|
{
|
|
$results = $this->results ?? [];
|
|
|
|
if (isset($results['assignment_outcomes']) && is_array($results['assignment_outcomes'])) {
|
|
return $results['assignment_outcomes'];
|
|
}
|
|
|
|
if (isset($results['items']) && is_array($results['items'])) {
|
|
return collect($results['items'])
|
|
->pluck('assignment_outcomes')
|
|
->flatten(1)
|
|
->filter()
|
|
->values()
|
|
->all();
|
|
}
|
|
|
|
if (! is_array($results)) {
|
|
return [];
|
|
}
|
|
|
|
return collect($results)
|
|
->pluck('assignment_outcomes')
|
|
->flatten(1)
|
|
->filter()
|
|
->values()
|
|
->all();
|
|
}
|
|
|
|
public function getSuccessfulAssignmentsCount(): int
|
|
{
|
|
return count(array_filter(
|
|
$this->getAssignmentRestoreOutcomes(),
|
|
fn ($outcome) => $outcome['status'] === 'success'
|
|
));
|
|
}
|
|
|
|
public function getFailedAssignmentsCount(): int
|
|
{
|
|
return count(array_filter(
|
|
$this->getAssignmentRestoreOutcomes(),
|
|
fn ($outcome) => $outcome['status'] === 'failed'
|
|
));
|
|
}
|
|
|
|
public function getSkippedAssignmentsCount(): int
|
|
{
|
|
return count(array_filter(
|
|
$this->getAssignmentRestoreOutcomes(),
|
|
fn ($outcome) => $outcome['status'] === 'skipped'
|
|
));
|
|
}
|
|
}
|