Summary This PR implements Spec 049 – Backup/Restore Job Orchestration: all critical Backup/Restore execution paths are job-only, idempotent, tenant-scoped, and observable via run records + DB notifications (Phase 1). The UI no longer performs heavy Graph work inside request/Filament actions for these flows. Why We want predictable UX and operations at MSP scale: • no timeouts / long-running requests • reproducible run state + per-item results • safe error persistence (no secrets / no token leakage) • strict tenant isolation + auditability for write paths What changed Foundational (Runs + Idempotency + Observability) • Added a shared RunIdempotency helper (dedupe while queued/running). • Added a read-only BulkOperationRuns surface (list + view) for status/progress. • Added DB notifications for run status changes (with “View run” link). US1 – Policy “Capture snapshot” is job-only • Policy detail “Capture snapshot” now: • creates/reuses a run (dedupe key: tenant + policy.capture_snapshot + policy DB id) • dispatches a queued job • returns immediately with notification + link to run detail • Graph capture work moved fully into the job; request path stays Graph-free. US3 – Restore runs orchestration is job-only + safe • Live restore execution is queued and updates RestoreRun status/progress. • Per-item outcomes are persisted deterministically (per internal DB record). • Audit logging is written for live restore. • Preview/dry-run is enforced as read-only (no writes). Tenant isolation / authorization (non-negotiable) • Run list/view/start are tenant-scoped and policy-guarded (cross-tenant access => 403, not 404). • Explicit Pest tests cover cross-tenant denial and start authorization. Tests / Verification • ./vendor/bin/pint --dirty • Targeted suite (examples): • policy capture snapshot queued + idempotency tests • restore orchestration + audit logging + preview read-only tests • run authorization / tenant isolation tests Notes / Scope boundaries • Phase 1 UX = DB notifications + run detail page. A global “progress widget” is tracked as Phase 2 and not required for merge. • Resilience/backoff is tracked in tasks but can be iterated further after merge. Review focus • Dedupe behavior for queued/running runs (reuse vs create-new) • Tenant scoping & policy gates for all run surfaces • Restore safety: audit event + preview no-writes Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #56
122 lines
5.0 KiB
PHP
122 lines
5.0 KiB
PHP
<?php
|
|
|
|
namespace App\Filament\Resources\PolicyResource\Pages;
|
|
|
|
use App\Filament\Resources\BulkOperationRunResource;
|
|
use App\Filament\Resources\PolicyResource;
|
|
use App\Jobs\CapturePolicySnapshotJob;
|
|
use App\Services\BulkOperationService;
|
|
use App\Support\RunIdempotency;
|
|
use Filament\Actions\Action;
|
|
use Filament\Forms;
|
|
use Filament\Notifications\Notification;
|
|
use Filament\Resources\Pages\ViewRecord;
|
|
use Filament\Support\Enums\Width;
|
|
use Illuminate\Support\Str;
|
|
|
|
class ViewPolicy extends ViewRecord
|
|
{
|
|
protected static string $resource = PolicyResource::class;
|
|
|
|
protected Width|string|null $maxContentWidth = Width::Full;
|
|
|
|
protected function getActions(): array
|
|
{
|
|
return [
|
|
Action::make('capture_snapshot')
|
|
->label('Capture snapshot')
|
|
->requiresConfirmation()
|
|
->modalHeading('Capture snapshot now')
|
|
->modalSubheading('This queues a background job that fetches the latest configuration from Microsoft Graph and stores a new policy version.')
|
|
->form([
|
|
Forms\Components\Checkbox::make('include_assignments')
|
|
->label('Include assignments')
|
|
->default(true)
|
|
->helperText('Captures assignment include/exclude targeting and filters.'),
|
|
Forms\Components\Checkbox::make('include_scope_tags')
|
|
->label('Include scope tags')
|
|
->default(true)
|
|
->helperText('Captures policy scope tag IDs.'),
|
|
])
|
|
->action(function (array $data) {
|
|
$policy = $this->record;
|
|
|
|
$tenant = $policy->tenant;
|
|
$user = auth()->user();
|
|
|
|
if (! $tenant || ! $user) {
|
|
Notification::make()
|
|
->title('Missing tenant or user context.')
|
|
->danger()
|
|
->send();
|
|
|
|
return;
|
|
}
|
|
|
|
$idempotencyKey = RunIdempotency::buildKey(
|
|
tenantId: $tenant->getKey(),
|
|
operationType: 'policy.capture_snapshot',
|
|
targetId: $policy->getKey()
|
|
);
|
|
|
|
$existingRun = RunIdempotency::findActiveBulkOperationRun(
|
|
tenantId: $tenant->getKey(),
|
|
idempotencyKey: $idempotencyKey
|
|
);
|
|
|
|
if ($existingRun) {
|
|
Notification::make()
|
|
->title('Snapshot already in progress')
|
|
->body('An active run already exists for this policy. Opening run details.')
|
|
->actions([
|
|
\Filament\Actions\Action::make('view_run')
|
|
->label('View run')
|
|
->url(BulkOperationRunResource::getUrl('view', ['record' => $existingRun], tenant: $tenant)),
|
|
])
|
|
->info()
|
|
->send();
|
|
|
|
$this->redirect(BulkOperationRunResource::getUrl('view', ['record' => $existingRun], tenant: $tenant));
|
|
|
|
return;
|
|
}
|
|
|
|
$bulkOperationService = app(BulkOperationService::class);
|
|
|
|
$run = $bulkOperationService->createRun(
|
|
tenant: $tenant,
|
|
user: $user,
|
|
resource: 'policies',
|
|
action: 'capture_snapshot',
|
|
itemIds: [(string) $policy->getKey()],
|
|
totalItems: 1
|
|
);
|
|
|
|
$run->update(['idempotency_key' => $idempotencyKey]);
|
|
|
|
CapturePolicySnapshotJob::dispatch(
|
|
bulkOperationRunId: $run->getKey(),
|
|
policyId: $policy->getKey(),
|
|
includeAssignments: (bool) ($data['include_assignments'] ?? false),
|
|
includeScopeTags: (bool) ($data['include_scope_tags'] ?? false),
|
|
createdBy: $user->email ? Str::limit($user->email, 255, '') : null
|
|
);
|
|
|
|
Notification::make()
|
|
->title('Snapshot queued')
|
|
->body('A background job has been queued. You can monitor progress in the run details.')
|
|
->actions([
|
|
\Filament\Actions\Action::make('view_run')
|
|
->label('View run')
|
|
->url(BulkOperationRunResource::getUrl('view', ['record' => $run], tenant: $tenant)),
|
|
])
|
|
->success()
|
|
->send();
|
|
|
|
$this->redirect(BulkOperationRunResource::getUrl('view', ['record' => $run], tenant: $tenant));
|
|
})
|
|
->color('primary'),
|
|
];
|
|
}
|
|
}
|