Summary This PR implements Spec 049 – Backup/Restore Job Orchestration: all critical Backup/Restore execution paths are job-only, idempotent, tenant-scoped, and observable via run records + DB notifications (Phase 1). The UI no longer performs heavy Graph work inside request/Filament actions for these flows. Why We want predictable UX and operations at MSP scale: • no timeouts / long-running requests • reproducible run state + per-item results • safe error persistence (no secrets / no token leakage) • strict tenant isolation + auditability for write paths What changed Foundational (Runs + Idempotency + Observability) • Added a shared RunIdempotency helper (dedupe while queued/running). • Added a read-only BulkOperationRuns surface (list + view) for status/progress. • Added DB notifications for run status changes (with “View run” link). US1 – Policy “Capture snapshot” is job-only • Policy detail “Capture snapshot” now: • creates/reuses a run (dedupe key: tenant + policy.capture_snapshot + policy DB id) • dispatches a queued job • returns immediately with notification + link to run detail • Graph capture work moved fully into the job; request path stays Graph-free. US3 – Restore runs orchestration is job-only + safe • Live restore execution is queued and updates RestoreRun status/progress. • Per-item outcomes are persisted deterministically (per internal DB record). • Audit logging is written for live restore. • Preview/dry-run is enforced as read-only (no writes). Tenant isolation / authorization (non-negotiable) • Run list/view/start are tenant-scoped and policy-guarded (cross-tenant access => 403, not 404). • Explicit Pest tests cover cross-tenant denial and start authorization. Tests / Verification • ./vendor/bin/pint --dirty • Targeted suite (examples): • policy capture snapshot queued + idempotency tests • restore orchestration + audit logging + preview read-only tests • run authorization / tenant isolation tests Notes / Scope boundaries • Phase 1 UX = DB notifications + run detail page. A global “progress widget” is tracked as Phase 2 and not required for merge. • Resilience/backoff is tracked in tasks but can be iterated further after merge. Review focus • Dedupe behavior for queued/running runs (reuse vs create-new) • Tenant scoping & policy gates for all run surfaces • Restore safety: audit event + preview no-writes Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #56
113 lines
3.8 KiB
PHP
113 lines
3.8 KiB
PHP
<?php
|
|
|
|
namespace App\Providers;
|
|
|
|
use App\Models\BackupSchedule;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use App\Models\UserTenantPreference;
|
|
use App\Policies\BackupSchedulePolicy;
|
|
use App\Services\Graph\GraphClientInterface;
|
|
use App\Services\Graph\MicrosoftGraphClient;
|
|
use App\Services\Graph\NullGraphClient;
|
|
use App\Services\Intune\AppProtectionPolicyNormalizer;
|
|
use App\Services\Intune\CompliancePolicyNormalizer;
|
|
use App\Services\Intune\DeviceConfigurationPolicyNormalizer;
|
|
use App\Services\Intune\EnrollmentAutopilotPolicyNormalizer;
|
|
use App\Services\Intune\GroupPolicyConfigurationNormalizer;
|
|
use App\Services\Intune\ManagedDeviceAppConfigurationNormalizer;
|
|
use App\Services\Intune\ScriptsPolicyNormalizer;
|
|
use App\Services\Intune\SettingsCatalogPolicyNormalizer;
|
|
use App\Services\Intune\TermsAndConditionsNormalizer;
|
|
use App\Services\Intune\WindowsDriverUpdateProfileNormalizer;
|
|
use App\Services\Intune\WindowsFeatureUpdateProfileNormalizer;
|
|
use App\Services\Intune\WindowsQualityUpdateProfileNormalizer;
|
|
use App\Services\Intune\WindowsUpdateRingNormalizer;
|
|
use Filament\Events\TenantSet;
|
|
use Illuminate\Support\Facades\Event;
|
|
use Illuminate\Support\Facades\Gate;
|
|
use Illuminate\Support\Facades\Schema;
|
|
use Illuminate\Support\ServiceProvider;
|
|
|
|
class AppServiceProvider extends ServiceProvider
|
|
{
|
|
/**
|
|
* Register any application services.
|
|
*/
|
|
public function register(): void
|
|
{
|
|
$this->app->singleton(GraphClientInterface::class, function ($app) {
|
|
$config = $app['config']->get('graph');
|
|
|
|
$hasCredentials = ! empty($config['client_id'])
|
|
&& ! empty($config['client_secret'])
|
|
&& ! empty($config['tenant_id']);
|
|
|
|
if (! empty($config['enabled']) && $hasCredentials) {
|
|
return $app->make(MicrosoftGraphClient::class);
|
|
}
|
|
|
|
return $app->make(NullGraphClient::class);
|
|
});
|
|
|
|
$this->app->tag(
|
|
[
|
|
AppProtectionPolicyNormalizer::class,
|
|
CompliancePolicyNormalizer::class,
|
|
DeviceConfigurationPolicyNormalizer::class,
|
|
EnrollmentAutopilotPolicyNormalizer::class,
|
|
GroupPolicyConfigurationNormalizer::class,
|
|
ManagedDeviceAppConfigurationNormalizer::class,
|
|
ScriptsPolicyNormalizer::class,
|
|
SettingsCatalogPolicyNormalizer::class,
|
|
TermsAndConditionsNormalizer::class,
|
|
WindowsDriverUpdateProfileNormalizer::class,
|
|
WindowsFeatureUpdateProfileNormalizer::class,
|
|
WindowsQualityUpdateProfileNormalizer::class,
|
|
WindowsUpdateRingNormalizer::class,
|
|
],
|
|
'policy-type-normalizers'
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Bootstrap any application services.
|
|
*/
|
|
public function boot(): void
|
|
{
|
|
Event::listen(TenantSet::class, function (TenantSet $event): void {
|
|
static $hasPreferencesTable;
|
|
|
|
$hasPreferencesTable ??= Schema::hasTable('user_tenant_preferences');
|
|
|
|
if (! $hasPreferencesTable) {
|
|
return;
|
|
}
|
|
|
|
$tenant = $event->getTenant();
|
|
$user = $event->getUser();
|
|
|
|
if (! $tenant instanceof Tenant) {
|
|
return;
|
|
}
|
|
|
|
if (! $user instanceof User) {
|
|
return;
|
|
}
|
|
|
|
UserTenantPreference::query()->updateOrCreate(
|
|
[
|
|
'user_id' => $user->getKey(),
|
|
'tenant_id' => $tenant->getKey(),
|
|
],
|
|
[
|
|
'last_used_at' => now(),
|
|
],
|
|
);
|
|
});
|
|
|
|
Gate::policy(BackupSchedule::class, BackupSchedulePolicy::class);
|
|
Gate::policy(BulkOperationRun::class, BulkOperationRunPolicy::class);
|
|
}
|
|
}
|