Some checks failed
Main Confidence / confidence (push) Failing after 53s
## Summary This PR delivers three related improvements: ### 1. Finding Ownership Semantics (Spec 219) - Add responsibility/accountability labels to findings and finding exceptions - `owner_user_id` = accountable party (governance owner) - `assignee_user_id` = responsible party (technical implementer) - Expose Assign/Reassign actions in FindingResource with audit logging - Add ownership columns and filters to finding list - Propagate owner from finding to exception on creation - Tests: ownership semantics, assignment audit, workflow actions ### 2. Constitution v2.7.0 — LEAN-001 Pre-Production Lean Doctrine - New principle forbidding legacy aliases, migration shims, dual-write logic, and compatibility fixtures in a pre-production codebase - AI-agent 4-question verification gate before adding any compatibility path - Review rule: compatibility shims without answering the gate questions = merge blocker - Exit condition: LEAN-001 expires at first production deployment - Spec template: added default "Compatibility posture" block - Agent instructions: added "Pre-production compatibility check" section ### 3. Backup Set Operation Type Unification - Unified `backup_set.add_policies` and `backup_set.remove_policies` into single canonical `backup_set.update` - Removed all legacy aliases, constants, and test fixtures - Added lifecycle coverage for `backup_set.update` in config - Updated all 14+ test files referencing legacy types ### Spec Artifacts - `specs/219-finding-ownership-semantics/` — full spec, plan, tasks, research, data model, contracts, checklist ### Tests - All affected tests pass (OperationCatalog, backup set, finding workflow, ownership semantics) Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #256
275 lines
8.1 KiB
PHP
275 lines
8.1 KiB
PHP
<?php
|
|
|
|
use App\Jobs\AddPoliciesToBackupSetJob;
|
|
use App\Livewire\BackupSetPolicyPickerTable;
|
|
use App\Models\BackupSet;
|
|
use App\Models\OperationRun;
|
|
use App\Models\Policy;
|
|
use App\Models\PolicyVersion;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use App\Services\Intune\BackupService;
|
|
use App\Support\OpsUx\OperationUxPresenter;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Support\Facades\Queue;
|
|
use Livewire\Livewire;
|
|
use Mockery\MockInterface;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
test('policy picker table queues add policies job and creates a run (no inline capture)', function () {
|
|
Queue::fake();
|
|
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$backupSet = BackupSet::factory()->create([
|
|
'tenant_id' => $tenant->id,
|
|
'name' => 'Test backup',
|
|
]);
|
|
|
|
$policies = Policy::factory()->count(2)->create([
|
|
'tenant_id' => $tenant->id,
|
|
'ignored_at' => null,
|
|
'last_synced_at' => now(),
|
|
]);
|
|
|
|
$this->mock(BackupService::class, function (MockInterface $mock) {
|
|
$mock->shouldReceive('addPoliciesToSet')->never();
|
|
});
|
|
|
|
bindFailHardGraphClient();
|
|
|
|
Livewire::actingAs($user)
|
|
->test(BackupSetPolicyPickerTable::class, [
|
|
'backupSetId' => $backupSet->id,
|
|
])
|
|
->callTableBulkAction('add_selected_to_backup_set', $policies)
|
|
->assertHasNoTableBulkActionErrors();
|
|
|
|
Queue::assertPushed(AddPoliciesToBackupSetJob::class, 1);
|
|
|
|
$policyIds = $policies
|
|
->pluck('id')
|
|
->map(fn (mixed $value): int => (int) $value)
|
|
->sort()
|
|
->values()
|
|
->all();
|
|
|
|
$run = OperationRun::query()
|
|
->where('tenant_id', $tenant->id)
|
|
->where('type', 'backup_set.update')
|
|
->latest('id')
|
|
->first();
|
|
|
|
expect($run)->not->toBeNull();
|
|
expect($run?->status)->toBe('queued');
|
|
expect($run?->outcome)->toBe('pending');
|
|
expect($run?->context['backup_set_id'] ?? null)->toBe($backupSet->getKey());
|
|
expect($run?->context['policy_count'] ?? null)->toBe(count($policyIds));
|
|
expect($run?->context['operation']['type'] ?? null)->toBe('backup_set.update');
|
|
expect($run?->context['selection']['kind'] ?? null)->toBe('ids');
|
|
expect($run?->context['idempotency']['fingerprint'] ?? null)->not->toBeNull();
|
|
|
|
$notifications = session('filament.notifications', []);
|
|
|
|
expect($notifications)->not->toBeEmpty();
|
|
expect(collect($notifications)->last()['title'] ?? null)->toBe('Backup set update queued');
|
|
});
|
|
|
|
test('policy picker table reuses an active run on double click (idempotency)', function () {
|
|
Queue::fake();
|
|
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$backupSet = BackupSet::factory()->create([
|
|
'tenant_id' => $tenant->id,
|
|
'name' => 'Test backup',
|
|
]);
|
|
|
|
$policies = Policy::factory()->count(2)->create([
|
|
'tenant_id' => $tenant->id,
|
|
'ignored_at' => null,
|
|
'last_synced_at' => now(),
|
|
]);
|
|
|
|
$policyIds = $policies
|
|
->pluck('id')
|
|
->map(fn (mixed $value): int => (int) $value)
|
|
->sort()
|
|
->values()
|
|
->all();
|
|
|
|
Livewire::actingAs($user)
|
|
->test(BackupSetPolicyPickerTable::class, [
|
|
'backupSetId' => $backupSet->id,
|
|
])
|
|
->callTableBulkAction('add_selected_to_backup_set', $policies);
|
|
|
|
Livewire::actingAs($user)
|
|
->test(BackupSetPolicyPickerTable::class, [
|
|
'backupSetId' => $backupSet->id,
|
|
])
|
|
->callTableBulkAction('add_selected_to_backup_set', $policies);
|
|
|
|
expect(OperationRun::query()
|
|
->where('tenant_id', $tenant->id)
|
|
->where('type', 'backup_set.update')
|
|
->count())->toBe(1);
|
|
|
|
Queue::assertPushed(AddPoliciesToBackupSetJob::class, 1);
|
|
|
|
$notifications = session('filament.notifications', []);
|
|
$expectedToast = OperationUxPresenter::alreadyQueuedToast('backup_set.update');
|
|
|
|
expect($notifications)->not->toBeEmpty();
|
|
expect(collect($notifications)->last()['title'] ?? null)->toBe($expectedToast->getTitle());
|
|
expect(collect($notifications)->last()['body'] ?? null)->toBe($expectedToast->getBody());
|
|
});
|
|
|
|
test('policy picker table forbids readonly users from starting add policies (403)', function () {
|
|
Queue::fake();
|
|
|
|
[$user, $tenant] = createUserWithTenant(role: 'readonly');
|
|
$this->actingAs($user);
|
|
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$backupSet = BackupSet::factory()->create([
|
|
'tenant_id' => $tenant->id,
|
|
'name' => 'Test backup',
|
|
]);
|
|
|
|
$policies = Policy::factory()->count(1)->create([
|
|
'tenant_id' => $tenant->id,
|
|
'ignored_at' => null,
|
|
'last_synced_at' => now(),
|
|
]);
|
|
|
|
$thrown = null;
|
|
|
|
try {
|
|
Livewire::actingAs($user)
|
|
->test(BackupSetPolicyPickerTable::class, [
|
|
'backupSetId' => $backupSet->id,
|
|
])
|
|
->callTableBulkAction('add_selected_to_backup_set', $policies);
|
|
} catch (Throwable $exception) {
|
|
$thrown = $exception;
|
|
}
|
|
|
|
expect($thrown)->not->toBeNull();
|
|
|
|
Queue::assertNothingPushed();
|
|
|
|
expect(OperationRun::query()
|
|
->where('tenant_id', $tenant->id)
|
|
->where('type', 'backup_set.update')
|
|
->exists())->toBeFalse();
|
|
});
|
|
|
|
test('policy picker table rejects cross-tenant starts (403) with no run records created', function () {
|
|
Queue::fake();
|
|
|
|
$tenantA = Tenant::factory()->create();
|
|
$tenantB = Tenant::factory()->create();
|
|
|
|
$user = User::factory()->create();
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$tenantA->getKey() => ['role' => 'owner'],
|
|
$tenantB->getKey() => ['role' => 'owner'],
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
|
|
$tenantA->makeCurrent();
|
|
Filament::setTenant($tenantA, true);
|
|
|
|
$backupSetB = BackupSet::factory()->create([
|
|
'tenant_id' => $tenantB->id,
|
|
'name' => 'Tenant B backup',
|
|
]);
|
|
|
|
$policiesB = Policy::factory()->count(1)->create([
|
|
'tenant_id' => $tenantB->id,
|
|
'ignored_at' => null,
|
|
'last_synced_at' => now(),
|
|
]);
|
|
|
|
$thrown = null;
|
|
|
|
try {
|
|
Livewire::actingAs($user)
|
|
->test(BackupSetPolicyPickerTable::class, [
|
|
'backupSetId' => $backupSetB->id,
|
|
])
|
|
->callTableBulkAction('add_selected_to_backup_set', $policiesB);
|
|
} catch (Throwable $exception) {
|
|
$thrown = $exception;
|
|
}
|
|
|
|
expect($thrown)->not->toBeNull();
|
|
|
|
Queue::assertNothingPushed();
|
|
|
|
expect(OperationRun::query()
|
|
->where('tenant_id', $tenantA->id)
|
|
->where('type', 'backup_set.update')
|
|
->exists())->toBeFalse();
|
|
|
|
expect(OperationRun::query()
|
|
->where('tenant_id', $tenantB->id)
|
|
->where('type', 'backup_set.update')
|
|
->exists())->toBeFalse();
|
|
});
|
|
|
|
test('policy picker table can filter by has versions', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
$tenant->makeCurrent();
|
|
|
|
$user = User::factory()->create();
|
|
|
|
$backupSet = BackupSet::factory()->create([
|
|
'tenant_id' => $tenant->id,
|
|
'name' => 'Test backup',
|
|
]);
|
|
|
|
$withVersions = Policy::factory()->create([
|
|
'tenant_id' => $tenant->id,
|
|
'display_name' => 'With Versions',
|
|
'ignored_at' => null,
|
|
'last_synced_at' => now(),
|
|
]);
|
|
|
|
PolicyVersion::factory()->create([
|
|
'tenant_id' => $tenant->id,
|
|
'policy_id' => $withVersions->id,
|
|
'policy_type' => $withVersions->policy_type,
|
|
'platform' => $withVersions->platform,
|
|
]);
|
|
|
|
$withoutVersions = Policy::factory()->create([
|
|
'tenant_id' => $tenant->id,
|
|
'display_name' => 'Without Versions',
|
|
'ignored_at' => null,
|
|
'last_synced_at' => now(),
|
|
]);
|
|
|
|
Livewire::actingAs($user)
|
|
->test(BackupSetPolicyPickerTable::class, [
|
|
'backupSetId' => $backupSet->id,
|
|
])
|
|
->filterTable('has_versions', '1')
|
|
->assertSee('With Versions')
|
|
->assertDontSee('Without Versions');
|
|
});
|