ahmido
c86b399b43
Some checks failed
Main Confidence / confidence (push) Failing after 53s
## Summary This PR delivers three related improvements: ### 1. Finding Ownership Semantics (Spec 219) - Add responsibility/accountability labels to findings and finding exceptions - `owner_user_id` = accountable party (governance owner) - `assignee_user_id` = responsible party (technical implementer) - Expose Assign/Reassign actions in FindingResource with audit logging - Add ownership columns and filters to finding list - Propagate owner from finding to exception on creation - Tests: ownership semantics, assignment audit, workflow actions ### 2. Constitution v2.7.0 — LEAN-001 Pre-Production Lean Doctrine - New principle forbidding legacy aliases, migration shims, dual-write logic, and compatibility fixtures in a pre-production codebase - AI-agent 4-question verification gate before adding any compatibility path - Review rule: compatibility shims without answering the gate questions = merge blocker - Exit condition: LEAN-001 expires at first production deployment - Spec template: added default "Compatibility posture" block - Agent instructions: added "Pre-production compatibility check" section ### 3. Backup Set Operation Type Unification - Unified `backup_set.add_policies` and `backup_set.remove_policies` into single canonical `backup_set.update` - Removed all legacy aliases, constants, and test fixtures - Added lifecycle coverage for `backup_set.update` in config - Updated all 14+ test files referencing legacy types ### Spec Artifacts - `specs/219-finding-ownership-semantics/` — full spec, plan, tasks, research, data model, contracts, checklist ### Tests - All affected tests pass (OperationCatalog, backup set, finding workflow, ownership semantics) Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #256
95 lines
2.6 KiB
PHP
95 lines
2.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\OperationRun;
|
|
use App\Services\OperationRunService;
|
|
use Filament\Facades\Filament;
|
|
|
|
it('increments only whitelisted summary_counts keys', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'initiator_name' => $user->name,
|
|
'type' => 'policy.delete',
|
|
'status' => 'queued',
|
|
'outcome' => 'pending',
|
|
'context' => ['operation' => ['type' => 'policy.delete']],
|
|
'summary_counts' => [
|
|
'total' => 10,
|
|
'processed' => 1,
|
|
'secrets' => 999,
|
|
],
|
|
]);
|
|
|
|
/** @var OperationRunService $service */
|
|
$service = app(OperationRunService::class);
|
|
|
|
$service->incrementSummaryCounts($run, [
|
|
'processed' => 2,
|
|
'failed' => 1,
|
|
'secrets' => 123,
|
|
]);
|
|
|
|
$run->refresh();
|
|
|
|
expect($run->summary_counts['total'] ?? null)->toBe(10);
|
|
expect($run->summary_counts['processed'] ?? null)->toBe(3);
|
|
expect($run->summary_counts['failed'] ?? null)->toBe(1);
|
|
expect($run->summary_counts)->not->toHaveKey('secrets');
|
|
})->group('ops-ux');
|
|
|
|
it('increments canonical backup-flow summary keys used by RBAC foundation capture', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'initiator_name' => $user->name,
|
|
'type' => 'backup_set.update',
|
|
'status' => 'queued',
|
|
'outcome' => 'pending',
|
|
'context' => ['options' => ['include_foundations' => true]],
|
|
'summary_counts' => [
|
|
'total' => 1,
|
|
'processed' => 1,
|
|
'succeeded' => 1,
|
|
'created' => 1,
|
|
'items' => 1,
|
|
],
|
|
]);
|
|
|
|
/** @var OperationRunService $service */
|
|
$service = app(OperationRunService::class);
|
|
|
|
$service->incrementSummaryCounts($run, [
|
|
'total' => 2,
|
|
'items' => 2,
|
|
'processed' => 2,
|
|
'succeeded' => 2,
|
|
'created' => 1,
|
|
'updated' => 1,
|
|
'secrets' => 123,
|
|
]);
|
|
|
|
$run->refresh();
|
|
|
|
expect($run->summary_counts)->toMatchArray([
|
|
'total' => 3,
|
|
'processed' => 3,
|
|
'succeeded' => 3,
|
|
'created' => 2,
|
|
'updated' => 1,
|
|
'items' => 3,
|
|
]);
|
|
expect($run->summary_counts)->not->toHaveKey('secrets');
|
|
})->group('ops-ux');
|